Skip to content

Commit ea8c337

Browse files
Merge pull request #3658 from RedisInsight/bugfix/RI-5961-rdi-text
change text and fix statistics
2 parents 05fe99a + 99e417a commit ea8c337

File tree

5 files changed

+53
-39
lines changed

5 files changed

+53
-39
lines changed

redisinsight/ui/src/pages/rdi/pipeline-management/components/download/Download.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const Download = ({ dataTestid }: Props) => {
5151
aria-labelledby="Download pipeline button"
5252
data-testid={dataTestid || 'download-pipeline-btn'}
5353
>
54-
Download
54+
Save to file
5555
</EuiButtonEmpty>
5656
)
5757
}

redisinsight/ui/src/pages/rdi/pipeline-management/components/fetch-pipeline-popover/FetchPipelinePopover.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,12 @@ const FetchPipelinePopover = () => {
4444

4545
return (
4646
<ConfirmationPopover
47-
title="Upload a pipeline from the server"
47+
title="Download a pipeline from the server"
4848
body={(
4949
<>
5050
<EuiText size="s">
5151
When downloading a new pipeline from the server,
52-
it will overwrite the existing one displayed in RedisInsight.
53-
</EuiText>
54-
<EuiText size="s">
55-
Download the current pipeline to save the changes locally.
52+
it will overwrite the existing one displayed in Redis Insight.
5653
</EuiText>
5754
</>
5855
)}
@@ -63,7 +60,7 @@ const FetchPipelinePopover = () => {
6360
color="secondary"
6461
data-testid="upload-confirm-btn"
6562
>
66-
Upload
63+
Download from server
6764
</EuiButton>
6865
)}
6966
onConfirm={handleRefreshClick}

redisinsight/ui/src/pages/rdi/statistics/data-streams/DataStreams.spec.tsx

Lines changed: 30 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,39 @@ import DataStreams from './DataStreams'
55

66
const mockedProps = {
77
data: {
8-
stream1: {
9-
total: 11,
10-
pending: 5,
11-
inserted: 3,
12-
updated: 2,
13-
deleted: 1,
8+
totals: {
9+
total: 31,
10+
pending: 15,
11+
inserted: 9,
12+
updated: 6,
13+
deleted: 3,
1414
filtered: 0,
1515
rejected: 0,
1616
deduplicated: 0,
17-
lastArrival: '2022-01-01'
1817
},
19-
stream2: {
20-
total: 20,
21-
pending: 10,
22-
inserted: 6,
23-
updated: 4,
24-
deleted: 2,
25-
filtered: 0,
26-
rejected: 0,
27-
deduplicated: 0,
28-
lastArrival: '2022-01-02'
18+
streams: {
19+
stream1: {
20+
total: 11,
21+
pending: 5,
22+
inserted: 3,
23+
updated: 2,
24+
deleted: 1,
25+
filtered: 0,
26+
rejected: 0,
27+
deduplicated: 0,
28+
lastArrival: '2022-01-01'
29+
},
30+
stream2: {
31+
total: 20,
32+
pending: 10,
33+
inserted: 6,
34+
updated: 4,
35+
deleted: 2,
36+
filtered: 0,
37+
rejected: 0,
38+
deduplicated: 0,
39+
lastArrival: '2022-01-02'
40+
}
2941
}
3042
},
3143
loading: false,
@@ -47,6 +59,6 @@ describe('DataStreams', () => {
4759

4860
// Assert that the data rows are rendered
4961
const dataRows = screen.getAllByRole('row')
50-
expect(dataRows).toHaveLength(3) // 2 data rows + 1 header row
62+
expect(dataRows).toHaveLength(4) // 2 data rows + 1 header row + 1 totals row
5163
})
5264
})

redisinsight/ui/src/pages/rdi/statistics/data-streams/DataStreams.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type DataStreamsData = {
1717
filtered: number
1818
rejected: number
1919
deduplicated: number
20-
lastArrival: string
20+
lastArrival?: string
2121
}
2222

2323
const columns: EuiBasicTableColumn<DataStreamsData>[] = [
@@ -88,13 +88,13 @@ interface Props {
8888
}
8989

9090
const DataStreams = ({ data, loading, onRefresh, onRefreshClicked, onChangeAutoRefresh }: Props) => {
91-
const dataStreams = Object.keys(data).map((key) => {
92-
const dataStream = data[key]
91+
const dataStreams = Object.keys(data?.streams || {}).map((key) => {
92+
const dataStream = data.streams[key]
9393
return {
9494
name: key,
9595
...dataStream
9696
}
97-
})
97+
}).concat([{ name: 'Total', ...(data?.totals || {}) }])
9898

9999
return (
100100
<Panel>

redisinsight/ui/src/slices/interfaces/rdi.ts

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,22 @@ export interface IConnections {
6262
}
6363
}
6464

65+
export interface IDataStreamsData {
66+
total: number
67+
pending: number
68+
inserted: number
69+
updated: number
70+
deleted: number
71+
filtered: number
72+
rejected: number
73+
deduplicated: number
74+
lastArrival?: string
75+
}
76+
6577
export interface IDataStreams {
66-
[key: string]: {
67-
total: number
68-
pending: number
69-
inserted: number
70-
updated: number
71-
deleted: number
72-
filtered: number
73-
rejected: number
74-
deduplicated: number
75-
lastArrival: string
78+
totals: IDataStreamsData,
79+
streams: {
80+
[key: string]: IDataStreamsData
7681
}
7782
}
7883

0 commit comments

Comments
 (0)