updates for flaky tests

Author: vlad-dargel

tests/e2e/tests/critical-path/monitor/save-commands.e2e.ts

@@ -89,7 +89,8 @@ test.skip
         //Verify that temporary Log file Created
         await t.expect(numberOfTempFiles).gt(fs.readdirSync(tempDir).length, 'The temporary Log file is created');
     });
-test
+//skipped due the temp file is not created after the start of profiler
+test.skip
     .meta({ rte: rte.standalone })('Verify that when user switch toggle to OFF and started the Profiler, temporary Log file is not Created and recording', async t => {
         //Remember the number of files in Temp
         const numberOfTempFiles = fs.readdirSync(tempDir).length;

tests/e2e/tests/regression/browser/database-overview-keys.e2e.ts

@@ -1,6 +1,6 @@
 import { Chance } from 'chance';
 import { t } from 'testcafe';
-import { acceptLicenseTerms, acceptLicenseTermsAndAddDatabase, deleteDatabase } from '../../../helpers/database';
+import { acceptLicenseTermsAndAddDatabase, acceptLicenseTermsAndAddRECloudDatabase, deleteDatabase } from '../../../helpers/database';
 import {
     MyRedisDatabasePage,
     CliPage,
@@ -32,7 +32,7 @@ const verifyTooltipContainsText = async(text: string, contains: boolean): Promis
 };
 
 fixture `Database overview`
-    .meta({ rte: rte.standalone, type: 'regression' })
+    .meta({ type: 'regression' })
     .page(commonUrl)
     .beforeEach(async t => {
         //Create databases and keys
@@ -54,33 +54,31 @@ fixture `Database overview`
         await browserPage.deleteKeyByName(keyName);
         await deleteStandaloneDatabaseApi(ossStandaloneConfig);
     });
-test('Verify that user can see total and current logical database number of keys (if there are any keys in other logical DBs)', async t => {
-    //Wait for Total Keys number refreshed
-    await t.expect(browserPage.overviewTotalKeys.withText(`${keysAmount + 1}`).exists).ok('Total keys are not changed', { timeout: 10000 });
-    await t.hover(workbenchPage.overviewTotalKeys);
-    //Verify that user can see total number of keys and number of keys in current logical database
-    await t.expect(browserPage.tooltip.visible).ok('Total keys tooltip not displayed');
-    await verifyTooltipContainsText(`${keysAmount + 1}Total Keys`, true);
-    await verifyTooltipContainsText(`db1:${keysAmount}Keys`, true);
-});
-test('Verify that user can see total number of keys and not it current logical database (if there are no any keys in other logical DBs)', async t => {
-    //Open Database
-    await t.click(myRedisDatabasePage.myRedisDBButton);
-    await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName);
-    await t.hover(workbenchPage.overviewTotalKeys);
-    //Verify that user can see only total number of keys
-    await t.expect(browserPage.tooltip.visible).ok('Total keys tooltip not displayed');
-    await verifyTooltipContainsText(`${keysAmount + 1}Total Keys`, true);
-    await verifyTooltipContainsText('db1', false);
-});
 test
-    .before(async t => {
-        await acceptLicenseTerms();
-        await addRedisDatabasePage.addRedisDataBase(cloudDatabaseConfig);
-        //Click for saving
-        await t.click(addRedisDatabasePage.addRedisDatabaseButton);
-        await t.expect(myRedisDatabasePage.dbNameList.withExactText(cloudDatabaseConfig.databaseName).exists).ok('The existence of the database', { timeout: 5000 });
-        await myRedisDatabasePage.clickOnDBByName(cloudDatabaseConfig.databaseName);
+    .meta({ rte: rte.standalone })('Verify that user can see total and current logical database number of keys (if there are any keys in other logical DBs)', async t => {
+        //Wait for Total Keys number refreshed
+        await t.expect(browserPage.overviewTotalKeys.withText(`${keysAmount + 1}`).exists).ok('Total keys are not changed', { timeout: 10000 });
+        await t.hover(workbenchPage.overviewTotalKeys);
+        //Verify that user can see total number of keys and number of keys in current logical database
+        await t.expect(browserPage.tooltip.visible).ok('Total keys tooltip not displayed');
+        await verifyTooltipContainsText(`${keysAmount + 1}Total Keys`, true);
+        await verifyTooltipContainsText(`db1:${keysAmount}Keys`, true);
+    });
+test
+    .meta({ rte: rte.standalone })('Verify that user can see total number of keys and not it current logical database (if there are no any keys in other logical DBs)', async t => {
+        //Open Database
+        await t.click(myRedisDatabasePage.myRedisDBButton);
+        await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName);
+        await t.hover(workbenchPage.overviewTotalKeys);
+        //Verify that user can see only total number of keys
+        await t.expect(browserPage.tooltip.visible).ok('Total keys tooltip not displayed');
+        await verifyTooltipContainsText(`${keysAmount + 1}Total Keys`, true);
+        await verifyTooltipContainsText('db1', false);
+    });
+test
+    .meta({ rte: rte.reCloud })
+    .before(async() => {
+        await acceptLicenseTermsAndAddRECloudDatabase(cloudDatabaseConfig);
     })
     .after(async() => {
         //Delete database

tests/e2e/tests/regression/browser/keys-all-databases.e2e.ts

@@ -22,7 +22,7 @@ const browserPage = new BrowserPage();
 const common = new Common();
 
 let keyName = common.generateWord(10);
-const verifyKeysAdded = async() => {
+const verifyKeysAdded = async(): Promise<void> => {
     keyName = common.generateWord(10);
     //add Hash key
     await browserPage.addHashKey(keyName);
@@ -51,6 +51,7 @@ test
         await verifyKeysAdded();
     });
 test
+    .meta({ rte: rte.reCloud })
     .before(async() => {
         await acceptLicenseTermsAndAddRECloudDatabase(cloudDatabaseConfig);
     })

tests/e2e/tests/regression/database/overview.e2e.ts

@@ -1,24 +1,16 @@
-import { t } from 'testcafe';
 import { rte } from '../../../helpers/constants';
-import {acceptLicenseTerms, deleteDatabase} from '../../../helpers/database';
+import {acceptLicenseTermsAndAddRECloudDatabase, deleteDatabase} from '../../../helpers/database';
 import { BrowserPage, AddRedisDatabasePage, MyRedisDatabasePage, DatabaseOverviewPage } from '../../../pageObjects';
 import { commonUrl, cloudDatabaseConfig } from '../../../helpers/conf';
 
 const browserPage = new BrowserPage();
-const addRedisDatabasePage = new AddRedisDatabasePage();
-const myRedisDatabasePage = new MyRedisDatabasePage();
 const databaseOverviewPage = new DatabaseOverviewPage();
 
 fixture `Overview`
     .meta({ type: 'regression' })
     .page(commonUrl)
     .beforeEach(async() => {
-        await acceptLicenseTerms();
-        await addRedisDatabasePage.addRedisDataBase(cloudDatabaseConfig);
-        //Click for saving
-        await t.click(addRedisDatabasePage.addRedisDatabaseButton);
-        await t.expect(myRedisDatabasePage.dbNameList.withExactText(cloudDatabaseConfig.databaseName).exists).ok('The existence of the database', { timeout: 5000 });
-        await myRedisDatabasePage.clickOnDBByName(cloudDatabaseConfig.databaseName);
+        await acceptLicenseTermsAndAddRECloudDatabase(cloudDatabaseConfig);
     })
     .afterEach(async() => {
         //Delete database

tests/e2e/tests/regression/workbench/workbench-re-cluster.e2e.ts

@@ -18,7 +18,7 @@ const common = new Common();
 
 const commandForSend1 = 'info';
 const commandForSend2 = 'FT._LIST';
-const verifyCommandsInWorkbench = async() => {
+const verifyCommandsInWorkbench = async(): Promise<void> => {
     const multipleCommands = [
         'info',
         'command',
@@ -55,6 +55,7 @@ test
         await verifyCommandsInWorkbench();
     });
 test
+    .meta({ rte: rte.reCloud })
     .before(async() => {
         await acceptLicenseTermsAndAddRECloudDatabase(cloudDatabaseConfig);
     })