Skip to content

Commit eff1700

Browse files
committed
#RI-3371 - User cannot open Workbench
1 parent faefc89 commit eff1700

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

redisinsight/ui/src/components/query-card/QueryCardTooltip/QueryCardTooltip.spec.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react'
22
import { instance, mock } from 'ts-mockito'
3+
import { EMPTY_COMMAND } from 'uiSrc/constants'
34
import { render } from 'uiSrc/utils/test-utils'
45
import QueryCardTooltip, { Props } from './QueryCardTooltip'
56

@@ -9,4 +10,12 @@ describe('QueryCardTooltip', () => {
910
it('should render', () => {
1011
expect(render(<QueryCardTooltip {...instance(mockedProps)} />)).toBeTruthy()
1112
})
13+
14+
it(`should show ${EMPTY_COMMAND} if command=null and summary=`, () => {
15+
const { queryByTestId } = render(
16+
<QueryCardTooltip {...instance(mockedProps)} query={null} summary={null} />
17+
)
18+
19+
expect(queryByTestId('query-card-tooltip-anchor')).toHaveTextContent(EMPTY_COMMAND)
20+
})
1221
})

redisinsight/ui/src/components/query-card/QueryCardTooltip/QueryCardTooltip.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@ import { EuiToolTip } from '@elastic/eui'
33
import { take } from 'lodash'
44
import cx from 'classnames'
55

6-
import { truncateText } from 'uiSrc/utils'
6+
import { Nullable, truncateText } from 'uiSrc/utils'
7+
import { EMPTY_COMMAND } from 'uiSrc/constants'
78
import styles from './styles.module.scss'
89

910
export interface Props {
10-
query: string
11-
summary?: string
11+
query: Nullable<string>
12+
summary?: Nullable<string>
1213
maxLinesNumber?: number
1314
}
1415

@@ -19,10 +20,9 @@ interface IQueryLine {
1920
}
2021

2122
const QueryCardTooltip = (props: Props) => {
22-
const { query = '', maxLinesNumber = 20, summary } = props
23+
const { query = '', maxLinesNumber = 20, summary = '' } = props
2324

24-
let queryLines: IQueryLine[] = query
25-
.split('\n')
25+
let queryLines: IQueryLine[] = (query ?? EMPTY_COMMAND).split('\n')
2626
.map((query: string, i) => ({
2727
value: truncateText(query, 497, '...'),
2828
index: i
@@ -56,7 +56,7 @@ const QueryCardTooltip = (props: Props) => {
5656
content={<>{contentItems}</>}
5757
position="bottom"
5858
>
59-
<span>{summary || query}</span>
59+
<span data-testid="query-card-tooltip-anchor">{summary ?? query ?? EMPTY_COMMAND}</span>
6060
</EuiToolTip>
6161
)
6262
}

0 commit comments

Comments
 (0)