#RI-2937 BE Modify lastDeliveredId

Author: Artem

redisinsight/api/src/modules/browser/constants/browser-tool-commands.ts

@@ -83,6 +83,7 @@ export enum BrowserToolStreamCommands {
   XInfoGroups = 'xinfo groups',
   XPending = 'xpending',
   XGroupCreate = 'xgroup create',
+  XGroupSetId = 'xgroup setid',
 }
 
 export enum BrowserToolTSCommands {

redisinsight/api/src/modules/browser/controllers/stream/consumer-group.controller.ts

@@ -1,16 +1,15 @@
 import {
   Body,
   Controller,
-  Param,
+  Param, Patch,
   Post,
   UsePipes,
   ValidationPipe,
 } from '@nestjs/common';
 import { ApiTags } from '@nestjs/swagger';
 import { ApiRedisInstanceOperation } from 'src/decorators/api-redis-instance-operation.decorator';
 import {
-  ConsumerGroupDto, CreateConsumerGroupsDto,
-  GetStreamEntriesResponse,
+  ConsumerGroupDto, CreateConsumerGroupsDto, UpdateConsumerGroupDto,
 } from 'src/modules/browser/dto/stream.dto';
 import { ConsumerGroupService } from 'src/modules/browser/services/stream/consumer-group.service';
 import { KeyDto } from 'src/modules/browser/dto';
@@ -28,8 +27,9 @@ export class ConsumerGroupController {
     responses: [
       {
         status: 200,
-        description: 'Returns ordered stream entries in defined range.',
-        type: GetStreamEntriesResponse,
+        description: 'Returns stream consumer groups.',
+        type: ConsumerGroupDto,
+        isArray: true,
       },
     ],
   })
@@ -51,4 +51,16 @@ export class ConsumerGroupController {
   ): Promise<void> {
     return this.service.createGroups({ instanceId }, dto);
   }
+
+  @Patch('')
+  @ApiRedisInstanceOperation({
+    description: 'Modify last delivered ID of the Consumer Group',
+    statusCode: 200,
+  })
+  async updateGroup(
+    @Param('dbInstance') instanceId: string,
+      @Body() dto: UpdateConsumerGroupDto,
+  ): Promise<void> {
+    return this.service.updateGroup({ instanceId }, dto);
+  }
 }

redisinsight/api/src/modules/browser/dto/stream.dto.ts

@@ -1,5 +1,5 @@
 import {
-  ApiProperty, ApiPropertyOptional, IntersectionType
+  ApiProperty, ApiPropertyOptional, IntersectionType,
 } from '@nestjs/swagger';
 import {
   ArrayNotEmpty,
@@ -261,3 +261,8 @@ export class CreateConsumerGroupsDto extends KeyDto {
   @Type(() => CreateConsumerGroupDto)
   consumerGroups: CreateConsumerGroupDto[];
 }
+
+export class UpdateConsumerGroupDto extends IntersectionType(
+  KeyDto,
+  CreateConsumerGroupDto,
+) {}

redisinsight/api/src/modules/browser/services/stream/consumer-group.service.ts

@@ -11,7 +11,7 @@ import {
 import { BrowserToolService } from 'src/modules/browser/services/browser-tool/browser-tool.service';
 import { KeyDto } from 'src/modules/browser/dto';
 import ERROR_MESSAGES from 'src/constants/error-messages';
-import { ConsumerGroupDto, CreateConsumerGroupsDto } from 'src/modules/browser/dto/stream.dto';
+import {ConsumerGroupDto, CreateConsumerGroupsDto, UpdateConsumerGroupDto} from 'src/modules/browser/dto/stream.dto';
 
 @Injectable()
 export class ConsumerGroupService {
@@ -152,6 +152,50 @@ export class ConsumerGroupService {
     }
   }
 
+  /**
+   * Updates last delivered id for Consumer Group
+   * @param clientOptions
+   * @param dto
+   */
+  async updateGroup(
+    clientOptions: IFindRedisClientInstanceByOptions,
+    dto: UpdateConsumerGroupDto,
+  ): Promise<void> {
+    try {
+      this.logger.log('Updating consumer group.');
+
+      const exists = await this.browserTool.execCommand(
+        clientOptions,
+        BrowserToolKeysCommands.Exists,
+        [dto.keyName],
+      );
+
+      if (!exists) {
+        return Promise.reject(new NotFoundException(ERROR_MESSAGES.KEY_NOT_EXIST));
+      }
+
+      await this.browserTool.execCommand(
+        clientOptions,
+        BrowserToolStreamCommands.XGroupSetId,
+        [dto.keyName, dto.name, dto.lastDeliveredId],
+      );
+
+      this.logger.log('Consumer group was updated.');
+
+      return undefined;
+    } catch (error) {
+      if (error instanceof NotFoundException) {
+        throw error;
+      }
+
+      if (error?.message.includes(RedisErrorCodes.WrongType)) {
+        throw new BadRequestException(error.message);
+      }
+
+      throw catchAclError(error);
+    }
+  }
+
   /**
    * Converts RESP response from Redis
    * [