Skip to content

Commit f46584e

Browse files
committed
* #RI-4675 - [Regression] User is unable to open 2 applications
* #RI-4676 - [Regression][macOS] App can't be opened after closing from Window-> Close
1 parent 64b6ce2 commit f46584e

File tree

4 files changed

+10
-18
lines changed

4 files changed

+10
-18
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,14 +230,14 @@
230230
"connection-string": "^4.3.2",
231231
"d3": "^7.6.1",
232232
"date-fns": "^2.16.1",
233-
"detect-port": "^1.3.0",
234233
"electron-context-menu": "^3.1.0",
235234
"electron-log": "^4.2.4",
236235
"electron-store": "^8.0.0",
237236
"electron-updater": "^5.0.5",
238237
"file-saver": "^2.0.5",
239238
"formik": "^2.2.9",
240239
"fzstd": "^0.1.0",
240+
"get-port": "^7.0.0",
241241
"gzip-js": "^0.3.2",
242242
"html-entities": "^2.3.2",
243243
"html-react-parser": "^1.2.4",

redisinsight/desktop/src/lib/server/server.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import detectPort from 'detect-port'
21
import log from 'electron-log'
2+
import getPort, { portNumbers } from 'get-port'
33

44
import { wrapErrorMessageSensitiveData } from 'desktopSrc/utils'
55
import { configMain as config } from 'desktopSrc/config'
@@ -22,7 +22,7 @@ export class ElectronWindowAuthStrategy extends AbstractWindowAuthStrategy {
2222
let backendGracefulShutdown: Function
2323
export const launchApiServer = async () => {
2424
try {
25-
const detectPortConst = await detectPort(port)
25+
const detectPortConst = await getPort({ port: portNumbers(port, port + 1_000) })
2626
process.env.API_PORT = detectPortConst?.toString()
2727
log.info('Available port:', detectPortConst)
2828
const { gracefulShutdown: beGracefulShutdown, app: beApp } = await server()

redisinsight/desktop/src/lib/window/window.handlers.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ export const initWindowHandlers = (
6060
})
6161

6262
newWindow.on('closed', () => {
63-
if (newWindow) {
64-
windows.delete(`${newWindow.id}`)
63+
if (newWindow && id) {
64+
windows.delete(id)
6565
// newWindow = null
6666
}
6767

yarn.lock

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3344,11 +3344,6 @@ acorn@^8.0.4, acorn@^8.0.5, acorn@^8.2.4, acorn@^8.4.1, acorn@^8.7.1, acorn@^8.8
33443344
resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.8.2.tgz#1b2f25db02af965399b9776b0c2c391276d37c4a"
33453345
integrity sha512-xjIYgE8HBrkpd/sJqOGNspf8uHG+NOHGOw6a/Urj8taM2EXfdNAH2oFcPeIFfsv3+kz/mJrS5VuMqbNLjCa2vw==
33463346

3347-
address@^1.0.1:
3348-
version "1.2.2"
3349-
resolved "https://registry.yarnpkg.com/address/-/address-1.2.2.tgz#2b5248dac5485a6390532c6a517fda2e3faac89e"
3350-
integrity sha512-4B/qKCfeE/ODUaAUpSwfzazo5x29WD4r3vXiWsB7I2mSDAihwEqKO+g8GELZUQSSAo5e1XTYh3ZVfLyxBc12nA==
3351-
33523347
agent-base@6, agent-base@^6.0.2:
33533348
version "6.0.2"
33543349
resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-6.0.2.tgz#49fff58577cfee3f37176feab4c22e00f86d7f77"
@@ -5609,14 +5604,6 @@ detect-node@^2.0.4:
56095604
resolved "https://registry.yarnpkg.com/detect-node/-/detect-node-2.1.0.tgz#c9c70775a49c3d03bc2c06d9a73be550f978f8b1"
56105605
integrity sha512-T0NIuQpnTvFDATNuHN5roPwSBG83rFsuO+MXXH9/3N1eFbn4wcPjttvjMLEPWJ0RGUYgQE7cGgS3tNxbqCGM7g==
56115606

5612-
detect-port@^1.3.0:
5613-
version "1.5.1"
5614-
resolved "https://registry.yarnpkg.com/detect-port/-/detect-port-1.5.1.tgz#451ca9b6eaf20451acb0799b8ab40dff7718727b"
5615-
integrity sha512-aBzdj76lueB6uUst5iAs7+0H/oOjqI5D16XUWxlWMIMROhcM0rfsNVk93zTngq1dDNpoXRr++Sus7ETAExppAQ==
5616-
dependencies:
5617-
address "^1.0.1"
5618-
debug "4"
5619-
56205607
diff-match-patch@^1.0.4:
56215608
version "1.0.5"
56225609
resolved "https://registry.yarnpkg.com/diff-match-patch/-/diff-match-patch-1.0.5.tgz#abb584d5f10cd1196dfc55aa03701592ae3f7b37"
@@ -7191,6 +7178,11 @@ get-package-type@^0.1.0:
71917178
resolved "https://registry.yarnpkg.com/get-package-type/-/get-package-type-0.1.0.tgz#8de2d803cff44df3bc6c456e6668b36c3926e11a"
71927179
integrity sha512-pjzuKtY64GYfWizNAJ0fr9VqttZkNiK2iS430LtIHzjBEr6bX8Am2zm4sW4Ro5wjWW5cAlRL1qAMTcXbjNAO2Q==
71937180

7181+
get-port@^7.0.0:
7182+
version "7.0.0"
7183+
resolved "https://registry.yarnpkg.com/get-port/-/get-port-7.0.0.tgz#ffcd83da826146529e307a341d7801cae351daff"
7184+
integrity sha512-mDHFgApoQd+azgMdwylJrv2DX47ywGq1i5VFJE7fZ0dttNq3iQMfsU4IvEgBHojA3KqEudyu7Vq+oN8kNaNkWw==
7185+
71947186
get-stdin@^4.0.1:
71957187
version "4.0.1"
71967188
resolved "https://registry.yarnpkg.com/get-stdin/-/get-stdin-4.0.1.tgz#b968c6b0a04384324902e8bf1a5df32579a450fe"

0 commit comments

Comments
 (0)