Skip to content

Commit 55ea2ef

Browse files
committed
Clean up obsolete window_size references and rename misleading variable
- Replace window_size parameter with model_name in examples and test files - Rename effective_window_size to effective_token_limit in API for clarity - Update all references to use the current token-based API instead of the old message-count based window_size approach
1 parent 2f6462b commit 55ea2ef

File tree

6 files changed

+13
-11
lines changed

6 files changed

+13
-11
lines changed

CLAUDE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# CLAUDE.md - Redis Agent Memory Server Project Context
22

3+
## Redis Version
4+
This project uses Redis 8, which is the redis:8 docker image.
5+
Do not use Redis Stack or other earlier versions of Redis.
6+
37
## Frequently Used Commands
48
Get started in a new environment by installing `uv`:
59
```bash

agent_memory_server/api.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -588,12 +588,10 @@ async def memory_prompt(
588588
model_name=params.session.model_name,
589589
context_window_max=params.session.context_window_max,
590590
)
591-
effective_window_size = (
592-
token_limit # We'll handle token-based truncation below
593-
)
591+
effective_token_limit = token_limit
594592
else:
595593
# No model info provided - use all messages without truncation
596-
effective_window_size = None
594+
effective_token_limit = None
597595
working_mem = await working_memory.get_working_memory(
598596
session_id=params.session.session_id,
599597
namespace=params.session.namespace,
@@ -615,19 +613,19 @@ async def memory_prompt(
615613
)
616614
)
617615
# Apply token-based truncation if model info is provided
618-
if effective_window_size is not None:
616+
if effective_token_limit is not None:
619617
# Token-based truncation
620618
if (
621619
_calculate_messages_token_count(working_mem.messages)
622-
> effective_window_size
620+
> effective_token_limit
623621
):
624622
# Keep removing oldest messages until we're under the limit
625623
recent_messages = working_mem.messages[:]
626624
while len(recent_messages) > 1: # Always keep at least 1 message
627625
recent_messages = recent_messages[1:] # Remove oldest
628626
if (
629627
_calculate_messages_token_count(recent_messages)
630-
<= effective_window_size
628+
<= effective_token_limit
631629
):
632630
break
633631
else:

examples/memory_prompt_agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ async def _get_memory_prompt(
123123
session_id=session_id,
124124
query=user_input,
125125
# Optional parameters to control memory retrieval
126-
window_size=30, # Controls working memory messages
126+
model_name="gpt-4o-mini", # Controls token-based truncation
127127
long_term_search={"limit": 30}, # Controls long-term memory limit
128128
user_id=user_id,
129129
)

examples/travel_agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ async def _get_working_memory(self, session_id: str, user_id: str) -> WorkingMem
255255
result = await client.get_working_memory(
256256
session_id=session_id,
257257
namespace=self._get_namespace(user_id),
258-
window_size=15,
258+
model_name="gpt-4o-mini", # Controls token-based truncation
259259
)
260260
return WorkingMemory(**result.model_dump())
261261

manual_oauth_qa/manual_auth0_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def run_comprehensive_test(self):
180180
"session": {
181181
"session_id": "test-session-auth0",
182182
"namespace": "test-auth0",
183-
"window_size": 10,
183+
"model_name": "gpt-4o-mini",
184184
},
185185
},
186186
),

manual_oauth_qa/test_auth0.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def run_comprehensive_test(self):
180180
"session": {
181181
"session_id": "test-session-auth0",
182182
"namespace": "test-auth0",
183-
"window_size": 10,
183+
"model_name": "gpt-4o-mini",
184184
},
185185
},
186186
),

0 commit comments

Comments
 (0)