Skip to content

Commit 5f849dc

Browse files
abrookinsclaude
andcommitted
fix: address PR review feedback
- Remove TDD section comment as requested - Extract SECONDS_PER_DAY constant (86400.0) to global variable - Fix docstring to reference vectorstore adapter instead of RedisVL directly All single/two-letter variable expansion was already completed in previous commits. Tests continue to pass after these cleanup changes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 9db522b commit 5f849dc

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

agent_memory_server/long_term_memory.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1363,16 +1363,15 @@ async def delete_long_term_memories(
13631363
return await adapter.delete_memories(ids)
13641364

13651365

1366-
# =========================
1367-
# Recency scoring and forgetting helpers (pure functions for TDD)
1368-
# =========================
1366+
# Seconds per day constant for time calculations
1367+
SECONDS_PER_DAY = 86400.0
13691368

13701369

13711370
def _days_between(now: datetime, then: datetime | None) -> float:
13721371
if then is None:
13731372
return float("inf")
13741373
delta = now - then
1375-
return max(delta.total_seconds() / 86400.0, 0.0)
1374+
return max(delta.total_seconds() / SECONDS_PER_DAY, 0.0)
13761375

13771376

13781377
def score_recency(
@@ -1586,7 +1585,7 @@ async def forget_long_term_memories(
15861585
) -> dict:
15871586
"""Select and delete long-term memories according to policy.
15881587
1589-
Uses RedisVL via the vectorstore adapter to fetch candidates (empty query + filters),
1588+
Uses the vectorstore adapter to fetch candidates (empty query + filters),
15901589
then applies `select_ids_for_forgetting` locally and deletes via adapter.
15911590
"""
15921591
adapter = await get_vectorstore_adapter()

0 commit comments

Comments
 (0)