Linting

Author: abrookins

.github/workflows/python-tests.yml

@@ -11,21 +11,21 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
-    
+
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
         python-version: '3.12'
         cache: 'pip'
-    
+
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
         pip install -r requirements.txt
         pip install -r requirements-dev.txt
-    
+
     - name: Run tests
       run: |
         pytest --run-api-tests
       env:
-        OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} 
+        OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}

.pre-commit-config.yaml

@@ -14,4 +14,4 @@ repos:
       - id: trailing-whitespace
       - id: end-of-file-fixer
       - id: check-yaml
-      - id: check-added-large-files 
+      - id: check-added-large-files

config.py

@@ -1,6 +1,7 @@
-from pydantic_settings import BaseSettings
 import os
 
+from pydantic_settings import BaseSettings
+
 
 class Settings(BaseSettings):
     redis_url: str = "redis://localhost:6379"
@@ -12,4 +13,5 @@ class Settings(BaseSettings):
     embedding_model: str = "text-embedding-3-small"
     port: int = 8000
 
+
 settings = Settings()

healthcheck.py

@@ -1,7 +1,10 @@
-from fastapi import APIRouter
 import time
+
+from fastapi import APIRouter
+
 from models import HealthCheckResponse
 
+
 router = APIRouter()
 
 

long_term_memory.py

@@ -1,25 +1,23 @@
-from typing import List, Type, Union, Any
+import logging
+
 import nanoid
 from redis.asyncio import Redis
 from redis.commands.search.query import Query
+
 from models import (
     MemoryMessage,
     OpenAIClientWrapper,
-    AnthropicClientWrapper,
     RedisearchResult,
     SearchResults,
-    ModelProvider,
-    get_model_config,
 )
-import logging
-
 from utils import REDIS_INDEX_NAME, Keys
 
+
 logger = logging.getLogger(__name__)
 
 
 async def index_messages(
-    messages: List[MemoryMessage],
+    messages: list[MemoryMessage],
     session_id: str,
     client: OpenAIClientWrapper,  # Only OpenAI supports embeddings currently
     redis_conn: Redis,
@@ -53,7 +51,7 @@ async def index_messages(
             )
 
         logger.info(f"Indexed {len(messages)} messages for session {session_id}")
-        return None
+        return
     except Exception as e:
         logger.error(f"Error indexing messages: {e}")
         raise
@@ -68,7 +66,7 @@ async def search_messages(
     session_id: str,
     client: OpenAIClientWrapper,  # Only OpenAI supports embeddings currently
     redis_conn: Redis,
-    distance_threshold: float | Type[Unset] = Unset,
+    distance_threshold: float | type[Unset] = Unset,
     limit: int = 10,
 ) -> SearchResults:
     """Search for messages using vector similarity"""

main.py

@@ -6,7 +6,8 @@
 from fastapi import FastAPI
 
 import utils
-from models import ModelProvider, MODEL_CONFIGS
+from models import MODEL_CONFIGS, ModelProvider
+
 
 load_dotenv()
 
@@ -16,6 +17,7 @@
 from retrieval import router as retrieval_router
 from utils import ensure_redisearch_index, get_redis_conn
 
+
 # Configure logging
 structlog.configure(
     processors=[

memory.py

@@ -1,29 +1,28 @@
-from fastapi import APIRouter, BackgroundTasks, Depends, HTTPException, Request
-from redis.asyncio import Redis
-from typing import List, Optional
 import json
 import logging
 import time
-import asyncio
 
+from fastapi import APIRouter, BackgroundTasks, Depends, HTTPException
+
+from config import settings
+from long_term_memory import index_messages
 from models import (
+    AckResponse,
+    GetSessionsQuery,
     MemoryMessage,
     MemoryMessagesAndContext,
     MemoryResponse,
-    AckResponse,
-    GetSessionsQuery,
 )
 from reducers import handle_compaction
-from long_term_memory import index_messages
-from utils import Keys, get_model_client, get_redis_conn, get_openai_client
-from config import settings
+from utils import Keys, get_model_client, get_openai_client, get_redis_conn
+
 
 logger = logging.getLogger(__name__)
 
 router = APIRouter()
 
 
-@router.get("/sessions/", response_model=List[str])
+@router.get("/sessions/", response_model=list[str])
 async def get_sessions(
     pagination: GetSessionsQuery = Depends(GetSessionsQuery),
 ):
@@ -39,7 +38,7 @@ async def get_sessions(
     # Check page limit
     if pagination.page > 100:
         raise HTTPException(status_code=400, detail="Page must not exceed 100")
-    
+
     redis = get_redis_conn()
 
     # Calculate start and end indices (0-indexed start, inclusive end)
@@ -67,9 +66,7 @@ async def get_sessions(
 
 
 @router.get("/sessions/{session_id}/memory", response_model=MemoryResponse)
-async def get_memory(
-    session_id: str
-):
+async def get_memory(session_id: str):
     """
     Get memory for a session
 
@@ -146,7 +143,7 @@ async def post_memory(
     session_id: str,
     memory_messages: MemoryMessagesAndContext,
     background_tasks: BackgroundTasks,
-    namespace: Optional[str] = None,
+    namespace: str | None = None,
 ):
     """
     Add messages to a session's memory
@@ -202,7 +199,7 @@ async def post_memory(
             )
 
         # If long-term memory is enabled, index messages.
-        # 
+        #
         # TODO: Add support for custom policies around when to index and/or
         # avoid re-indexing duplicate content.
         if settings.long_term_memory:
@@ -226,7 +223,7 @@ async def post_memory(
 @router.delete("/sessions/{session_id}/memory", response_model=AckResponse)
 async def delete_memory(
     session_id: str,
-    namespace: Optional[str] = None,
+    namespace: str | None = None,
 ):
     """
     Delete a session's memory

models.py

@@ -326,7 +326,8 @@ async def create_embedding(self, query_vec: list[str]) -> np.ndarray:
         embeddings or raise an error if needed
         """
         raise NotImplementedError(
-            "Anthropic does not provide an embedding API. Please use OpenAI for embeddings."
+            "Anthropic does not provide an embedding API. "
+            "Please use OpenAI for embeddings."
         )
 
 

pyproject.toml

@@ -48,4 +48,4 @@ ban-relative-imports = "all"
 # Use double quotes for strings
 quote-style = "double"
 # Use spaces for indentation
-indent-style = "space" 
+indent-style = "space"

pytest.ini

@@ -6,5 +6,5 @@ python_functions = test_*
 filterwarnings =
     ignore::DeprecationWarning
     ignore::PendingDeprecationWarning
-asyncio_mode = auto 
+asyncio_mode = auto
 asyncio_default_fixture_loop_scope = session