ruff

Author: fcenedes

.gitignore

@@ -236,4 +236,4 @@ libs/redis/docs/.Trash*
 TASK_MEMORY.md
 *.code-workspace
 
-augment*.md
+augment*.md

agent_memory_server/cli.py

@@ -119,7 +119,6 @@ def migrate_working_memory(batch_size: int, dry_run: bool):
 
     from agent_memory_server.utils.keys import Keys
     from agent_memory_server.working_memory import (
-        reset_migration_status,
         set_migration_complete,
     )
 
@@ -149,7 +148,7 @@ async def run_migration():
                     pipe.type(key)
                 types = await pipe.execute()
 
-                for key, key_type in zip(keys, types):
+                for key, key_type in zip(keys, types, strict=False):
                     if isinstance(key_type, bytes):
                         key_type = key_type.decode("utf-8")
 
@@ -197,7 +196,7 @@ async def run_migration():
 
             # Parse and prepare migration
             migrations = []  # List of (key, data) tuples
-            for key, string_data in zip(batch_keys, string_data_list):
+            for key, string_data in zip(batch_keys, string_data_list, strict=False):
                 if string_data is None:
                     continue
 
@@ -222,7 +221,9 @@ async def run_migration():
                     migrated += len(migrations)
                 except Exception as e:
                     # If batch fails, try one by one
-                    logger.warning(f"Batch migration failed, retrying individually: {e}")
+                    logger.warning(
+                        f"Batch migration failed, retrying individually: {e}"
+                    )
                     for key, data in migrations:
                         try:
                             await redis.delete(key)
@@ -262,8 +263,7 @@ async def run_migration():
             )
         else:
             click.echo(
-                "\nMigration completed with errors. "
-                "Run again to retry failed keys."
+                "\nMigration completed with errors. " "Run again to retry failed keys."
             )
 
     asyncio.run(run_migration())

agent_memory_server/working_memory.py

@@ -89,7 +89,7 @@ async def check_and_set_migration_status(redis_client: Redis | None = None) -> b
                         # The counter will be managed differently in this mode
                         _remaining_string_keys = -1
                         return False
-                    elif key_type == "ReJSON-RL":
+                    elif key_type == "ReJSON-RL":  # noqa: RET505
                         json_keys_found += 1
 
             if cursor == 0:
@@ -194,7 +194,7 @@ async def _migrate_string_to_json(
         end
         """
         # Pass the JSON string as ARGV[1]
-        migrated_val = await redis_client.eval(lua_script, 1, key, json.dumps(data))
+        await redis_client.eval(lua_script, 1, key, json.dumps(data))
 
         # Preserve TTL if it was set
         # Note: TTL is lost during migration since we deleted the key

tests/benchmarks/test_migration_benchmark.py

@@ -56,6 +56,7 @@ def create_old_format_data(session_id: str, namespace: str) -> dict:
 @pytest.fixture
 async def cleanup_working_memory_keys(async_redis_client):
     """Clean up all working memory keys before and after test."""
+
     async def cleanup():
         cursor = 0
         deleted = 0
@@ -118,7 +119,7 @@ async def test_startup_scan_performance(
         print(f"✅ Created {KEY_COUNT:,} keys in {creation_time:.2f}s")
 
         # Benchmark startup scan (with early exit)
-        print(f"\n📊 Benchmarking startup scan (early exit on first string key)...")
+        print("\n📊 Benchmarking startup scan (early exit on first string key)...")
         reset_migration_status()
 
         start = time.perf_counter()
@@ -251,10 +252,12 @@ async def test_worst_case_single_string_key_at_end(
         await async_redis_client.set(string_key, json.dumps(string_data))
 
         creation_time = time.perf_counter() - start
-        print(f"✅ Created {KEY_COUNT:,} JSON keys + 1 string key in {creation_time:.2f}s")
+        print(
+            f"✅ Created {KEY_COUNT:,} JSON keys + 1 string key in {creation_time:.2f}s"
+        )
 
         # Benchmark startup scan - must scan all keys to find the string one
-        print(f"\n📊 Benchmarking startup scan (worst case - string key at end)...")
+        print("\n📊 Benchmarking startup scan (worst case - string key at end)...")
         reset_migration_status()
 
         start = time.perf_counter()
@@ -297,7 +300,7 @@ async def test_migration_script_performance(
         print(f"✅ Created {KEY_COUNT:,} string keys in {creation_time:.2f}s")
 
         # Benchmark migration (simulating what the CLI does)
-        print(f"\n📊 Benchmarking pipelined migration...")
+        print("\n📊 Benchmarking pipelined migration...")
         migrate_start = time.perf_counter()
 
         # Scan and collect string keys
@@ -313,7 +316,7 @@ async def test_migration_script_performance(
                     pipe.type(key)
                 types = await pipe.execute()
 
-                for key, key_type in zip(keys, types):
+                for key, key_type in zip(keys, types, strict=False):
                     if isinstance(key_type, bytes):
                         key_type = key_type.decode("utf-8")
                     if key_type == "string":
@@ -323,7 +326,9 @@ async def test_migration_script_performance(
                 break
 
         scan_time = time.perf_counter() - migrate_start
-        print(f"  Scan completed in {scan_time:.2f}s ({len(string_keys):,} string keys)")
+        print(
+            f"  Scan completed in {scan_time:.2f}s ({len(string_keys):,} string keys)"
+        )
 
         # Migrate in batches
         migrated = 0
@@ -338,7 +343,7 @@ async def test_migration_script_performance(
 
             # Parse and migrate
             write_pipe = async_redis_client.pipeline()
-            for key, string_data in zip(batch_keys, string_data_list):
+            for key, string_data in zip(batch_keys, string_data_list, strict=False):
                 if string_data is None:
                     continue
                 if isinstance(string_data, bytes):
@@ -352,7 +357,9 @@ async def test_migration_script_performance(
 
             if migrated % 100000 == 0:
                 elapsed = time.perf_counter() - migrate_start
-                print(f"  Migrated {migrated:,} keys ({migrated / elapsed:,.0f} keys/sec)")
+                print(
+                    f"  Migrated {migrated:,} keys ({migrated / elapsed:,.0f} keys/sec)"
+                )
 
         migrate_time = time.perf_counter() - migrate_start
         rate = migrated / migrate_time
@@ -369,4 +376,3 @@ async def test_migration_script_performance(
         if isinstance(key_type, bytes):
             key_type = key_type.decode("utf-8")
         assert key_type == "ReJSON-RL", f"Expected ReJSON-RL, got {key_type}"
-

tests/test_working_memory.py

@@ -436,7 +436,9 @@ async def test_backward_compatibility_string_to_json_migration(
         assert retrieved_again.session_id == session_id
 
     @pytest.mark.asyncio
-    async def test_check_and_set_migration_status_with_no_keys(self, async_redis_client):
+    async def test_check_and_set_migration_status_with_no_keys(
+        self, async_redis_client
+    ):
         """Test migration status check when no working memory keys exist."""
         from agent_memory_server.working_memory import (
             check_and_set_migration_status,

tests/test_working_memory_strategies.py

@@ -1,6 +1,5 @@
 """Tests for working memory strategy integration."""
 
-import json
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest