Simplify vectorstore factory to only support Pydantic ModelConfig objects

Remove dictionary support from create_embeddings() function and update tests
to use proper ModelConfig instances instead of dictionaries. This improves
type safety and consistency across the codebase.

Co-authored-by: Andrew Brookins <[email protected]>

Author: claude[bot]

agent_memory_server/vectorstore_factory.py

@@ -46,15 +46,8 @@ def create_embeddings() -> Embeddings:
         An Embeddings instance
     """
     embedding_config = settings.embedding_model_config
-    if embedding_config:
-        # Handle both dict (for tests with mocked config) and ModelConfig (actual config)
-        provider = (
-            embedding_config.get("provider", "openai") 
-            if hasattr(embedding_config, 'get') 
-            else embedding_config.provider
-        )
-    else:
-        provider = "openai"
+    # Only support ModelConfig objects
+    provider = embedding_config.provider if embedding_config else "openai"
 
     if provider == "openai":
         try:

tests/integration/test_vectorstore_factory_integration.py

@@ -10,6 +10,7 @@
 import pytest
 from langchain_core.embeddings import Embeddings
 
+from agent_memory_server.config import ModelConfig, ModelProvider
 from agent_memory_server.vectorstore_factory import (
     _import_and_call_factory,
     create_embeddings,
@@ -89,8 +90,13 @@ class TestEmbeddingsCreation:
     def test_create_openai_embeddings(self, mock_settings):
         """Test OpenAI embeddings creation."""
 
-        # Configure mock settings
-        mock_settings.embedding_model_config = {"provider": "openai"}
+        # Configure mock settings with ModelConfig object
+        mock_settings.embedding_model_config = ModelConfig(
+            provider=ModelProvider.OPENAI,
+            name="text-embedding-3-small",
+            max_tokens=8191,
+            embedding_dimensions=1536,
+        )
         mock_settings.embedding_model = "text-embedding-3-small"
         mock_settings.openai_api_key = "test-key"
 
@@ -107,7 +113,10 @@ def test_create_openai_embeddings(self, mock_settings):
     def test_create_embeddings_unsupported_provider(self, mock_settings):
         """Test embeddings creation with unsupported provider."""
 
-        mock_settings.embedding_model_config = {"provider": "unsupported"}
+        # Create a mock model config with unsupported provider
+        mock_config = Mock()
+        mock_config.provider = "unsupported"  # Set directly as string, bypassing enum validation
+        mock_settings.embedding_model_config = mock_config
 
         with pytest.raises(ValueError, match="Unsupported embedding provider"):
             create_embeddings()