More client enhancements to tool-based access

Author: abrookins

TASK_MEMORY.md

@@ -40,7 +40,6 @@
     WorkingMemoryResponse,
 )
 
-
 # === Tool Call Type Definitions ===
 
 
@@ -820,7 +819,7 @@ async def search_memory_tool(
                 result = await client.search_memory_tool(**args)
             ```
         """
-        from .filters import Topics, Entities, MemoryType
+        from .filters import Entities, MemoryType, Topics
 
         # Convert simple parameters to filter objects
         topics_filter = Topics(any=topics) if topics else None

agent-memory-client/agent_memory_client/client.py

@@ -2,14 +2,14 @@
 import os
 from typing import Any
 
+import ulid
 from bertopic import BERTopic
 from redis.asyncio.client import Redis
 from redisvl.query.filter import Tag
 from redisvl.query.query import FilterQuery
 from tenacity.asyncio import AsyncRetrying
 from tenacity.stop import stop_after_attempt
 from transformers import AutoModelForTokenClassification, AutoTokenizer, pipeline
-import ulid
 
 from agent_memory_server.config import settings
 from agent_memory_server.llms import (

agent_memory_server/extraction.py

@@ -2,8 +2,8 @@
 import os
 from typing import Any
 
-from mcp.server.fastmcp import FastMCP as _FastMCPBase
 import ulid
+from mcp.server.fastmcp import FastMCP as _FastMCPBase
 
 from agent_memory_server.api import (
     create_long_term_memory as core_create_long_term_memory,

agent_memory_server/mcp.py

@@ -2,8 +2,8 @@
 Simplest possible migrations you could have.
 """
 
-from redis.asyncio import Redis
 import ulid
+from redis.asyncio import Redis
 
 from agent_memory_server.logging import get_logger
 from agent_memory_server.long_term_memory import generate_memory_hash

agent_memory_server/migrations.py

@@ -0,0 +1,162 @@
+# Task Memory
+
+**Created:** 2025-06-13 16:34:19
+**Branch:** feature/separate-client-codebase
+
+## Requirements
+
+Fix the errors generated with the command 'uv run mypy agent_memory_client'
+
+## Development Notes
+
+*Update this section as you work on the task. Include:*
+- *Progress updates*
+- *Key decisions made*
+- *Challenges encountered*
+- *Solutions implemented*
+- *Files modified*
+- *Testing notes*
+
+### Work Log
+
+- [2025-06-13 16:34:19] Task setup completed, TASK_MEMORY.md created
+
+#### [2025-06-13 17:00:00] Completed mypy error fixes and namespace refactoring
+
+**Issues Addressed:**
+1. **Fixed mypy type errors in agent_memory_client:** Added py.typed marker file to indicate type information availability
+2. **Continued namespace refactoring in travel_agent.py:** Enhanced user ID integration into namespaces
+3. **Resolved import and type annotation issues:** Fixed all type-related errors in the travel agent example
+
+**Key Changes Made:**
+
+1. **Added py.typed marker:** Created `agent-memory-client/agent_memory_client/py.typed` to resolve import stub issues
+
+2. **Enhanced TravelAgent class with proper namespace handling:**
+   - Added `_get_namespace(user_id)` helper method for consistent namespace generation
+   - Refactored client management to support multiple users with per-user clients
+   - Updated `get_client()` to maintain separate `MemoryAPIClient` instances per user
+   - Fixed `cleanup()` method to properly close all client connections
+
+3. **Fixed type annotations throughout travel_agent.py:**
+   - Corrected `MemoryType` usage to use `MemoryTypeEnum` directly
+   - Added proper imports for `Namespace` and `MemoryRecordResult` filter types
+   - Updated method signatures to use correct return types (`MemoryRecordResult` vs `MemoryRecord`)
+   - Fixed namespace parameter usage in search methods to use `Namespace(eq=namespace_string)`
+
+4. **Ensured consistent namespace usage:**
+   - All memory operations now explicitly use the `travel_agent:{user_id}` namespace pattern
+   - Working memory operations correctly set namespace in memory objects
+   - Long-term memory search and storage operations use proper namespace filters
+
+**Files Modified:**
+- `agent-memory-client/agent_memory_client/py.typed` (created)
+- `examples/travel_agent.py` (extensively refactored)
+
+**Testing:**
+- ✅ `uv run mypy agent-memory-client/agent_memory_client` - Success: no issues found
+- ✅ `uv run mypy examples/travel_agent.py` - Success: no issues found
+
+**Key Decisions:**
+- Chose to maintain separate client instances per user for better isolation and namespace management
+- Used explicit `Namespace` filter objects rather than relying on default namespace configuration
+- Maintained backward compatibility with existing method signatures while fixing type annotations
+
+#### [2025-06-13 17:20:00] Removed redundant features that memory server already handles
+
+**Issues Addressed:**
+1. **Removed manual summarization:** Eliminated conversation summarization logic since memory server handles this automatically
+2. **Removed manual memory extraction:** Eliminated LLM-based memory extraction since memory server provides automatic extraction
+3. **Removed duplicate checking:** Eliminated manual similar memory checking since memory server handles deduplication
+4. **Removed manual memory retrieval and augmentation:** Simplified to rely on memory server's built-in capabilities
+
+**Key Simplifications:**
+
+1. **Removed summarization infrastructure:**
+   - Deleted `MESSAGE_SUMMARIZATION_THRESHOLD` constant
+   - Removed `_summarize_conversation()` method
+   - Eliminated summarization logic from `_add_message_to_working_memory()`
+   - Removed `summarizer` LLM instance
+
+2. **Removed manual memory management:**
+   - Deleted `Memory` and `Memories` Pydantic models
+   - Removed `MemoryStrategy` enum and related strategy logic
+   - Eliminated `_extract_memories_from_conversation()` method
+   - Removed `_store_long_term_memory()` method
+   - Deleted `_similar_memory_exists()` duplicate checking
+   - Removed `_retrieve_relevant_memories()` and `_augment_query_with_memories()` methods
+
+3. **Simplified class interface:**
+   - Updated `TravelAgent.__init__()` to remove strategy parameter
+   - Simplified `_setup_llms()` to only include main conversation LLM
+   - Streamlined `process_user_input()` to focus on core conversation flow
+   - Updated `_generate_response()` to work with basic user input instead of augmented queries
+
+4. **Cleaned up dependencies:**
+   - Removed unused imports: `Enum`, `BaseModel`, filter classes, memory model classes
+   - Simplified import structure to only include essential components
+   - Removed command-line strategy argument from main function
+
+**Rationale:**
+- Modern memory servers typically provide automatic conversation summarization when needed
+- Memory extraction, deduplication, and semantic retrieval are core memory server features
+- Simplifying the travel agent to focus on conversation flow while delegating memory management to the server
+- Reduces code complexity and maintenance burden while leveraging server capabilities
+
+**Files Modified:**
+- `examples/travel_agent.py` (significantly simplified - removed ~200 lines of redundant code)
+
+**Testing:**
+- ✅ `uv run mypy examples/travel_agent.py` - Success: no issues found  
+- ✅ Travel agent imports and instantiates successfully after simplification
+
+**Key Decisions:**
+- Prioritized simplicity and delegation to memory server over manual memory management
+- Maintained core conversation functionality while removing redundant features
+- Kept namespace management and multi-user support as these are application-specific concerns
+
+#### [2025-06-13 17:30:00] Simplified client management to single client with explicit namespaces
+
+**Issues Addressed:**
+1. **Overcomplicated client management:** Multiple clients per user was unnecessarily complex and resource-intensive
+2. **Inefficient resource usage:** One client per user consumed more memory and connections than needed
+3. **Complex lifecycle management:** Managing multiple client lifecycles was error-prone
+
+**Key Simplifications:**
+
+1. **Replaced per-user clients with single client:**
+   - Changed from `self._memory_clients: dict[str, MemoryAPIClient]` to `self._memory_client: MemoryAPIClient | None`
+   - Simplified `get_client()` method to return single client instance without user parameter
+   - Removed user-specific client initialization and storage logic
+
+2. **Explicit namespace management:**
+   - Removed `default_namespace` from client configuration
+   - Always pass namespace explicitly using `self._get_namespace(user_id)` in all operations
+   - Maintained namespace isolation while using shared client
+
+3. **Simplified cleanup:**
+   - Changed from iterating over multiple clients to single client cleanup
+   - Reduced cleanup complexity and potential for resource leaks
+
+**Benefits:**
+- **Memory efficiency:** Single client instead of multiple per-user clients
+- **Connection pooling:** Better HTTP connection reuse across users
+- **Simpler lifecycle:** One client to initialize and cleanup
+- **Maintained isolation:** User namespaces still properly isolated via explicit namespace parameters
+- **Cleaner code:** Less complexity in client management logic
+
+**Files Modified:**
+- `examples/travel_agent.py` (simplified client management)
+
+**Testing:**
+- ✅ `uv run mypy examples/travel_agent.py` - Success: no issues found
+- ✅ Single-client travel agent imports and instantiates successfully
+
+**Key Decisions:**
+- Prioritized efficiency and simplicity over perceived per-user client isolation
+- Maintained namespace-based user isolation through explicit parameters
+- Leveraged HTTP client connection pooling for better resource utilization
+
+---
+
+*This file serves as your working memory for this task. Keep it updated as you progress through the implementation.*