Skip to content

Commit 39a15e2

Browse files
Apply suggestions from code review
Thank you, @andy-stark-redis! Co-authored-by: andy-stark-redis <[email protected]>
1 parent 3f58075 commit 39a15e2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

content/develop/reference/protocol-spec.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -535,9 +535,9 @@ The first element is a key, followed by the corresponding value, then the next k
535535

536536
### Attributes
537537

538-
The attribute type is exactly like the Map type, but instead of a `%` character as the first byte, the `|` byte is used. Attributes describe a dictionary exactly like the Map type. However the client should not consider such a dictionary part of the reply, but as auxiliary data that is used in order to augment the reply.
538+
The attribute type is exactly like the Map type, but instead of a `%` character as the first byte, the `|` character is used. Attributes describe a dictionary exactly like the Map type. However the client should not consider such a dictionary part of the reply, but as auxiliary data that augments the reply.
539539

540-
For exampl, newer versions of Redis may include the ability to report the popularity of keys for every executed command. The reply to the command `MGET a b` may be the following:
540+
For example, newer versions of Redis may include the ability to report the popularity of keys for every executed command. The reply to the command `MGET a b` may be the following:
541541

542542
|1<CR><LF>
543543
+key-popularity<CR><LF>
@@ -552,7 +552,7 @@ For exampl, newer versions of Redis may include the ability to report the popula
552552
:2039123<CR><LF>
553553
:9543892<CR><LF>
554554

555-
The actual reply to `MGET` was just the two item array `[2039123, 9543892]`. The returned attributes specify the popularity, or frequency of requests, given as floating point numbers ranging from `0.0` to `1.0`, of the keys mentioned in the original command. Note: the actual implementation in Redis may differ.
555+
The actual reply to `MGET` is just the two item array `[2039123, 9543892]`. The returned attributes specify the popularity, or frequency of requests, given as floating point numbers ranging from `0.0` to `1.0`, of the keys mentioned in the original command. Note: the actual implementation in Redis may differ.
556556

557557
When a client reads a reply and encounters an attribute type, it should read the attribute, and continue reading the reply. The attribute reply should be accumulated separately, and the user should have a way to access such attributes. For instance, if we imagine a session in an higher level language, something like this could happen:
558558

@@ -567,7 +567,7 @@ When a client reads a reply and encounters an attribute type, it should read the
567567
{:key-popularity => {:a => 0.1923, :b => 0.0012}}
568568
```
569569

570-
Attributes can appear anywhere before a valid part of the protocol identifying a given type, and will inform only the part of the reply that immediately follows. For example:
570+
Attributes can appear anywhere before a valid part of the protocol identifying a given type, and supply information only about the part of the reply that immediately follows. For example:
571571

572572
*3<CR><LF>
573573
:1<CR><LF>
@@ -577,7 +577,7 @@ Attributes can appear anywhere before a valid part of the protocol identifying a
577577
:3600
578578
:3<CR><LF>
579579

580-
In the above example the third element of the array has associated auxiliary information of `{ttl:3600}`. Note that it's not up to the client library to interpret the attributes, it just needs to be passed to the caller in a sensible way.
580+
In the above example the third element of the array has associated auxiliary information of `{ttl:3600}`. Note that it's not up to the client library to interpret the attributes, but it should pass them to the caller in a sensible way.
581581

582582
<a name="set-reply"></a>
583583

0 commit comments

Comments
 (0)