Skip to content

Commit ce150c1

Browse files
Apply suggestions from code review
Co-authored-by: David Dougherty <[email protected]>
1 parent 84112ac commit ce150c1

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

content/develop/connect/clients/java/jedis.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public class Main {
7373
}
7474
```
7575

76-
When you have connected, you can check the connection by storing and
76+
After you have connected, you can check the connection by storing and
7777
retrieving a simple string value:
7878

7979
```java
@@ -308,7 +308,7 @@ is disconnected.
308308
For production usage, you should use a connection pool to manage
309309
connections rather than opening and closing connections individually.
310310
A connection pool maintains several open connections and reuses them
311-
efficiently. When you open a connection from a pool, the pool allocates you
311+
efficiently. When you open a connection from a pool, the pool allocates
312312
one of its open connections. When you subsequently close the same connection,
313313
it is not actually closed but simply returned to the pool for reuse.
314314
This avoids the overhead of repeated connecting and disconnecting.

content/develop/connect/clients/pools-and-muxing.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ weight: 10
1616
---
1717

1818
Redis example code generally opens a connection, demonstrates
19-
a command or feature and then closes. Real-world code typically
19+
a command or feature, and then closes. Real-world code typically
2020
has short bursts of communication with the server and periods of
2121
inactivity in between. Opening and closing connections
2222
involves some overhead and leads to inefficiency if you do
@@ -43,7 +43,7 @@ of connections and adds them to the pool.
4343
{{< image filename="/images/dev/connect/pool-and-mux/ConnPoolInit.drawio.svg" >}}
4444

4545
Each time you "open" a connection
46-
from the pool, the client actually justs returns one of these existing
46+
from the pool, the client returns one of these existing
4747
connections and notes the fact that it is in use.
4848

4949
{{< image filename="/images/dev/connect/pool-and-mux/ConnPoolInUse.drawio.svg" >}}
@@ -54,8 +54,8 @@ connections without actually closing it.
5454

5555
{{< image filename="/images/dev/connect/pool-and-mux/ConnPoolDiscon.drawio.svg" >}}
5656

57-
If all connections in the pool are in use but the app needs more then
58-
the client can simply open new ones as necessary. In this way, the client
57+
If all connections in the pool are in use but the app needs more, then
58+
the client can simply open new connections as necessary. In this way, the client
5959
eventually finds the right number of connections to satisfy your
6060
app's demands.
6161

@@ -64,14 +64,14 @@ app's demands.
6464
Instead of pooling several connections, a multiplexer keeps a
6565
single connection open and uses it for all traffic between the
6666
client and the server. The "connections" returned to your code are
67-
simply to identify where to send the response data from your commands.
67+
used to identify where to send the response data from your commands.
6868

6969
{{< image filename="/images/dev/connect/pool-and-mux/ConnMux.drawio.svg" >}}
7070

7171
Note that it is not a problem if the multiplexer receives several commands close
7272
together in time. When this happens, the multiplexer can often combine the commands into a
7373
[pipeline]({{< relref "/develop/use/pipelining" >}}), which
74-
improves efficiency even more.
74+
improves efficiency.
7575

7676
Multiplexing offers high efficiency but works transparently without requiring
7777
any special code to enable it in your app. The main disadvantage of multiplexing compared to

content/develop/connect/clients/python/redis-py.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ is disconnected.
237237
For production usage, you should use a connection pool to manage
238238
connections rather than opening and closing connections individually.
239239
A connection pool maintains several open connections and reuses them
240-
efficiently. When you open a connection from a pool, the pool allocates you
240+
efficiently. When you open a connection from a pool, the pool allocates
241241
one of its open connections. When you subsequently close the same connection,
242242
it is not actually closed but simply returned to the pool for reuse.
243243
This avoids the overhead of repeated connecting and disconnecting.

0 commit comments

Comments
 (0)