Skip to content

Commit dbaedd3

Browse files
authored
DEV: local example fixes (#2170)
* DEV: patch up local examples for new cmd TCEs * SITE: refactor some local examples
1 parent f4d41e4 commit dbaedd3

File tree

8 files changed

+45
-2
lines changed

8 files changed

+45
-2
lines changed

local_examples/cmd_exists/node-redis/cmds_generic.js renamed to local_examples/cmds_generic/node-redis/cmds-generic.js

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,25 +54,41 @@ console.log(expireRes2); // 1
5454

5555
const expireRes3 = await client.ttl('mykey');
5656
console.log(expireRes3); // 10
57+
// REMOVE_START
58+
assert.equal(expireRes3, 10);
59+
// REMOVE_END
5760

5861
const expireRes4 = await client.set('mykey', 'Hello World');
5962
console.log(expireRes4); // OK
6063

6164
const expireRes5 = await client.ttl('mykey');
6265
console.log(expireRes5); // -1
66+
// REMOVE_START
67+
assert.equal(expireRes5, -1);
68+
// REMOVE_END
6369

6470
const expireRes6 = await client.expire('mykey', 10, "XX");
6571
console.log(expireRes6); // 0
72+
// REMOVE_START
73+
assert.equal(expireRes6, 0)
74+
// REMOVE_END
6675

6776
const expireRes7 = await client.ttl('mykey');
6877
console.log(expireRes7); // -1
78+
// REMOVE_START
79+
assert.equal(expireRes7, -1);
80+
// REMOVE_END
6981

7082
const expireRes8 = await client.expire('mykey', 10, "NX");
7183
console.log(expireRes8); // 1
84+
// REMOVE_START
85+
assert.equal(expireRes8, 1);
86+
// REMOVE_END
7287

7388
const expireRes9 = await client.ttl('mykey');
7489
console.log(expireRes9); // 10
7590
// REMOVE_START
91+
assert.equal(expireRes9, 10);
7692
await client.del('mykey');
7793
// REMOVE_END
7894
// STEP_END
@@ -87,6 +103,7 @@ console.log(ttlRes2); // 1
87103
const ttlRes3 = await client.ttl('mykey');
88104
console.log(ttlRes3); // 10
89105
// REMOVE_START
106+
assert.equal(ttlRes3, 10);
90107
await client.del('mykey');
91108
// REMOVE_END
92109
// STEP_END
@@ -155,13 +172,20 @@ console.log(scan3Res2); // 1
155172

156173
const scan3Res3 = await client.type('geokey');
157174
console.log(scan3Res3); // zset
175+
// REMOVE_START
176+
console.assert(scan3Res3 === 'zset');
177+
// REMOVE_END
158178

159179
const scan3Res4 = await client.type('zkey');
160180
console.log(scan3Res4); // zset
181+
// REMOVE_START
182+
console.assert(scan3Res4 === 'zset');
183+
// REMOVE_END
161184

162185
const scan3Res5 = await client.scan('0', { TYPE: 'zset' });
163186
console.log(scan3Res5.keys); // ['zkey', 'geokey']
164187
// REMOVE_START
188+
console.assert(scan3Res5.keys.sort().toString() === ['zkey', 'geokey'].sort().toString());
165189
await client.del(['geokey', 'zkey']);
166190
// REMOVE_END
167191
// STEP_END
@@ -172,11 +196,18 @@ console.log(scan4Res1); // 2
172196

173197
const scan4Res2 = await client.hScan('myhash', '0');
174198
console.log(scan4Res2.entries); // [{field: 'a', value: '1'}, {field: 'b', value: '2'}]
199+
// REMOVE_START
200+
assert.deepEqual(scan4Res2.entries, [
201+
{ field: 'a', value: '1' },
202+
{ field: 'b', value: '2' }
203+
]);
204+
// REMOVE_END
175205

176206
const scan4Res3 = await client.hScan('myhash', '0', { COUNT: 10 });
177207
const items = scan4Res3.entries.map((item) => item.field)
178208
console.log(items); // ['a', 'b']
179209
// REMOVE_START
210+
assert.deepEqual(items, ['a', 'b'])
180211
await client.del('myhash');
181212
// REMOVE_END
182213
// STEP_END

local_examples/cmd_exists/redis-py/cmds_generic.py renamed to local_examples/cmds_generic/redis-py/cmds_generic.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
print(res)
133133
# >>> ['foobar', 'foo', 'feelsgood']
134134
# REMOVE_START
135-
assert set(res) == {"foo", "foobar", "feelsgood"}
135+
assert sorted(res) == sorted(["foo", "foobar", "feelsgood"])
136136
r.delete("myset")
137137
# REMOVE_END
138138
# STEP_END
@@ -181,16 +181,22 @@
181181
res = r.type("geokey")
182182
print(res)
183183
# >>> zset
184+
# REMOVE_START
185+
assert res == "zset"
186+
# REMOVE_END
184187

185188
res = r.type("zkey")
186189
print(res)
187190
# >>> zset
191+
# REMOVE_START
192+
assert res == "zset"
193+
# REMOVE_END
188194

189195
cursor, keys = r.scan(cursor=0, _type="zset")
190196
print(keys)
191197
# >>> ['zkey', 'geokey']
192198
# REMOVE_START
193-
assert set(keys) == {"zkey", "geokey"}
199+
assert sorted(keys) == sorted(["zkey", "geokey"])
194200
r.delete("geokey", "zkey")
195201
# REMOVE_END
196202
# STEP_END
@@ -203,12 +209,18 @@
203209
cursor, keys = r.hscan("myhash", 0)
204210
print(keys)
205211
# >>> {'a': '1', 'b': '2'}
212+
# REMOVE_START
213+
assert keys == {'a': '1', 'b': '2'}
214+
# REMOVE_END
206215

207216
cursor, keys = r.hscan("myhash", 0, no_values=True)
208217
print(keys)
209218
# >>> ['a', 'b']
210219
# REMOVE_START
211220
assert keys == ['a', 'b']
221+
# REMOVE_END
222+
223+
# REMOVE_START
212224
r.delete("myhash")
213225
# REMOVE_END
214226
# STEP_END

0 commit comments

Comments
 (0)