Skip to content

RC: Change "Requester CIDR" to "Redis CIDR" in VPC peering docs #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

RC: Change "Requester CIDR" to "Redis CIDR" in VPC peering docs #1280

merged 1 commit into from
Mar 13, 2025

Conversation

@cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Mar 13, 2025

No description provided.

@cmilesb cmilesb added bug Something isn't working rc Redis Cloud docs labels Mar 13, 2025
@cmilesb cmilesb requested review from a team and joniredis March 13, 2025 15:11
@cmilesb cmilesb self-assigned this Mar 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Staging links:
https://redis.io/docs/staging/DOC-4967/operate/rc/security/vpc-peering

dwdougherty
dwdougherty approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cmilesb cmilesb merged commit 3891c94 into main Mar 13, 2025
5 checks passed
@cmilesb cmilesb deleted the DOC-4967 branch March 13, 2025 15:22
@abhayastudios
Copy link
Contributor

abhayastudios commented Mar 16, 2025

@cmilesb I see this change was merged into main, but somehow the latest docs still refer to Requestor VPC? Any idea what the issue might be?

image

@cmilesb
Copy link
Contributor Author

cmilesb commented Mar 17, 2025

@abhayastudios (@joniredis) Latest docs are on the latest branch. Unless there's something urgent (like a release), we generally wait to merge to latest until there's multiple changes that need to go. I'll probably merge to latest once I finish DOC-4983 (removing the Terraform note). If you want to see what's on main right now, you can look at https://redis.io/docs/staging/dev/.

@abhayastudios
Copy link
Contributor

abhayastudios commented Mar 17, 2025

@cmilesb ok makes sense - I wrongly assumed it should be immediately visible if merged into main. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@joniredis joniredis Awaiting requested review from joniredis

Assignees

@cmilesb cmilesb

Labels

bug Something isn't working rc Redis Cloud docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmilesb @abhayastudios @dwdougherty