DOC-4544 added PHP vector query example #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
approved these changes
Apr 17, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just a few things to look at. Otherwise, LGTM. Approving now so you don't get held up.
| generates embeddings from text: | ||
|
|
||
| ```php | ||
| $extractor = pipeline('embeddings', 'Xenova/all-MiniLM-L6-v2'); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be Xenova/all-mpnet-base-v2?
Suggested change
| $extractor = pipeline('embeddings', 'Xenova/all-MiniLM-L6-v2'); | |
| $extractor = pipeline('embeddings', 'Xenova/all-mpnet-base-v2'); |
Contributor
Author
There was a problem hiding this comment.
@dwdougherty Actually, this is the only instance that's right! (It works in the tested PHP code.) I accidentally used the wrong model name in the text by taking it from another example that uses a different model :-( Fixed now, though - thanks for spotting the inconsistency.
Co-authored-by: David Dougherty <[email protected]>
Contributor
Author
|
@dwdougherty Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4544