Skip to content

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Jun 27, 2025

DOC-4638 and DOC-5396

Both changes are mainly to accommodate Lettuce examples: they have long lines and big indents, and also each Lettuce snippet typically needs two examples (async and reactive).

@andy-stark-redis andy-stark-redis requested a review from a team June 27, 2025 10:29
@andy-stark-redis andy-stark-redis self-assigned this Jun 27, 2025
@andy-stark-redis andy-stark-redis added the clients Client library docs label Jun 27, 2025
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test the horizontal scrolling change, but not the layouts/partials/tabbed-clients-example.html change. I'm not sure I understand it. But, since I feel adventurous, I'll approve. :)

@andy-stark-redis
Copy link
Contributor Author

@dwdougherty Thanks! Yeah, sorry - I forgot that I had to remove the markup that demonstrates this (it isn't needed just yet). You just need to add a list of client names in quotes, separated by commas, or anything really, as long as the client name is unambiguously in the string.

@andy-stark-redis andy-stark-redis merged commit d302369 into main Jun 27, 2025
4 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4638-tce-box-improvements branch June 27, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients Client library docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants