Skip to content

DEV: add hash, JSON, and time series to secondary indexing page #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

DEV: add hash, JSON, and time series to secondary indexing page #738

merged 2 commits into from
Oct 9, 2024

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Oct 8, 2024 •
edited by atlassian bot
Loading

@dwdougherty dwdougherty added the dev label Oct 8, 2024
@dwdougherty dwdougherty requested review from a team and LiorKogan October 8, 2024 19:47
@dwdougherty dwdougherty self-assigned this Oct 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Staging links:
https://redis.io/docs/staging/DOC-4205/develop/use/patterns/indexes/

LiorKogan
LiorKogan reviewed Oct 9, 2024
View reviewed changes
LiorKogan
LiorKogan reviewed Oct 9, 2024
View reviewed changes
LiorKogan
LiorKogan reviewed Oct 9, 2024
View reviewed changes
LiorKogan
LiorKogan reviewed Oct 9, 2024
View reviewed changes
@LiorKogan
Copy link
Member

We still have a problem with this page the index on the right side is flat.

andy-stark-redis
andy-stark-redis approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM so far.

@dwdougherty
Copy link
Collaborator Author

We still have a problem with this page the index on the right side is flat.

I assume that by "flat" you mean all left-justified? I think it's always been this way (at least, since I've joined Redis). That said, we can take a look.

@dwdougherty
Copy link
Collaborator Author

Thank you @LiorKogan and @andy-stark-redis for the reviews!

@dwdougherty dwdougherty merged commit 15b16e3 into main Oct 9, 2024
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4205 branch October 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiorKogan LiorKogan LiorKogan left review comments

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

Assignees

@dwdougherty dwdougherty

Labels

dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwdougherty @LiorKogan @andy-stark-redis