reorganize tests

Author: ndyakov

identity/identity_test.go

@@ -9,11 +9,22 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
 	"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
 	"github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential"
-	"github.com/redis-developer/go-redis-entraid/internal/mocks"
 	"github.com/stretchr/testify/mock"
 )
 
-var testJWTToken = mocks.TestJWTToken
+// testJWTToken is a JWT manager for testing
+//
+//	{
+//	 "iss": "test jwt",
+//	 "iat": 1743515011,
+//	 "exp": 1775051011,
+//	 "aud": "www.example.com",
+//	 "sub": "[email protected]",
+//	 "oid": "test"
+//	}
+//
+// key: qwertyuiopasdfghjklzxcvbnm123456
+const testJWTToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJ0ZXN0IGp3dCIsImlhdCI6MTc0MzUxNTAxMSwiZXhwIjoxNzc1MDUxMDExLCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJ0ZXN0QHRlc3QuY29tIiwib2lkIjoidGVzdCJ9.6RG721V2eFlSLsCRmo53kSRRrTZIe1UPdLZCUEvIarU"
 
 type mockAzureCredential struct {
 	mock.Mock

internal/mocks/mocks.go

@@ -0,0 +1,33 @@
+package internal
+
+import "testing"
+
+func TestIsClosedWithNilChannel(t *testing.T) {
+	t.Parallel()
+	var ch chan struct{}
+	if IsClosed(ch) {
+		t.Error("expected nil channel to be open")
+	}
+}
+
+func TestIsClosedWithEmptyChannel(t *testing.T) {
+	t.Parallel()
+	ch := make(chan struct{})
+	if IsClosed(ch) {
+		t.Error("expected empty channel to be open")
+	}
+
+	close(ch)
+	if !IsClosed(ch) {
+		t.Error("expected empty channel to be closed")
+	}
+}
+
+func TestIsClosedWithClosedChannel(t *testing.T) {
+	t.Parallel()
+	ch := make(chan struct{})
+	close(ch)
+	if !IsClosed(ch) {
+		t.Error("expected closed channel to be closed")
+	}
+}

internal/utils_test.go

@@ -1,18 +1,148 @@
 package manager
 
 import (
+	"net"
+	"os"
+	"time"
+
 	"github.com/redis-developer/go-redis-entraid/internal"
-	"github.com/redis-developer/go-redis-entraid/internal/mocks"
+	"github.com/redis-developer/go-redis-entraid/shared"
+	"github.com/redis-developer/go-redis-entraid/token"
+	"github.com/stretchr/testify/mock"
 )
 
-type mockIdentityProviderResponseParser = mocks.IdentityProviderResponseParser
-type mockIdentityProvider = mocks.IdentityProvider
-type mockTokenListener = mocks.TokenListener
+// testJWTToken is a JWT manager for testing
+//
+//	{
+//	 "iss": "test jwt",
+//	 "iat": 1743515011,
+//	 "exp": 1775051011,
+//	 "aud": "www.example.com",
+//	 "sub": "[email protected]",
+//	 "oid": "test"
+//	}
+//
+// key: qwertyuiopasdfghjklzxcvbnm123456
+const testJWTToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJ0ZXN0IGp3dCIsImlhdCI6MTc0MzUxNTAxMSwiZXhwIjoxNzc1MDUxMDExLCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJ0ZXN0QHRlc3QuY29tIiwib2lkIjoidGVzdCJ9.6RG721V2eFlSLsCRmo53kSRRrTZIe1UPdLZCUEvIarU"
+
+// testJWTExpiredToken is an expired JWT manager for testing
+//
+// {
+// "iss": "test jwt",
+// "iat": 1617795148,
+// "exp": 1617795148,
+// "aud": "www.example.com",
+// "sub": "[email protected]",
+// "oid": "test"
+// }
+//
+// key: qwertyuiopasdfghjklzxcvbnm123456
+const testJWTExpiredToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJ0ZXN0IGp3dCIsImlhdCI6MTYxNzc5NTE0OCwiZXhwIjoxNjE3Nzk1MTQ4LCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJ0ZXN0QHRlc3QuY29tIiwib2lkIjoidGVzdCJ9.IbGPhHRiPYcpUDrhAPf4h3gH1XXBOu560NYT59rUMzc"
+
+// testJWTWithZeroExpiryToken is a JWT manager with zero expiry for testing
+//
+// {
+// "iss": "test jwt",
+// "iat": 1744025944,
+// "exp": null,
+// "aud": "www.example.com",
+// "sub": "[email protected]",
+// "oid": "test"
+// }
+// key: qwertyuiopasdfghjklzxcvbnm123456
+const testJWTWithZeroExpiryToken = "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJ0ZXN0IGp3dCIsImlhdCI6MTc0NDAyNTk0NCwiZXhwIjpudWxsLCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJ0ZXN0QHRlc3QuY29tIiwib2lkIjoidGVzdCJ9.bLSANIzawE5Y6rgspvvUaRhkBq6Y4E0ggjXlmHRn8ew"
+
+var testTokenValid = token.New(
+	"test",
+	"password",
+	"test",
+	time.Now().Add(time.Hour),
+	time.Now(),
+	int64(time.Hour),
+)
+
+type mockIdentityProviderResponseParser struct {
+	// Mock implementation of the IdentityProviderResponseParser interface
+	mock.Mock
+}
+
+func (m *mockIdentityProviderResponseParser) ParseResponse(response shared.IdentityProviderResponse) (*token.Token, error) {
+	args := m.Called(response)
+	if args.Get(0) == nil {
+		return nil, args.Error(1)
+	}
+	return args.Get(0).(*token.Token), args.Error(1)
+}
+
+type mockIdentityProvider struct {
+	// Mock implementation of the mockIdentityProvider interface
+	// Add any necessary fields or methods for the mock identity provider here
+	mock.Mock
+}
+
+func (m *mockIdentityProvider) RequestToken() (shared.IdentityProviderResponse, error) {
+	args := m.Called()
+	if args.Get(0) == nil {
+		return nil, args.Error(1)
+	}
+	return args.Get(0).(shared.IdentityProviderResponse), args.Error(1)
+}
+
+func newMockError(retriable bool) error {
+	if retriable {
+		return &mockError{
+			isTimeout:   true,
+			isTemporary: true,
+			error:       os.ErrDeadlineExceeded,
+		}
+	} else {
+		return &mockError{
+			isTimeout:   false,
+			isTemporary: false,
+			error:       os.ErrInvalid,
+		}
+	}
+}
+
+type mockError struct {
+	// Mock implementation of the network error
+	error
+	isTimeout   bool
+	isTemporary bool
+}
+
+func (m *mockError) Error() string {
+	return "this is mock error"
+}
+
+func (m *mockError) Timeout() bool {
+	return m.isTimeout
+}
+func (m *mockError) Temporary() bool {
+	return m.isTemporary
+}
+func (m *mockError) Unwrap() error {
+	return m.error
+}
+
+func (m *mockError) Is(err error) bool {
+	return m.error == err
+}
+
+var _ net.Error = (*mockError)(nil)
+
+type mockTokenListener struct {
+	// Mock implementation of the TokenManagerListener interface
+	mock.Mock
+	Id int32
+}
+
+func (m *mockTokenListener) OnTokenNext(token *token.Token) {
+	_ = m.Called(token)
+}
 
-var newMockError = mocks.NewError
-var testTokenValid = mocks.TestTokenValid
-var testJWTToken = mocks.TestJWTToken
-var testJWTExpiredToken = mocks.TestJWTExpiredToken
-var testJWTWithZeroExpiryToken = mocks.TestJWTWithZeroExpiryToken
+func (m *mockTokenListener) OnTokenError(err error) {
+	_ = m.Called(err)
+}
 
 type authResult = internal.IDPResp