better logs

Author: ndyakov

maintnotifications/e2e/notiftracker_test.go

@@ -378,18 +378,27 @@ func (da *DiagnosticsAnalysis) Analyze() {
 }
 
 func (a *DiagnosticsAnalysis) Print(t *testing.T) {
-	t.Logf("Diagnostics Analysis results for %d events and %d connections:", len(a.diagnosticsLog), len(a.connIds))
-	t.Logf("Connections: %v", a.connIds)
-	t.Logf("Relaxed Timeout Count: %d", a.RelaxedTimeoutCount)
-	t.Logf("Unrelaxed Timeout Count: %d", a.UnrelaxedTimeoutCount)
-	t.Logf("Notification Processing Errors: %d", a.NotificationProcessingErrors)
-	t.Logf("Connection Count: %d", a.ConnectionCount)
-	t.Logf("Moving Count: %d", a.MovingCount)
-	t.Logf("Migrating Count: %d", a.MigratingCount)
-	t.Logf("Migrated Count: %d", a.MigratedCount)
-	t.Logf("Failing Over Count: %d", a.FailingOverCount)
-	t.Logf("Failed Over Count: %d", a.FailedOverCount)
-	t.Logf("Unexpected Notification Count: %d", a.UnexpectedNotificationCount)
-	t.Logf("Total Notifications: %d", a.TotalNotifications)
+	t.Logf("Notification Analysis results for %d events and %d connections:", len(a.diagnosticsLog), len(a.connIds))
+	t.Logf("-------------")
+	t.Logf("-Timeout Analysis based on type of notification-")
+	t.Logf("Note: MIGRATED and FAILED_OVER notifications are not tracked by the hook, so they are not included in the relaxed/unrelaxed count")
+	t.Logf("Note: The hook only tracks timeouts that occur after the notification is processed, so timeouts that occur during processing are not included")
+	t.Logf("-------------")
+	t.Logf(" - Relaxed Timeout Count: %d", a.RelaxedTimeoutCount)
+	t.Logf(" - Unrelaxed Timeout Count: %d", a.UnrelaxedTimeoutCount)
+	t.Logf("-------------")
+	t.Logf("-Notification Analysis-")
+	t.Logf("-------------")
+	t.Logf(" - MOVING: %d", a.MovingCount)
+	t.Logf(" - MIGRATING: %d", a.MigratingCount)
+	t.Logf(" - MIGRATED: %d", a.MigratedCount)
+	t.Logf(" - FAILING_OVER: %d", a.FailingOverCount)
+	t.Logf(" - FAILED_OVER: %d", a.FailedOverCount)
+	t.Logf(" - Unexpected: %d", a.UnexpectedNotificationCount)
+	t.Logf("-------------")
+	t.Logf(" - Total Notifications: %d", a.TotalNotifications)
+	t.Logf(" - Notification Processing Errors: %d", a.NotificationProcessingErrors)
+	t.Logf(" - Connection Count: %d", a.ConnectionCount)
+	t.Logf("-------------")
 	t.Logf("Diagnostics Analysis completed successfully")
 }

maintnotifications/e2e/scenario_endpoint_types_test.go

@@ -283,7 +283,7 @@ func TestEndpointTypesPushNotifications(t *testing.T) {
 			p("Bind action completed for %s: %s", endpointTest.name, bindStatus.Status)
 
 			// Continue traffic for analysis
-			time.Sleep(5 * time.Second)
+			time.Sleep(30 * time.Second)
 			commandsRunner.Stop()
 
 			// Analyze results for this endpoint type