print output if failed

Author: ndyakov

maintnotifications/e2e/scenario_endpoint_types_test.go

@@ -66,15 +66,13 @@ func TestEndpointTypesPushNotifications(t *testing.T) {
 		t.Fatalf("[ERROR] Failed to create fault injector: %v", err)
 	}
 
-
 	// Create client factory from configuration
 	factory, err := CreateTestClientFactory("standalone")
 	if err != nil {
 		t.Skipf("Enterprise cluster not available, skipping endpoint types test: %v", err)
 	}
 	endpointConfig := factory.GetConfig()
 
-
 	defer func() {
 		if dump {
 			p("Pool stats:")
@@ -207,7 +205,7 @@ func TestEndpointTypesPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("[FI] Failover action failed for %s: %v", endpointTest.name, err)
 			}
-			p("[FI] Failover action completed for %s: %+v", endpointTest.name, status.Status)
+			p("[FI] Failover action completed for %s: %s %s", endpointTest.name, status.Status, actionOutputIfFailed(status))
 
 			// Test migration with this endpoint type
 			p("Testing migration with %s endpoint type...", endpointTest.name)
@@ -229,7 +227,7 @@ func TestEndpointTypesPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("[FI] Migrate action failed for %s: %v", endpointTest.name, err)
 			}
-			p("[FI] Migrate action completed for %s: %+v", endpointTest.name, status.Status)
+			p("[FI] Migrate action completed for %s: %s %s", endpointTest.name, status.Status, actionOutputIfFailed(status))
 
 			// Wait for MIGRATING notification
 			match, found = logCollector.MatchOrWaitForLogMatchFunc(func(s string) bool {
@@ -323,7 +321,7 @@ func TestEndpointTypesPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("Bind action failed for %s: %v", endpointTest.name, err)
 			}
-			p("Bind action completed for %s: %+v", endpointTest.name, bindStatus.Status)
+			p("Bind action completed for %s: %s %s", endpointTest.name, bindStatus.Status, actionOutputIfFailed(bindStatus))
 
 			// Continue traffic for analysis
 			time.Sleep(30 * time.Second)

maintnotifications/e2e/scenario_push_notifications_test.go

@@ -166,7 +166,7 @@ func TestPushNotifications(t *testing.T) {
 	if err != nil {
 		ef("[FI] Failover action failed: %v", err)
 	}
-	p("[FI] Failover action completed: %+v", status.Status)
+	p("[FI] Failover action completed: %v %s", status.Status, actionOutputIfFailed(status))
 
 	p("FAILING_OVER / FAILED_OVER notifications test completed successfully")
 
@@ -203,7 +203,7 @@ func TestPushNotifications(t *testing.T) {
 	if err != nil {
 		ef("[FI] Migrate action failed: %v", err)
 	}
-	p("[FI] Migrate action completed: %+v", status.Status)
+	p("[FI] Migrate action completed: %s %s", status.Status, actionOutputIfFailed(status))
 
 	go func() {
 		p("Waiting for MIGRATED notification on conn %d with seqID %d...", connIDToObserve, seqIDToObserve+1)
@@ -382,7 +382,7 @@ func TestPushNotifications(t *testing.T) {
 		ef("Bind action failed: %v", err)
 	}
 
-	p("Bind action completed: %+v", bindStatus.Status)
+	p("Bind action completed: %s %s", bindStatus.Status, actionOutputIfFailed(bindStatus))
 
 	p("MOVING notification test completed successfully")
 

maintnotifications/e2e/scenario_stress_test.go

@@ -199,10 +199,10 @@ func TestStressPushNotifications(t *testing.T) {
 			}
 
 			actionMutex.Lock()
-			actionResults = append(actionResults, fmt.Sprintf("%s: %+v", actionName, status.Status))
+			actionResults = append(actionResults, fmt.Sprintf("%s: %s %s", actionName, status.Status, actionOutputIfFailed(status)))
 			actionMutex.Unlock()
 
-			p("[FI] %s action completed: %+v", actionName, status.Status)
+			p("[FI] %s action completed: %s %s", actionName, status.Status, actionOutputIfFailed(status))
 		}(action.name, action.action, action.delay)
 	}
 

maintnotifications/e2e/scenario_timeout_configs_test.go

@@ -209,7 +209,7 @@ func TestTimeoutConfigurationsPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("[FI] Failover action failed for %s: %v", timeoutTest.name, err)
 			}
-			p("[FI] Failover action completed for %s: %+v", timeoutTest.name, status.Status)
+			p("[FI] Failover action completed for %s: %s %s", timeoutTest.name, status.Status, actionOutputIfFailed(status))
 
 			// Continue traffic to observe timeout behavior
 			p("Continuing traffic for %v to observe timeout behavior...", timeoutTest.relaxedTimeout*2)
@@ -236,7 +236,7 @@ func TestTimeoutConfigurationsPushNotifications(t *testing.T) {
 				ef("[FI] Migrate action failed for %s: %v", timeoutTest.name, err)
 			}
 
-			p("[FI] Migrate action completed for %s: %+v", timeoutTest.name, status.Status)
+			p("[FI] Migrate action completed for %s: %s %s", timeoutTest.name, status.Status, actionOutputIfFailed(status))
 
 			// Wait for MIGRATING notification
 			match, found = logCollector.MatchOrWaitForLogMatchFunc(func(s string) bool {
@@ -265,7 +265,7 @@ func TestTimeoutConfigurationsPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("[FI] Bind action failed for %s: %v", timeoutTest.name, err)
 			}
-			p("[FI] Bind action completed for %s: %+v", timeoutTest.name, status.Status)
+			p("[FI] Bind action completed for %s: %s %s", timeoutTest.name, status.Status, actionOutputIfFailed(status))
 
 			// waiting for moving notification
 			match, found = logCollector.MatchOrWaitForLogMatchFunc(func(s string) bool {

maintnotifications/e2e/scenario_tls_configs_test.go

@@ -199,7 +199,7 @@ func ТestTLSConfigurationsPushNotifications(t *testing.T) {
 			if err != nil {
 				ef("[FI] Migrate action failed for %s: %v", tlsTest.name, err)
 			}
-			p("[FI] Migrate action completed for %s: %+v", tlsTest.name, status)
+			p("[FI] Migrate action completed for %s: %s %s", tlsTest.name, status.Status, actionOutputIfFailed(status))
 
 			// Continue traffic for a bit to observe TLS behavior
 			time.Sleep(5 * time.Second)

maintnotifications/e2e/utils_test.go

@@ -61,3 +61,16 @@ func printLog(group string, isError bool, format string, args ...interface{}) {
 	args = append([]interface{}{filename, line, ts, group}, args...)
 	fmt.Printf(finalFormat, args...)
 }
+
+func actionOutputIfFailed(status *ActionStatusResponse) string {
+	if status.Status != StatusFailed {
+		return ""
+	}
+	if status.Error != nil {
+		return fmt.Sprintf("%v", status.Error)
+	}
+	if status.Output == nil {
+		return ""
+	}
+	return fmt.Sprintf("%+v", status.Output)
+}