Skip to content

Commit 1de0d2a

Browse files
committed
chore: remove outdated comment
1 parent d7dd9a7 commit 1de0d2a

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

commands.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1743,8 +1743,6 @@ type XAddArgs struct {
17431743
Values interface{}
17441744
}
17451745

1746-
// XAdd a.Limit has a bug, please confirm it and use it.
1747-
// issue: https://github.com/redis/redis/issues/9046
17481746
func (c cmdable) XAdd(ctx context.Context, a *XAddArgs) *StringCmd {
17491747
args := make([]interface{}, 0, 11)
17501748
args = append(args, "xadd", a.Stream)
@@ -2081,22 +2079,14 @@ func (c cmdable) XTrimMaxLen(ctx context.Context, key string, maxLen int64) *Int
20812079
return c.xTrim(ctx, key, "maxlen", false, maxLen, 0)
20822080
}
20832081

2084-
// XTrimMaxLenApprox LIMIT has a bug, please confirm it and use it.
2085-
// issue: https://github.com/redis/redis/issues/9046
2086-
// cmd: XTRIM key MAXLEN ~ maxLen LIMIT limit
20872082
func (c cmdable) XTrimMaxLenApprox(ctx context.Context, key string, maxLen, limit int64) *IntCmd {
20882083
return c.xTrim(ctx, key, "maxlen", true, maxLen, limit)
20892084
}
20902085

2091-
// XTrimMinID No `~` rules are used, `limit` cannot be used.
2092-
// cmd: XTRIM key MINID minID
20932086
func (c cmdable) XTrimMinID(ctx context.Context, key string, minID string) *IntCmd {
20942087
return c.xTrim(ctx, key, "minid", false, minID, 0)
20952088
}
20962089

2097-
// XTrimMinIDApprox LIMIT has a bug, please confirm it and use it.
2098-
// issue: https://github.com/redis/redis/issues/9046
2099-
// cmd: XTRIM key MINID ~ minID LIMIT limit
21002090
func (c cmdable) XTrimMinIDApprox(ctx context.Context, key string, minID string, limit int64) *IntCmd {
21012091
return c.xTrim(ctx, key, "minid", true, minID, limit)
21022092
}

commands_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4381,9 +4381,6 @@ var _ = Describe("Commands", func() {
43814381
Expect(id).To(Equal("3-0"))
43824382
})
43834383

4384-
// TODO XTrimMaxLenApprox/XTrimMinIDApprox There is a bug in the limit parameter.
4385-
// TODO Don't test it for now.
4386-
// TODO link: https://github.com/redis/redis/issues/9046
43874384
It("should XTrimMaxLen", func() {
43884385
n, err := client.XTrimMaxLen(ctx, "stream", 0).Result()
43894386
Expect(err).NotTo(HaveOccurred())
@@ -4425,9 +4422,6 @@ var _ = Describe("Commands", func() {
44254422
}))
44264423
})
44274424

4428-
// TODO XAdd There is a bug in the limit parameter.
4429-
// TODO Don't test it for now.
4430-
// TODO link: https://github.com/redis/redis/issues/9046
44314425
It("should XAdd with MaxLen", func() {
44324426
id, err := client.XAdd(ctx, &redis.XAddArgs{
44334427
Stream: "stream",

0 commit comments

Comments
 (0)