Address comments

Signed-off-by: Jason Parraga <[email protected]>

Author: Sovietaced

extra/redisotel/config.go

@@ -65,7 +65,6 @@ func newConfig(opts ...baseOption) *config {
 		mp:            otel.GetMeterProvider(),
 		dbStmtEnabled: true,
 		callerEnabled: true,
-		filter:        defaultCommandFilter,
 	}
 
 	for _, opt := range opts {
@@ -137,7 +136,7 @@ func WithCommandFilter(filter func(cmd redis.Cmder) bool) TracingOption {
 	})
 }
 
-func defaultCommandFilter(cmd redis.Cmder) bool {
+func BasicCommandFilter(cmd redis.Cmder) bool {
 	if strings.ToLower(cmd.Name()) == "auth" {
 		return true
 	}

extra/redisotel/tracing_test.go

@@ -151,11 +151,12 @@ func TestWithCommandFilter(t *testing.T) {
 		}
 	})
 
-	t.Run("auth command filtered by default", func(t *testing.T) {
+	t.Run("auth command filtered with basic command filter", func(t *testing.T) {
 		provider := sdktrace.NewTracerProvider()
 		hook := newTracingHook(
 			"",
 			WithTracerProvider(provider),
+			WithCommandFilter(BasicCommandFilter),
 		)
 		ctx, span := provider.Tracer("redis-test").Start(context.TODO(), "redis-test")
 		cmd := redis.NewCmd(ctx, "auth", "test-password")
@@ -175,11 +176,12 @@ func TestWithCommandFilter(t *testing.T) {
 		}
 	})
 
-	t.Run("hello command filtered by default when sensitive", func(t *testing.T) {
+	t.Run("hello command filtered with basic command filter when sensitive", func(t *testing.T) {
 		provider := sdktrace.NewTracerProvider()
 		hook := newTracingHook(
 			"",
 			WithTracerProvider(provider),
+			WithCommandFilter(BasicCommandFilter),
 		)
 		ctx, span := provider.Tracer("redis-test").Start(context.TODO(), "redis-test")
 		cmd := redis.NewCmd(ctx, "hello", 3, "AUTH", "test-user", "test-password")
@@ -199,11 +201,12 @@ func TestWithCommandFilter(t *testing.T) {
 		}
 	})
 
-	t.Run("hello command not filtered by default when not sensitive", func(t *testing.T) {
+	t.Run("hello command not filtered with basic command filter when not sensitive", func(t *testing.T) {
 		provider := sdktrace.NewTracerProvider()
 		hook := newTracingHook(
 			"",
 			WithTracerProvider(provider),
+			WithCommandFilter(BasicCommandFilter),
 		)
 		ctx, span := provider.Tracer("redis-test").Start(context.TODO(), "redis-test")
 		cmd := redis.NewCmd(ctx, "hello", 3)