Skip to content

Commit 2fd5f48

Browse files
authored
Merge branch 'master' into suever/fix-loopback-origin-check
2 parents fa6b740 + fafec3f commit 2fd5f48

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+450
-130
lines changed

.github/actions/run-tests/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ runs:
2525
2626
# Mapping of redis version to redis testing containers
2727
declare -A redis_version_mapping=(
28-
["8.2.x"]="8.2"
28+
["8.2.x"]="8.2.1-pre"
2929
["8.0.x"]="8.0.2"
3030
["7.4.x"]="rs-7.4.0-v5"
3131
["7.2.x"]="rs-7.2.0-v17"

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
go-version: ${{ matrix.go-version }}
3333

3434
- name: Checkout code
35-
uses: actions/checkout@v4
35+
uses: actions/checkout@v5
3636

3737
- name: Setup Test environment
3838
env:
@@ -44,7 +44,7 @@ jobs:
4444
4545
# Mapping of redis version to redis testing containers
4646
declare -A redis_version_mapping=(
47-
["8.2.x"]="8.2"
47+
["8.2.x"]="8.2.1-pre"
4848
["8.0.x"]="8.0.2"
4949
["7.4.x"]="rs-7.4.0-v5"
5050
)
@@ -84,7 +84,7 @@ jobs:
8484

8585
steps:
8686
- name: Checkout code
87-
uses: actions/checkout@v4
87+
uses: actions/checkout@v5
8888

8989
- name: Run tests
9090
uses: ./.github/actions/run-tests

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535

3636
steps:
3737
- name: Checkout repository
38-
uses: actions/checkout@v4
38+
uses: actions/checkout@v5
3939

4040
# Initializes the CodeQL tools for scanning.
4141
- name: Initialize CodeQL

.github/workflows/doctests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
go-version: ${{ matrix.go-version }}
3737

3838
- name: Checkout code
39-
uses: actions/checkout@v4
39+
uses: actions/checkout@v5
4040

4141
- name: Test doc examples
4242
working-directory: ./doctests

.github/workflows/golangci-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
name: lint
2121
runs-on: ubuntu-latest
2222
steps:
23-
- uses: actions/checkout@v4
23+
- uses: actions/checkout@v5
2424
- name: golangci-lint
2525
uses: golangci/[email protected]
2626
with:

.github/workflows/spellcheck.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
runs-on: ubuntu-latest
77
steps:
88
- name: Checkout
9-
uses: actions/checkout@v4
9+
uses: actions/checkout@v5
1010
- name: Check Spelling
1111
uses: rojopolis/[email protected]
1212
with:

.github/workflows/stale-issues.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ jobs:
2323
uses: actions/stale@v9
2424
with:
2525
repo-token: ${{ secrets.GITHUB_TOKEN }}
26-
debug-only: true
2726

2827
# Default stale policy
2928
days-before-stale: ${{ env.DAYS_BEFORE_STALE }}
@@ -68,7 +67,6 @@ jobs:
6867
uses: actions/stale@v9
6968
with:
7069
repo-token: ${{ secrets.GITHUB_TOKEN }}
71-
debug-only: true
7270

7371
# Accelerated timeline for needs-information
7472
days-before-stale: ${{ env.NEEDS_INFO_DAYS_BEFORE_STALE }}
@@ -94,4 +92,4 @@ jobs:
9492
days-before-pr-close: -1
9593

9694
# Remove stale label when issue becomes active again
97-
remove-stale-when-updated: true
95+
remove-stale-when-updated: true

.github/workflows/test-redis-enterprise.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020

2121
steps:
2222
- name: Checkout code
23-
uses: actions/checkout@v4
23+
uses: actions/checkout@v5
2424

2525
- name: Clone Redis EE docker repository
26-
uses: actions/checkout@v4
26+
uses: actions/checkout@v5
2727
with:
2828
repository: RedisLabs/redis-ee-docker
2929
path: redis-ee

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Here's how to get started with your code contribution:
3737
> Note: this clones and builds the docker containers specified in `docker-compose.yml`, to understand more about
3838
> the infrastructure that will be started you can check the `docker-compose.yml`. You also have the possiblity
3939
> to specify the redis image that will be pulled with the env variable `CLIENT_LIBS_TEST_IMAGE`.
40-
> By default the docker image that will be pulled and started is `redislabs/client-libs-test:rs-7.4.0-v2`.
40+
> By default the docker image that will be pulled and started is `redislabs/client-libs-test:8.2.1-pre`.
4141
> If you want to test with newer Redis version, using a newer version of `redislabs/client-libs-test` should work out of the box.
4242
4343
4. While developing, make sure the tests pass by running `make test` (if you have the docker containers running, `make test.ci` may be sufficient).

Makefile

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
GO_MOD_DIRS := $(shell find . -type f -name 'go.mod' -exec dirname {} \; | sort)
2+
REDIS_VERSION ?= 8.2
3+
RE_CLUSTER ?= false
4+
RCE_DOCKER ?= true
5+
CLIENT_LIBS_TEST_IMAGE ?= redislabs/client-libs-test:8.2.1-pre
26

37
docker.start:
8+
export RE_CLUSTER=$(RE_CLUSTER) && \
9+
export RCE_DOCKER=$(RCE_DOCKER) && \
10+
export REDIS_VERSION=$(REDIS_VERSION) && \
11+
export CLIENT_LIBS_TEST_IMAGE=$(CLIENT_LIBS_TEST_IMAGE) && \
412
docker compose --profile all up -d --quiet-pull
513

614
docker.stop:
@@ -27,6 +35,9 @@ test.ci:
2735
set -e; for dir in $(GO_MOD_DIRS); do \
2836
echo "go test in $${dir}"; \
2937
(cd "$${dir}" && \
38+
export RE_CLUSTER=$(RE_CLUSTER) && \
39+
export RCE_DOCKER=$(RCE_DOCKER) && \
40+
export REDIS_VERSION=$(REDIS_VERSION) && \
3041
go mod tidy -compat=1.18 && \
3142
go vet && \
3243
go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -skip Example); \
@@ -38,6 +49,9 @@ test.ci.skip-vectorsets:
3849
set -e; for dir in $(GO_MOD_DIRS); do \
3950
echo "go test in $${dir} (skipping vector sets)"; \
4051
(cd "$${dir}" && \
52+
export RE_CLUSTER=$(RE_CLUSTER) && \
53+
export RCE_DOCKER=$(RCE_DOCKER) && \
54+
export REDIS_VERSION=$(REDIS_VERSION) && \
4155
go mod tidy -compat=1.18 && \
4256
go vet && \
4357
go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race \
@@ -47,11 +61,17 @@ test.ci.skip-vectorsets:
4761
go vet -vettool ./internal/customvet/customvet
4862

4963
bench:
64+
export RE_CLUSTER=$(RE_CLUSTER) && \
65+
export RCE_DOCKER=$(RCE_DOCKER) && \
66+
export REDIS_VERSION=$(REDIS_VERSION) && \
5067
go test ./... -test.run=NONE -test.bench=. -test.benchmem -skip Example
5168

5269
.PHONY: all test test.ci test.ci.skip-vectorsets bench fmt
5370

5471
build:
72+
export RE_CLUSTER=$(RE_CLUSTER) && \
73+
export RCE_DOCKER=$(RCE_DOCKER) && \
74+
export REDIS_VERSION=$(REDIS_VERSION) && \
5575
go build .
5676

5777
fmt:

0 commit comments

Comments
 (0)