Skip to content

Commit 3615779

Browse files
committed
fix example tests, pop more connections
1 parent bfca15a commit 3615779

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

example_instrumentation_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ func Example_instrumentation() {
5757
// finished dialing tcp :6379
5858
// starting processing: <[hello 3]>
5959
// finished processing: <[hello 3]>
60-
// starting processing: <[client maint_notifications on moving-endpoint-type external-ip]>
61-
// finished processing: <[client maint_notifications on moving-endpoint-type external-ip]>
60+
// starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
61+
// finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
6262
// finished processing: <[ping]>
6363
}
6464

@@ -80,8 +80,8 @@ func ExamplePipeline_instrumentation() {
8080
// finished dialing tcp :6379
8181
// starting processing: <[hello 3]>
8282
// finished processing: <[hello 3]>
83-
// starting processing: <[client maint_notifications on moving-endpoint-type external-ip]>
84-
// finished processing: <[client maint_notifications on moving-endpoint-type external-ip]>
83+
// starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
84+
// finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
8585
// pipeline finished processing: [[ping] [ping]]
8686
}
8787

@@ -103,8 +103,8 @@ func ExampleClient_Watch_instrumentation() {
103103
// finished dialing tcp :6379
104104
// starting processing: <[hello 3]>
105105
// finished processing: <[hello 3]>
106-
// starting processing: <[client maint_notifications on moving-endpoint-type external-ip]>
107-
// finished processing: <[client maint_notifications on moving-endpoint-type external-ip]>
106+
// starting processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
107+
// finished processing: <[client maint_notifications on moving-endpoint-type internal-fqdn]>
108108
// finished processing: <[watch foo]>
109109
// starting processing: <[ping]>
110110
// finished processing: <[ping]>

internal/pool/pool.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ var (
2626
// popAttempts is the maximum number of attempts to find a usable connection
2727
// when popping from the idle connection pool. This handles cases where connections
2828
// are temporarily marked as unusable (e.g., during hitless upgrades or network issues).
29-
// Value of 10 provides sufficient resilience without excessive overhead.
30-
popAttempts = 10
29+
// Value of 20 provides sufficient resilience without excessive overhead.
30+
popAttempts = 20
3131

3232
// getAttempts is the maximum number of attempts to get a connection that passes
3333
// hook validation (e.g., hitless upgrade hooks). This protects against race conditions

0 commit comments

Comments
 (0)