deadlock?

Author: ndyakov

async_handoff_integration_test.go

@@ -269,6 +269,7 @@ func TestEventDrivenHandoffIntegration(t *testing.T) {
 		}
 
 		processor := hitless.NewPoolHook(slowDialer, "tcp", nil, nil)
+		defer processor.Shutdown(context.Background())
 
 		// Create hooks manager and add processor as hook
 		hookManager := pool.NewPoolHookManager()

hitless/hitless_manager.go

@@ -13,6 +13,8 @@ import (
 	"github.com/redis/go-redis/v9/internal/pool"
 )
 
+
+
 // Push notification type constants for hitless upgrades
 const (
 	NotificationMoving      = "MOVING"

redis.go

@@ -448,11 +448,17 @@ func (c *baseClient) initConn(ctx context.Context, cn *pool.Conn) error {
 	}
 
 	// Enable maintenance notifications if hitless upgrades are configured
-	if c.opt.HitlessUpgradeConfig.IsEnabled() && c.opt.Protocol == 3 {
+	c.optLock.RLock()
+	hitlessEnabled := c.opt.HitlessUpgradeConfig.IsEnabled()
+	protocol := c.opt.Protocol
+	endpointType := c.opt.HitlessUpgradeConfig.EndpointType
+	c.optLock.RUnlock()
+
+	if hitlessEnabled && protocol == 3 {
 		hitlessHandshakeErr = conn.ClientMaintNotifications(
 			ctx,
 			true,
-			c.opt.HitlessUpgradeConfig.EndpointType.String(),
+			endpointType.String(),
 		).Err()
 		if hitlessHandshakeErr != nil {
 			c.optLock.RLock()