refactor for readibility x2

Author: ndyakov

hitless/errors.go

@@ -18,7 +18,6 @@ var (
 
 	// Configuration validation errors
 	ErrInvalidHandoffRetries = errors.New("hitless: MaxHandoffRetries must be between 1 and 10")
-	ErrInvalidHandoffState   = errors.New("hitless: Conn is in invalid state for handoff")
 )
 
 // Integration errors
@@ -35,3 +34,12 @@ var (
 var (
 	ErrInvalidNotification = errors.New("hitless: invalid notification format")
 )
+
+// connection handoff errors
+var (
+	// ErrConnectionMarkedForHandoff is returned when a connection is marked for handoff
+	// and should not be used until the handoff is complete
+	ErrConnectionMarkedForHandoff = errors.New("hitless: connection marked for handoff")
+	// ErrConnectionInvalidHandoffState is returned when a connection is in an invalid state for handoff
+	ErrConnectionInvalidHandoffState = errors.New("hitless: connection is in invalid state for handoff")
+)

hitless/pool_hook.go

@@ -355,7 +355,7 @@ func (ph *PoolHook) performConnectionHandoffWithPool(ctx context.Context, conn *
 
 	newEndpoint := conn.GetHandoffEndpoint()
 	if newEndpoint == "" {
-		return false, ErrInvalidHandoffState
+		return false, ErrConnectionInvalidHandoffState
 	}
 
 	retries := conn.IncrementAndGetHandoffRetries(1)
@@ -445,8 +445,7 @@ func (ph *PoolHook) createEndpointDialer(endpoint string) func(context.Context)
 func (ph *PoolHook) Shutdown(ctx context.Context) error {
 	ph.shutdownOnce.Do(func() {
 		close(ph.shutdown)
-
-		// No timers to clean up with on-demand workers
+		// workers will exit when they finish their current request
 	})
 
 	// Wait for workers to complete
@@ -463,7 +462,3 @@ func (ph *PoolHook) Shutdown(ctx context.Context) error {
 		return ctx.Err()
 	}
 }
-
-// ErrConnectionMarkedForHandoff is returned when a connection is marked for handoff
-// and should not be used until the handoff is complete
-var ErrConnectionMarkedForHandoff = errors.New("connection marked for handoff")