fix: race slice for list function of ring client (#2931)

rfyiamcool · ofekshenawa · ndyakov · ofekshenawa · commit 4f9550fd9989 · 2025-08-11T01:42:45.000+03:00
* fix: race slice for list of ring client

Signed-off-by: rfyiamcool &lt;rfyiamcool@163.com&gt;

* fix: copy wrong list

Co-authored-by: Nedyalko Dyakov &lt;nedyalko.dyakov@gmail.com&gt;

---------

Signed-off-by: rfyiamcool &lt;rfyiamcool@163.com&gt;
Co-authored-by: ofekshenawa &lt;104765379+ofekshenawa@users.noreply.github.com&gt;
Co-authored-by: Nedyalko Dyakov &lt;nedyalko.dyakov@gmail.com&gt;
diff --git a/ring.go b/ring.go
@@ -341,7 +341,8 @@ func (c *ringSharding) List() []*ringShard {
 
 	c.mu.RLock()
 	if !c.closed {
-		list = c.shards.list
+		list = make([]*ringShard, len(c.shards.list))
+		copy(list, c.shards.list)
 	}
 	c.mu.RUnlock()
 

Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,8 @@ func (c ringSharding) List() []ringShard {`
`341`	`341`
`342`	`342`	`c.mu.RLock()`
`343`	`343`	`if !c.closed {`
`344`		`- list = c.shards.list`
	`344`	`+ list = make([]*ringShard, len(c.shards.list))`
	`345`	`+ copy(list, c.shards.list)`
`345`	`346`	`}`
`346`	`347`	`c.mu.RUnlock()`
`347`	`348`