added reactive cache refresh

Author: htemelski-oss

command.go

@@ -4378,7 +4378,6 @@ func (c *cmdsInfoCache) Get(ctx context.Context) (map[string]*CommandInfo, error
 	return c.cmds, err
 }
 
-// TODO: Call it on client reconnect
 func (c *cmdsInfoCache) Refresh() {
 	c.refreshLock.Lock()
 	defer c.refreshLock.Unlock()

osscluster.go

@@ -859,15 +859,19 @@ func (c *clusterState) slotNodes(slot int) []*clusterNode {
 //------------------------------------------------------------------------------
 
 type clusterStateHolder struct {
-	load func(ctx context.Context) (*clusterState, error)
-
-	state     atomic.Value
-	reloading uint32 // atomic
+	load                 func(ctx context.Context) (*clusterState, error)
+	commandsCacheRefresh func()
+	state                atomic.Value
+	reloading            uint32 // atomic
 }
 
-func newClusterStateHolder(fn func(ctx context.Context) (*clusterState, error)) *clusterStateHolder {
+func newClusterStateHolder(
+	load func(ctx context.Context) (*clusterState, error),
+	commandsCacheRefresh func(),
+) *clusterStateHolder {
 	return &clusterStateHolder{
-		load: fn,
+		load:                 load,
+		commandsCacheRefresh: commandsCacheRefresh,
 	}
 }
 
@@ -876,6 +880,7 @@ func (c *clusterStateHolder) Reload(ctx context.Context) (*clusterState, error)
 	if err != nil {
 		return nil, err
 	}
+	c.commandsCacheRefresh()
 	c.state.Store(state)
 	return state, nil
 }
@@ -940,9 +945,9 @@ func NewClusterClient(opt *ClusterOptions) *ClusterClient {
 		nodes: newClusterNodes(opt),
 	}
 
-	c.state = newClusterStateHolder(c.loadState)
-	// TODO: execute on handshake, should be called again on reconnect
 	c.cmdsInfoCache = newCmdsInfoCache(c.cmdsInfo)
+
+	c.state = newClusterStateHolder(c.loadState, c.cmdsInfoCache.Refresh)
 	c.cmdable = c.Process
 	c.initHooks(hooks{
 		dial:       nil,