Merge branch 'master' into use-hash-tag-in-scan-commands

Author: ndyakov

.github/actions/run-tests/action.yml

@@ -25,9 +25,9 @@ runs:
         
         # Mapping of redis version to redis testing containers
         declare -A redis_version_mapping=(
-          ["8.0.1"]="8.0.1-pre"
-          ["7.4.2"]="rs-7.4.0-v2"
-          ["7.2.7"]="rs-7.2.0-v14"
+          ["8.0.x"]="8.0.2"
+          ["7.4.x"]="rs-7.4.0-v5"
+          ["7.2.x"]="rs-7.2.0-v17"
         )
         
         if [[ -v redis_version_mapping[$REDIS_VERSION] ]]; then

.github/workflows/build.yml

@@ -18,8 +18,8 @@ jobs:
       fail-fast: false
       matrix:
         redis-version:
-          - "8.0.1" # 8.0.1
-          - "7.4.2" # should use redis stack 7.4
+          - "8.0.x" # Redis CE 8.0
+          - "7.4.x" # Redis stack 7.4
         go-version:
           - "1.23.x"
           - "1.24.x"
@@ -43,8 +43,8 @@ jobs:
           
           # Mapping of redis version to redis testing containers
           declare -A redis_version_mapping=(
-            ["8.0.1"]="8.0.1-pre"
-            ["7.4.2"]="rs-7.4.0-v2"
+            ["8.0.x"]="8.0.2"
+            ["7.4.x"]="rs-7.4.0-v5"
           )
           if [[ -v redis_version_mapping[$REDIS_VERSION] ]]; then
             echo "REDIS_VERSION=${redis_version_np}" >> $GITHUB_ENV
@@ -72,9 +72,9 @@ jobs:
         fail-fast: false
         matrix:
           redis-version:
-            - "8.0.1" # 8.0.1
-            - "7.4.2" # should use redis stack 7.4
-            - "7.2.7" # should redis stack 7.2
+            - "8.0.x" # Redis CE 8.0
+            - "7.4.x" # Redis stack 7.4
+            - "7.2.x" # Redis stack 7.2
           go-version:
             - "1.23.x"
             - "1.24.x"

.github/workflows/doctests.yaml

@@ -16,9 +16,11 @@ jobs:
 
     services:
       redis-stack:
-        image: redis/redis-stack-server:latest
-        options: >-
-          --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5
+        image: redislabs/client-libs-test:8.0.2
+        env:
+          TLS_ENABLED: no
+          REDIS_CLUSTER: no
+          PORT: 6379
         ports:
           - 6379:6379
 
@@ -38,4 +40,4 @@ jobs:
 
       - name: Test doc examples
         working-directory: ./doctests
-        run: go test -v
+        run: make test

.github/workflows/spellcheck.yml

@@ -8,7 +8,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Check Spelling
-        uses: rojopolis/spellcheck-github-actions@0.49.0
+        uses: rojopolis/spellcheck-github-actions@0.51.0
         with:
           config_path: .github/spellcheck-settings.yml
           task_name: Markdown

Makefile

@@ -8,7 +8,19 @@ docker.stop:
 
 test:
 	$(MAKE) docker.start
-	$(MAKE) test.ci
+	@if [ -z "$(REDIS_VERSION)" ]; then \
+		echo "REDIS_VERSION not set, running all tests"; \
+		$(MAKE) test.ci; \
+	else \
+		MAJOR_VERSION=$$(echo "$(REDIS_VERSION)" | cut -d. -f1); \
+		if [ "$$MAJOR_VERSION" -ge 8 ]; then \
+			echo "REDIS_VERSION $(REDIS_VERSION) >= 8, running all tests"; \
+			$(MAKE) test.ci; \
+		else \
+			echo "REDIS_VERSION $(REDIS_VERSION) < 8, skipping vector_sets tests"; \
+			$(MAKE) test.ci.skip-vectorsets; \
+		fi; \
+	fi
 	$(MAKE) docker.stop
 
 test.ci:
@@ -17,15 +29,27 @@ test.ci:
 	  (cd "$${dir}" && \
 	    go mod tidy -compat=1.18 && \
 	    go vet && \
-	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race); \
+	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -skip Example); \
+	done
+	cd internal/customvet && go build .
+	go vet -vettool ./internal/customvet/customvet
+
+test.ci.skip-vectorsets:
+	set -e; for dir in $(GO_MOD_DIRS); do \
+	  echo "go test in $${dir} (skipping vector sets)"; \
+	  (cd "$${dir}" && \
+	    go mod tidy -compat=1.18 && \
+	    go vet && \
+	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race \
+	      -run '^(?!.*(?:VectorSet|vectorset|ExampleClient_vectorset)).*$$' -skip Example); \
 	done
 	cd internal/customvet && go build .
 	go vet -vettool ./internal/customvet/customvet
 
 bench:
-	go test ./... -test.run=NONE -test.bench=. -test.benchmem
+	go test ./... -test.run=NONE -test.bench=. -test.benchmem -skip Example
 
-.PHONY: all test bench fmt
+.PHONY: all test test.ci test.ci.skip-vectorsets bench fmt
 
 build:
 	go build .

RELEASE-NOTES.md

@@ -1,5 +1,31 @@
 # Release Notes
 
+# 9.10.0 (2025-06-06)
+
+## 🚀 Highlights
+
+`go-redis` now supports [vector sets](https://redis.io/docs/latest/develop/data-types/vector-sets/). This data type is marked
+as "in preview" in Redis and its support in `go-redis` is marked as experimental. You can find examples in the documentation and
+in the `doctests` folder.
+
+# Changes
+
+## 🚀 New Features
+
+- feat: support vectorset ([#3375](https://github.com/redis/go-redis/pull/3375))
+
+## 🧰 Maintenance
+
+- Add the missing NewFloatSliceResult for testing ([#3393](https://github.com/redis/go-redis/pull/3393))
+- DOC-5078 vector set examples ([#3394](https://github.com/redis/go-redis/pull/3394))
+
+## Contributors
+We'd like to thank all the contributors who worked on this release!
+
+[@AndBobsYourUncle](https://github.com/AndBobsYourUncle), [@andy-stark-redis](https://github.com/andy-stark-redis), [@fukua95](https://github.com/fukua95) and [@ndyakov](https://github.com/ndyakov)
+
+
+
 # 9.9.0 (2025-05-27)
 
 ## 🚀 Highlights

auth/auth_test.go

@@ -2,6 +2,7 @@ package auth
 
 import (
 	"errors"
+	"strings"
 	"sync"
 	"testing"
 	"time"
@@ -179,36 +180,90 @@ func TestStreamingCredentialsProvider(t *testing.T) {
 }
 
 func TestBasicCredentials(t *testing.T) {
-	t.Run("basic auth", func(t *testing.T) {
-		creds := NewBasicCredentials("user1", "pass1")
-		username, password := creds.BasicAuth()
-		if username != "user1" {
-			t.Fatalf("expected username 'user1', got '%s'", username)
-		}
-		if password != "pass1" {
-			t.Fatalf("expected password 'pass1', got '%s'", password)
-		}
-	})
-
-	t.Run("raw credentials", func(t *testing.T) {
-		creds := NewBasicCredentials("user1", "pass1")
-		raw := creds.RawCredentials()
-		expected := "user1:pass1"
-		if raw != expected {
-			t.Fatalf("expected raw credentials '%s', got '%s'", expected, raw)
-		}
-	})
+	tests := []struct {
+		name         string
+		username     string
+		password     string
+		expectedUser string
+		expectedPass string
+		expectedRaw  string
+	}{
+		{
+			name:         "basic auth",
+			username:     "user1",
+			password:     "pass1",
+			expectedUser: "user1",
+			expectedPass: "pass1",
+			expectedRaw:  "user1:pass1",
+		},
+		{
+			name:         "empty username",
+			username:     "",
+			password:     "pass1",
+			expectedUser: "",
+			expectedPass: "pass1",
+			expectedRaw:  ":pass1",
+		},
+		{
+			name:         "empty password",
+			username:     "user1",
+			password:     "",
+			expectedUser: "user1",
+			expectedPass: "",
+			expectedRaw:  "user1:",
+		},
+		{
+			name:         "both username and password empty",
+			username:     "",
+			password:     "",
+			expectedUser: "",
+			expectedPass: "",
+			expectedRaw:  ":",
+		},
+		{
+			name:         "special characters",
+			username:     "user:1",
+			password:     "pa:ss@!#",
+			expectedUser: "user:1",
+			expectedPass: "pa:ss@!#",
+			expectedRaw:  "user:1:pa:ss@!#",
+		},
+		{
+			name:         "unicode characters",
+			username:     "ユーザー",
+			password:     "密碼123",
+			expectedUser: "ユーザー",
+			expectedPass: "密碼123",
+			expectedRaw:  "ユーザー:密碼123",
+		},
+		{
+			name:         "long credentials",
+			username:     strings.Repeat("u", 1000),
+			password:     strings.Repeat("p", 1000),
+			expectedUser: strings.Repeat("u", 1000),
+			expectedPass: strings.Repeat("p", 1000),
+			expectedRaw:  strings.Repeat("u", 1000) + ":" + strings.Repeat("p", 1000),
+		},
+	}
 
-	t.Run("empty username", func(t *testing.T) {
-		creds := NewBasicCredentials("", "pass1")
-		username, password := creds.BasicAuth()
-		if username != "" {
-			t.Fatalf("expected empty username, got '%s'", username)
-		}
-		if password != "pass1" {
-			t.Fatalf("expected password 'pass1', got '%s'", password)
-		}
-	})
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			creds := NewBasicCredentials(tt.username, tt.password)
+
+			user, pass := creds.BasicAuth()
+			if user != tt.expectedUser {
+				t.Errorf("BasicAuth() username = %q; want %q", user, tt.expectedUser)
+			}
+			if pass != tt.expectedPass {
+				t.Errorf("BasicAuth() password = %q; want %q", pass, tt.expectedPass)
+			}
+
+			raw := creds.RawCredentials()
+			if raw != tt.expectedRaw {
+				t.Errorf("RawCredentials() = %q; want %q", raw, tt.expectedRaw)
+			}
+		})
+	}
 }
 
 func TestReAuthCredentialsListener(t *testing.T) {

command.go

@@ -3584,15 +3584,14 @@ func (c *cmdsInfoCache) Get(ctx context.Context) (map[string]*CommandInfo, error
 			return err
 		}
 
+		lowerCmds := make(map[string]*CommandInfo, len(cmds))
+
 		// Extensions have cmd names in upper case. Convert them to lower case.
 		for k, v := range cmds {
-			lower := internal.ToLower(k)
-			if lower != k {
-				cmds[lower] = v
-			}
+			lowerCmds[internal.ToLower(k)] = v
 		}
 
-		c.cmds = cmds
+		c.cmds = lowerCmds
 		return nil
 	})
 	return c.cmds, err

commands_test.go

@@ -460,7 +460,7 @@ var _ = Describe("Commands", func() {
 			}
 
 			// read the defaults to set them back later
-			for setting, _ := range expected {
+			for setting := range expected {
 				val, err := client.ConfigGet(ctx, setting).Result()
 				Expect(err).NotTo(HaveOccurred())
 				defaults[setting] = val[setting]

doctests/Makefile

@@ -0,0 +1,16 @@
+test:
+	@if [ -z "$(REDIS_VERSION)" ]; then \
+		echo "REDIS_VERSION not set, running all tests"; \
+		go test -v ./...; \
+	else \
+		MAJOR_VERSION=$$(echo "$(REDIS_VERSION)" | cut -d. -f1); \
+		if [ "$$MAJOR_VERSION" -ge 8 ]; then \
+			echo "REDIS_VERSION $(REDIS_VERSION) >= 8, running all tests"; \
+			go test -v ./...; \
+		else \
+			echo "REDIS_VERSION $(REDIS_VERSION) < 8, skipping vector_sets tests"; \
+			go test -v ./... -run '^(?!.*(?:vectorset|ExampleClient_vectorset)).*$$'; \
+		fi; \
+	fi
+
+.PHONY: test