fix: race slice for list of ring client

rfyiamcool · rfyiamcool · commit 7967937b52ed · 2024-03-01T11:22:06.000+08:00
Signed-off-by: rfyiamcool &lt;rfyiamcool@163.com&gt;
diff --git a/ring.go b/ring.go
@@ -339,7 +339,8 @@ func (c *ringSharding) List() []*ringShard {
 
 	c.mu.RLock()
 	if !c.closed {
-		list = c.shards.list
+		list = make([]*ringShard, len(c.shards.list))
+		copy(c.shards.list, list)
 	}
 	c.mu.RUnlock()
 

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,8 @@ func (c ringSharding) List() []ringShard {`
`339`	`339`
`340`	`340`	`c.mu.RLock()`
`341`	`341`	`if !c.closed {`
`342`		`- list = c.shards.list`
	`342`	`+ list = make([]*ringShard, len(c.shards.list))`
	`343`	`+ copy(c.shards.list, list)`
`343`	`344`	`}`
`344`	`345`	`c.mu.RUnlock()`
`345`	`346`