Skip to content

Commit a11b22f

Browse files
committed
Cleanup
1 parent 3b2dd4f commit a11b22f

File tree

1 file changed

+20
-19
lines changed

1 file changed

+20
-19
lines changed

command.go

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,12 +1073,26 @@ func (cmd *XMessageSliceCmd) String() string {
10731073
}
10741074

10751075
func (cmd *XMessageSliceCmd) readReply(rd *proto.Reader) error {
1076-
v, err := rd.ReadArrayReply(xMessageSliceParser)
1076+
var err error
1077+
cmd.val, err = readXMessageSlice(rd)
1078+
return err
1079+
}
1080+
1081+
func readXMessageSlice(rd *proto.Reader) ([]XMessage, error) {
1082+
n, err := rd.ReadArrayLen()
10771083
if err != nil {
1078-
return err
1084+
return nil, err
10791085
}
1080-
cmd.val = v.([]XMessage)
1081-
return nil
1086+
1087+
msgs := make([]XMessage, n)
1088+
for i := 0; i < n; i++ {
1089+
var err error
1090+
msgs[i], err = readXMessage(rd)
1091+
if err != nil {
1092+
return nil, err
1093+
}
1094+
}
1095+
return msgs, nil
10821096
}
10831097

10841098
func readXMessage(rd *proto.Reader) (XMessage, error) {
@@ -1112,19 +1126,6 @@ func readXMessage(rd *proto.Reader) (XMessage, error) {
11121126
}, nil
11131127
}
11141128

1115-
// xMessageSliceParser implements proto.MultiBulkParse.
1116-
func xMessageSliceParser(rd *proto.Reader, n int64) (interface{}, error) {
1117-
msgs := make([]XMessage, n)
1118-
for i := int64(0); i < n; i++ {
1119-
var err error
1120-
msgs[i], err = readXMessage(rd)
1121-
if err != nil {
1122-
return nil, err
1123-
}
1124-
}
1125-
return msgs, nil
1126-
}
1127-
11281129
// stringInterfaceMapParser implements proto.MultiBulkParse.
11291130
func stringInterfaceMapParser(rd *proto.Reader, n int64) (interface{}, error) {
11301131
m := make(map[string]interface{}, n/2)
@@ -1195,14 +1196,14 @@ func (cmd *XStreamSliceCmd) readReply(rd *proto.Reader) error {
11951196
return nil, err
11961197
}
11971198

1198-
v, err := rd.ReadArrayReply(xMessageSliceParser)
1199+
msgs, err := readXMessageSlice(rd)
11991200
if err != nil {
12001201
return nil, err
12011202
}
12021203

12031204
cmd.val[i] = XStream{
12041205
Stream: stream,
1205-
Messages: v.([]XMessage),
1206+
Messages: msgs,
12061207
}
12071208
return nil, nil
12081209
})

0 commit comments

Comments
 (0)