self review, cleanup, add comments

Author: ndyakov

Makefile

@@ -2,7 +2,6 @@ GO_MOD_DIRS := $(shell find . -type f -name 'go.mod' -exec dirname {} \; | sort)
 export REDIS_MAJOR_VERSION := 7
 
 test: testdeps
-	$(eval R_MAJOR := $(shell echo "$(REDIS_VERSION)" | grep -o '\d' | head -1))
 	docker start go-redis-redis-stack || docker run -d --name go-redis-redis-stack  -p 6379:6379 -e REDIS_ARGS="--enable-debug-command yes --enable-module-command yes" redis/redis-stack-server:latest
 	$(eval GO_VERSION := $(shell go version | cut -d " " -f 3 | cut -d. -f2))
 	set -e; for dir in $(GO_MOD_DIRS); do \
@@ -24,10 +23,6 @@ test: testdeps
 	go vet -vettool ./internal/customvet/customvet
 	docker stop go-redis-redis-stack
 
-dockertest:
-	docker start go-redis-redis-stack || docker run -d --name go-redis-redis-stack  -p 6379:6379 -e REDIS_ARGS="--enable-debug-command yes --enable-module-command yes" redis/redis-stack-server:latest
-	docker stop go-redis-redis-stack
-
 testdeps: testdata/redis/src/redis-server
 
 bench: testdeps

search_commands.go

@@ -282,6 +282,9 @@ type FTSearchSortBy struct {
 	Desc      bool
 }
 
+// FTSearchOptions hold options that can be passed to the FT.SEARCH command.
+// More information about the options can be found
+// in the documentation for FT.SEARCH https://redis.io/docs/latest/commands/ft.search/
 type FTSearchOptions struct {
 	NoContent    bool
 	Verbatim     bool
@@ -299,7 +302,10 @@ type FTSearchOptions struct {
 	InOrder      bool
 	Language     string
 	Expander     string
-	// TODO: add document about scorers
+	// Scorer is used to set scoring function, if not set passed, a default will be used.
+	// The default scorer depends on the Redis version:
+	// - `BM25` for Redis >= 8
+	// - `TFIDF` for Redis < 8
 	Scorer          string
 	ExplainScore    bool
 	Payload         string

search_test.go

@@ -416,7 +416,7 @@ var _ = Describe("RediSearch commands Resp 2", Label("search"), func() {
 
 	It("should FTSearch WithScores", Label("search", "ftsearch"), func() {
 		if REDIS_MAJOR_VERSION >= 8 {
-			Skip("default scorer is BM25")
+			Skip("default scorer is not TFIDF")
 		}
 		text1 := &redis.FieldSchema{FieldName: "description", FieldType: redis.SearchFieldTypeText}
 		val, err := client.FTCreate(ctx, "idx1", &redis.FTCreateOptions{}, text1).Result()