address comments

Author: ndyakov

Makefile

@@ -29,7 +29,7 @@ test.ci:
 	  (cd "$${dir}" && \
 	    go mod tidy -compat=1.18 && \
 	    go vet && \
-	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -timeout 20m -skip Example); \
+	    go test -v -coverprofile=coverage.txt -covermode=atomic ./... -race -skip Example); \
 	done
 	cd internal/customvet && go build .
 	go vet -vettool ./internal/customvet/customvet

hitless/notification_handler.go

@@ -118,6 +118,9 @@ func (snh *NotificationHandler) handleMoving(ctx context.Context, handlerCtx pus
 		// do this in a goroutine to avoid blocking the notification handler
 		go func() {
 			time.Sleep(time.Duration(timeS/2) * time.Second)
+			if poolConn == nil || poolConn.IsClosed() {
+				return
+			}
 			if err := snh.markConnForHandoff(poolConn, newEndpoint, seqID, deadline); err != nil {
 				// Log error but don't fail the goroutine
 				internal.Logger.Printf(context.Background(), "hitless: failed to mark connection for handoff: %v", err)

internal/pool/conn.go

@@ -45,6 +45,7 @@ type Conn struct {
 
 	Inited    atomic.Bool
 	pooled    bool
+	closed    atomic.Bool
 	createdAt time.Time
 	expiresAt time.Time
 
@@ -542,7 +543,12 @@ func (cn *Conn) WithWriter(
 	return cn.bw.Flush()
 }
 
+func (cn *Conn) IsClosed() bool {
+	return cn.closed.Load()
+}
+
 func (cn *Conn) Close() error {
+	cn.closed.Store(true)
 	if cn.onClose != nil {
 		// ignore error
 		_ = cn.onClose()