docs: update CONTRIBUTING #3223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bitsark
commented
Jan 9, 2025
bitsark
commented
- Use redis/redis-stack-server:latest as test docker server.
- Fix typo.
* Use redis/redis-stack-server:latest as test docker server. * Fix typo.
Member
|
Thank you for the PR @bitsark. The library should support testing with multiple versions of Redis (Stack) Community Edition. As mentioned in https://redis.io/blog/introducing-another-era-of-fast/ , from Redis 8.0 CE , the features of Stack will be included in the CE release. Would you mind if we wait for that release and then update the documentation accordingly? |
Member
|
Closing the PR. Will wait for a proper redis ce release to update contributing and readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.