Add the missing NewFloatSliceResult for testing #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajtripathi
approved these changes
May 28, 2025
cmaxwell23
approved these changes
May 28, 2025
ndyakov
approved these changes
May 30, 2025
There was a problem hiding this comment.
Hello @AndBobsYourUncle , this looks good, thank you for the contribution. I know it may seem useless, but would you mind adding tests for all New*Result functions in this file? I can do it in a separate PR for the existing ones, and you can add just for the NewFloatSliceResult if you don't have the time.
|
I will merge this and add tests separately, thank you. |
ofekshenawa
pushed a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was developing for another project, I ran into a situation in which I needed to test
ZMScorein my unit tests.However, I found out that there existed no helper method that returned a mocked
FloatSliceCmdwith a populated result.After digging into the code, it looked to me like there existed
NewStringSliceResult,NewBoolSliceResult, but noNewFloatSliceResultmethod.This PR simply adds that method so that it can be used for testing in other projects.