Add VAMANA vector type to RediSearch #3449
Merged
+753
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amana-vector-type-to-search
ndyakov
requested changes
Jul 30, 2025
There was a problem hiding this comment.
@ofekshenawa thank you for contributing this. I can see there are panics that were in the code even before we added this change, but let's make sure we don't panic during the execution of a command. Maybe the arguments were dynamically build, and returning an error should be sufficient way of noting that they are wrong, panicking will stop the whole execution of the application (if not recovered) and we should not do that.
ofekshenawa
force-pushed
the
add-vamana-vector-type-to-search
branch
from
a424291 to
8c00693
Compare
ofekshenawa
added a commit
that referenced
this pull request
Aug 10, 2025
* Add VAMANA vector type to redisearch * Change to svs-vamana vector type && remove panics from search module * fix tests * fix tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements comprehensive support for the VAMANA vector index algorithm introduced in Redis 8.2+.
Key Changes
Core Implementation : Added FTVamanaOptions struct with full parameter support (distance metrics, vector types, compression, advanced tuning)
Feature Set : Supports L2/COSINE/IP distance metrics, FLOAT16/FLOAT32 vector types, LVQ8 compression, construction window size and graph max degree
Tests: Includes test suite covering VAMANA functionality, distance metrics, compression scenarios, and parameter combinations