fix: remove unnecessary case-sensitivity when working with commands (#2036)

* fix: remove unnecessary case-sensitivity when working with commands

* fix-1913 update commands version

Author: pinkiesky

lib/Command.ts

@@ -119,6 +119,7 @@ export default class Command implements Respondable {
     flagName: T,
     commandName: string
   ): commandName is CommandNameFlags[T][number] {
+    commandName = commandName.toLowerCase();
     return !!this.getFlagMap()[flagName][commandName];
   }
 
@@ -358,9 +359,11 @@ export default class Command implements Respondable {
   ): (string | Buffer)[] {
     if (typeof this.keys === "undefined") {
       this.keys = [];
-      if (exists(this.name)) {
+      if (exists(this.name, { caseInsensitive: true })) {
         // @ts-expect-error
-        const keyIndexes = getKeyIndexes(this.name, this.args);
+        const keyIndexes = getKeyIndexes(this.name, this.args, {
+          nameCaseInsensitive: true,
+        });
         for (const index of keyIndexes) {
           this.args[index] = transform(this.args[index]);
           this.keys.push(this.args[index] as string | Buffer);

lib/Pipeline.ts

@@ -123,7 +123,8 @@ class Pipeline extends Commander<{ type: "pipeline" }> {
           }
         } else if (!command.inTransaction) {
           const isReadOnly =
-            exists(command.name) && hasFlag(command.name, "readonly");
+            exists(command.name, { caseInsensitive: true }) &&
+            hasFlag(command.name, "readonly", { nameCaseInsensitive: true });
           if (!isReadOnly) {
             retriable = false;
             break;

lib/Redis.ts

@@ -449,8 +449,8 @@ class Redis extends Commander implements DataHandledable {
       this.status === "ready" ||
       (!stream &&
         this.status === "connect" &&
-        exists(command.name) &&
-        (hasFlag(command.name, "loading") ||
+        exists(command.name, { caseInsensitive: true }) &&
+        (hasFlag(command.name, "loading", { nameCaseInsensitive: true }) ||
           Command.checkFlag("HANDSHAKE_COMMANDS", command.name)));
     if (!this.stream) {
       writable = false;

package-lock.json

@@ -43,7 +43,7 @@
     "url": "https://opencollective.com/ioredis"
   },
   "dependencies": {
-    "@ioredis/commands": "1.4.0",
+    "@ioredis/commands": "1.5.0",
     "cluster-key-slot": "^1.1.0",
     "debug": "^4.3.4",
     "denque": "^2.1.0",

package.json

@@ -183,5 +183,17 @@ describe("transformer", () => {
         });
       });
     });
+
+    describe("call", () => {
+      it("keyPrefix should be case insensitive for command name", async () => {
+        const redis = new Redis({ keyPrefix: "foo:" });
+
+        const value = "value1";
+        expect(await redis.call("SeT", "mykey", value)).to.eql("OK");
+
+        const otherRedis = new Redis();
+        expect(await otherRedis.call("get", "foo:mykey")).to.eql(value);
+      });
+    });
   });
 });

test/functional/transformer.ts

@@ -165,5 +165,15 @@ describe("Command", () => {
       );
       expect(Command.checkFlag("WILL_DISCONNECT", "quit")).to.eql(true);
     });
+
+    it('should be case insensitive for command name', () => {
+      expect(Command.checkFlag("VALID_IN_SUBSCRIBER_MODE", "PING")).to.eql(
+        true
+      );
+      expect(Command.checkFlag("VALID_IN_SUBSCRIBER_MODE", "Get")).to.eql(
+        false
+      );
+      expect(Command.checkFlag("WILL_DISCONNECT", "QuIt")).to.eql(true);
+    });
   });
 });