Skip to content

Commit 6306c98

Browse files
authored
Fix BF.INSERT and BF.MADD parser(s) (#3408)
1 parent d91033e commit 6306c98

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

src/main/java/redis/clients/jedis/BuilderFactory.java

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import java.util.*;
55
import java.util.stream.Collectors;
66

7+
import redis.clients.jedis.exceptions.JedisDataException;
78
import redis.clients.jedis.resps.*;
89
import redis.clients.jedis.resps.LCSMatchResult.MatchedPosition;
910
import redis.clients.jedis.resps.LCSMatchResult.Position;
@@ -165,24 +166,11 @@ public String toString() {
165166
@Override
166167
@SuppressWarnings("unchecked")
167168
public List<Boolean> build(Object data) {
168-
if (null == data) {
169-
return null;
170-
}
171-
List<Object> longs = (List<Object>) data;
172-
List<Boolean> booleans = new ArrayList<>(longs.size());
173-
for (Object value : longs) {
174-
Boolean bool = null;
175-
if (value != null && value instanceof Long) {
176-
long longValue = (Long) value;
177-
if (longValue == 1L) {
178-
bool = Boolean.TRUE;
179-
} else if (longValue == 0L) {
180-
bool = Boolean.FALSE;
181-
}
182-
}
183-
booleans.add(bool);
184-
}
185-
return booleans;
169+
if (null == data) return null;
170+
return ((List<Object>) data).stream()
171+
//.map((val) -> (val instanceof JedisDataException) ? val : BOOLEAN.build(val))
172+
.map((val) -> (val instanceof JedisDataException) ? null : BOOLEAN.build(val))
173+
.collect(Collectors.toList());
186174
}
187175

188176
@Override

src/main/java/redis/clients/jedis/CommandObjects.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3836,7 +3836,7 @@ public final CommandObject<Boolean> bfAdd(String key, String item) {
38363836

38373837
public final CommandObject<List<Boolean>> bfMAdd(String key, String... items) {
38383838
return new CommandObject<>(commandArguments(BloomFilterCommand.MADD).key(key).
3839-
addObjects((Object[]) items), BuilderFactory.BOOLEAN_LIST);
3839+
addObjects((Object[]) items), BuilderFactory.BOOLEAN_WITH_ERROR_LIST);
38403840
}
38413841

38423842
public final CommandObject<List<Boolean>> bfInsert(String key, String... items) {

0 commit comments

Comments
 (0)