Skip to content

Commit 7a68df8

Browse files
authored
Use List<KeyValue> to read RESP3 Map reply (#3456)
When implementing RESP3, I converted the Redis Map reply (map{k1->v1, k2->v2, ...}) to simple flat array (list{k1, v1, k2, v2, ...}). In this PR, I have converted the Map reply to array of KeyValues (list{ kv{k1, v1}, kv{k2, v2}, ...}). As a by-product of this PR, some commands were found where the return can/should be a Map instead of a List. --- * Use List<KeyValue> to read RESP3 Map reply * module replies * fix lcs * fix xinfo * fix moduleList * fix timeoutConnection * fix aclLog already fixed * edit * fix moduleList * fix encodeCompleteResponse * Fix tsInfoDebug after timeseries update * remove commented code * docs and test edit
1 parent 869dc0b commit 7a68df8

28 files changed

+756
-441
lines changed

docs/jedis5-breaking.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@
2626
- `zunion(ZParams params, byte[]... keys)` method now returns `List<byte[]>` (instead of `Set<byte[]>`).
2727
- Both `zunionWithScores(ZParams params, String... keys)` and `zunionWithScores(ZParams params, byte[]... keys)` methods now return `List<Tuple>` (instead of `Set<Tuple>`).
2828

29+
- Both `configGet(String pattern)` and `configGet(String... patterns)` methods now return `Map<String, String>` instead of `List<String>`.
30+
- Both `configGet(byte[] pattern)` and `configGet(byte[]... patterns)` methods now return `Map<byte[], byte[]>` instead of `List<byte[]>`.
31+
32+
- New `aclDelUser(String... names)` method replaces `aclDelUser(String name)` and `aclDelUser(String name, String... names)` methods.
33+
- New `aclDelUser(byte[]... names)` method replaces `aclDelUser(byte[] name)` and `aclDelUser(byte[] name, byte[]... names)` methods.
34+
2935
- `tsMGet(TSMGetParams multiGetParams, String... filters)` method now returns `Map<String, TSMGetElement>` instead of `List<TSKeyValue<TSElement>>`.
3036

3137
- Following methods now return `Map<String, TSMRangeElements>` instead of `List<TSKeyedElements>`:

0 commit comments

Comments
 (0)