Skip to content

Commit 8fcb955

Browse files
committed
Rename MultiClusterTransaction to MultiDbTransaction
1 parent 8fd1bfe commit 8fcb955

File tree

5 files changed

+15
-28
lines changed

5 files changed

+15
-28
lines changed

src/main/java/redis/clients/jedis/MultiDbClient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import redis.clients.jedis.builders.MultiDbClientBuilder;
66
import redis.clients.jedis.csc.Cache;
77
import redis.clients.jedis.executors.CommandExecutor;
8-
import redis.clients.jedis.mcf.CircuitBreakerCommandExecutor;
8+
import redis.clients.jedis.mcf.MultiDbCommandExecutor;
99
import redis.clients.jedis.mcf.MultiDbPipeline;
1010
import redis.clients.jedis.mcf.MultiDbTransaction;
1111
import redis.clients.jedis.providers.ConnectionProvider;
@@ -75,9 +75,9 @@
7575
* resilience features.
7676
* </p>
7777
* @author Ivo Gaydazhiev
78-
* @since 5.2.0
78+
* @since 7.0.0
7979
* @see MultiDbConnectionProvider
80-
* @see CircuitBreakerCommandExecutor
80+
* @see MultiDbCommandExecutor
8181
* @see MultiDbConfig
8282
*/
8383
@Experimental
@@ -90,7 +90,7 @@ public class MultiDbClient extends UnifiedJedis {
9090
* the builder pattern for advanced configurations. For most use cases, prefer using
9191
* {@link #builder()} to create instances.
9292
* </p>
93-
* @param commandExecutor the command executor (typically CircuitBreakerCommandExecutor)
93+
* @param commandExecutor the command executor (typically MultiDbCommandExecutor)
9494
* @param connectionProvider the connection provider (typically MultiDbConnectionProvider)
9595
* @param commandObjects the command objects
9696
* @param redisProtocol the Redis protocol version

src/main/java/redis/clients/jedis/UnifiedJedis.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import redis.clients.jedis.params.VSimParams;
3333
import redis.clients.jedis.resps.RawVector;
3434
import redis.clients.jedis.json.JsonObjectMapper;
35-
import redis.clients.jedis.mcf.CircuitBreakerCommandExecutor;
35+
import redis.clients.jedis.mcf.MultiDbCommandExecutor;
3636
import redis.clients.jedis.mcf.MultiDbPipeline;
3737
import redis.clients.jedis.mcf.MultiDbConnectionProvider;
3838
import redis.clients.jedis.mcf.MultiDbTransaction;
@@ -232,18 +232,6 @@ public UnifiedJedis(ConnectionProvider provider, int maxAttempts, Duration maxTo
232232
this(new RetryableCommandExecutor(provider, maxAttempts, maxTotalRetriesDuration), provider);
233233
}
234234

235-
/**
236-
* Constructor which supports multiple cluster/database endpoints each with their own isolated connection pool.
237-
* <p>
238-
* With this Constructor users can seamlessly failover to Disaster Recovery (DR), Backup, and Active-Active cluster(s)
239-
* by using simple configuration which is passed through from Resilience4j - https://resilience4j.readme.io/docs
240-
* <p>
241-
*/
242-
@Experimental
243-
public UnifiedJedis(MultiDbConnectionProvider provider) {
244-
this(new CircuitBreakerCommandExecutor(provider), provider);
245-
}
246-
247235
/**
248236
* The constructor to use a custom {@link CommandExecutor}.
249237
* <p>

src/main/java/redis/clients/jedis/builders/MultiDbClientBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import redis.clients.jedis.MultiDbConfig;
66
import redis.clients.jedis.annots.Experimental;
77
import redis.clients.jedis.executors.CommandExecutor;
8-
import redis.clients.jedis.mcf.CircuitBreakerCommandExecutor;
8+
import redis.clients.jedis.mcf.MultiDbCommandExecutor;
99
import redis.clients.jedis.mcf.DatabaseSwitchEvent;
1010
import redis.clients.jedis.mcf.MultiDbConnectionProvider;
1111
import redis.clients.jedis.providers.ConnectionProvider;
@@ -60,7 +60,7 @@
6060
*
6161
* @param <C> the client type that this builder creates
6262
* @author Ivo Gaydazhiev
63-
* @since 5.2.0
63+
* @since 7.0.0
6464
*/
6565
@Experimental
6666
public abstract class MultiDbClientBuilder<C>
@@ -125,8 +125,8 @@ protected ConnectionProvider createDefaultConnectionProvider() {
125125

126126
@Override
127127
protected CommandExecutor createDefaultCommandExecutor() {
128-
// For multi-db clients, we always use CircuitBreakerCommandExecutor
129-
return new CircuitBreakerCommandExecutor((MultiDbConnectionProvider) this.connectionProvider);
128+
// For multi-db clients, we always use MultiDbCommandExecutor
129+
return new MultiDbCommandExecutor((MultiDbConnectionProvider) this.connectionProvider);
130130
}
131131

132132
@Override

src/main/java/redis/clients/jedis/mcf/CircuitBreakerCommandExecutor.java renamed to src/main/java/redis/clients/jedis/mcf/MultiDbCommandExecutor.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
* <p>
2222
*/
2323
@Experimental
24-
public class CircuitBreakerCommandExecutor extends CircuitBreakerFailoverBase
25-
implements CommandExecutor {
24+
public class MultiDbCommandExecutor extends CircuitBreakerFailoverBase implements CommandExecutor {
2625

27-
public CircuitBreakerCommandExecutor(MultiDbConnectionProvider provider) {
26+
public MultiDbCommandExecutor(MultiDbConnectionProvider provider) {
2827
super(provider);
2928
}
3029

src/test/java/redis/clients/jedis/mcf/CircuitBreakerThresholdsTest.java renamed to src/test/java/redis/clients/jedis/mcf/MultiDbCommandExecutorThresholdsTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class CircuitBreakerThresholdsTest {
3333
private MultiDbConnectionProvider realProvider;
3434
private MultiDbConnectionProvider spyProvider;
3535
private Database cluster;
36-
private CircuitBreakerCommandExecutor executor;
36+
private MultiDbCommandExecutor executor;
3737
private CommandObject<String> dummyCommand;
3838
private TrackingConnectionPool poolMock;
3939
private HostAndPort fakeEndpoint = new HostAndPort("fake", 6379);
@@ -61,7 +61,7 @@ public void setup() throws Exception {
6161

6262
cluster = spyProvider.getDatabase();
6363

64-
executor = new CircuitBreakerCommandExecutor(spyProvider);
64+
executor = new MultiDbCommandExecutor(spyProvider);
6565

6666
dummyCommand = new CommandObject<>(new CommandArguments(Protocol.Command.PING),
6767
BuilderFactory.STRING);
@@ -129,7 +129,7 @@ public void rateBelowThreshold_doesNotFailover() throws Exception {
129129
MultiDbConnectionProvider rp = new MultiDbConnectionProvider(cfgBuilder.build());
130130
MultiDbConnectionProvider sp = spy(rp);
131131
Database c = sp.getDatabase();
132-
try (CircuitBreakerCommandExecutor ex = new CircuitBreakerCommandExecutor(sp)) {
132+
try (MultiDbCommandExecutor ex = new MultiDbCommandExecutor(sp)) {
133133
CommandObject<String> cmd = new CommandObject<>(new CommandArguments(Protocol.Command.PING),
134134
BuilderFactory.STRING);
135135

@@ -197,7 +197,7 @@ public void thresholdMatrix(int minFailures, float ratePercent, int successes, i
197197
MultiDbConnectionProvider real = new MultiDbConnectionProvider(cfgBuilder.build());
198198
MultiDbConnectionProvider spy = spy(real);
199199
Database c = spy.getDatabase();
200-
try (CircuitBreakerCommandExecutor ex = new CircuitBreakerCommandExecutor(spy)) {
200+
try (MultiDbCommandExecutor ex = new MultiDbCommandExecutor(spy)) {
201201

202202
CommandObject<String> cmd = new CommandObject<>(new CommandArguments(Protocol.Command.PING),
203203
BuilderFactory.STRING);

0 commit comments

Comments
 (0)