List Jedis 5.0 breaking changes (#3415)

sazzad16 · web-flow · commit 8ffd10d7b7fb · 2023-05-15T19:45:26.000+06:00
* List Jedis 5.0 breaking changes

* Edit JavaDoc in stream response classes

* Comment out in GitHub markdown

* Address code review

"No need to declare vs. version 4. Should be self-evident."

* Address code review

"For all of these I think you should change to
```getAgeSeconds() in AccessControlLogEntry``` now returns `Double` instead of `String` .

Then, we can sort alphabetically too - and make it easier for users."

* edit

* Address code review

"`quit() method has been removed from `Connection` and ServerCommands implementations`"

* Address code review
diff --git a/docs/3to4.md b/docs/3to4.md
@@ -1,4 +1,4 @@
-# Jedis 3 to Jedis 4 Breaking Changes
+# Jedis 4 Breaking Changes
 
 - The `BinaryJedis` and `BinaryJedisCluster` classes have been removed.
 
diff --git a/docs/jedis5-breaking.md b/docs/jedis5-breaking.md
@@ -0,0 +1,80 @@
+# Jedis 5 Breaking Changes
+
+- `StreamConsumersInfo` has been renamed to `StreamConsumerInfo`.
+
+- `bzpopmax(double timeout, byte[]... keys)` now returns `List<Object>` (instead of `List<byte[]>`).
+  - This is a three element list where the last element is a `Double`.
+
+- `bzpopmin(double timeout, byte[]... keys)` now returns `List<Object>` (instead of `List<byte[]>`).
+  - This is a three element list where the last element is a `Double`.
+
+- `getAgeSeconds()` in `AccessControlLogEntry` now returns `Double` instead of `String`.
+
+- `graphSlowlog(String graphName)` now returns `List<List<Object>>` (instead of `List<List<String>>`).
+
+- `List<Object> getUnflushedObjectMultiBulkReply()` method has been removed from `Connection`.
+  - `Object getUnflushedObject()` method has been added instead.
+
+- `STREAM_INFO_FULL` in BuilderFactory has been renamed to `STREAM_FULL_INFO`.
+- `STREAM_CONSUMERS_INFO_LIST` in BuilderFactory has been renamed to `STREAM_CONSUMER_INFO_LIST`.
+- `STREAM_AUTO_CLAIM_ID_RESPONSE` in BuilderFactory has been renamed to `STREAM_AUTO_CLAIM_JUSTID_RESPONSE`.
+
+- Following BuilderFactory implementations have been removed:
+  - `BYTE_ARRAY` (use `BINARY`)
+  - `BYTE_ARRAY_LIST` (use `BINARY_LIST`)
+
+<!--- Deprecated in Jedis 4 --->
+
+- `quit()` method has been removed from `Connection` and `ServerCommands` interface and implementations.
+
+- `select(int index)` method has been removed from `Connection`.
+
+- `updatePassword(String password)` method has been removed from `JedisClientConfig` and implementations.
+
+- `setPassword(String password)` method has been removed from `ConnectionFactory`.
+
+- `setPassword(String password)` method has been removed from `JedisFactory`.
+
+- `get()` option has been removed from `SetParams`.  Following methods have been added in Jedis/UnifiedJedis for convenience:
+  - `setGet(String key, String value)` method has been added in `` interface.
+  - `setGet(byte[] key, byte[] value)` method has been added in `` interface.
+
+- `xpending(String key, String groupName, StreamEntryID start, StreamEntryID end, int count, String consumerName)` method has been removed from everywhere.
+  - Use `xpending(java.lang.String, java.lang.String, redis.clients.jedis.params.XPendingParams)` instead.
+
+- `xpending(byte[] key, byte[] groupName, byte[] start, byte[] end, int count, byte[] consumerName)` method has been removed from everywhere.
+  - Use `xpending(byte[], byte[], redis.clients.jedis.params.XPendingParams)` instead.
+
+- `topkCount(String key, String... items)` method has been removed from everywhere.
+
+- Following methods have been removed:
+  - `strAlgoLCSStrings(String strA, String strB, StrAlgoLCSParams params)`
+  - `strAlgoLCSStrings(byte[] strA, byte[] strB, StrAlgoLCSParams params)`
+  - `strAlgoLCSKeys(String keyA, String keyB, StrAlgoLCSParams params)`
+  - `strAlgoLCSKeys(byte[] keyA, byte[] keyB, StrAlgoLCSParams params)`
+
+- `StrAlgoLCSParams` has been removed.
+
+- Following methods have been removed from all Pipeline classes:
+  - `ftCursorRead(String indexName, long cursorId, int count)`
+  - `ftCursorDel(String indexName, long cursorId)`
+  - `ftDropIndex(String indexName)`
+  - `ftDropIndexDD(String indexName)`
+  - `ftAliasAdd(String aliasName, String indexName)`
+  - `ftAliasUpdate(String aliasName, String indexName)`
+  - `ftAliasDel(String aliasName)`
+
+- `addObjects(int[] ints)` method has been removed from `CommandArguments`.
+
+- `getArgsString()` and `serializeRedisArgs(List<byte[]> redisArgs)` methods have been removed from `AggregationBuilder`.
+
+- `totalResults` variable in `AggregationResult` has been made private. Use `getTotalResults()` method instead.
+
+- `retentionTime(long retentionTime)` method in `TSAlterParams` has been removed. Use `retention(long)` method instead.
+
+- `JedisSentineled(String masterName, Set<HostAndPort> sentinels, JedisClientConfig masterClientConfig, JedisClientConfig sentinelClientConfig)` and
+`JedisSentineled(String masterName, Set<HostAndPort> sentinels, GenericObjectPoolConfig<Connection> poolConfig, JedisClientConfig masterClientConfig, JedisClientConfig sentinelClientConfig)`
+constructors have been removed.
+
+- `JedisClusterInfoCache(JedisClientConfig clientConfig)` and `JedisClusterInfoCache(JedisClientConfig clientConfig, GenericObjectPoolConfig<Connection> poolConfig)`
+constructors have been removed.
diff --git a/src/main/java/redis/clients/jedis/BuilderFactory.java b/src/main/java/redis/clients/jedis/BuilderFactory.java
@@ -1101,7 +1101,7 @@ public String toString() {
     }
   };
 
-  public static final Builder<Map.Entry<StreamEntryID, List<StreamEntryID>>> STREAM_AUTO_CLAIM_ID_RESPONSE
+  public static final Builder<Map.Entry<StreamEntryID, List<StreamEntryID>>> STREAM_AUTO_CLAIM_JUSTID_RESPONSE
       = new Builder<Map.Entry<StreamEntryID, List<StreamEntryID>>>() {
     @Override
     @SuppressWarnings("unchecked")
@@ -1281,28 +1281,27 @@ public String toString() {
     }
   };
 
-  public static final Builder<List<StreamConsumersInfo>> STREAM_CONSUMERS_INFO_LIST = new Builder<List<StreamConsumersInfo>>() {
+  public static final Builder<List<StreamConsumerInfo>> STREAM_CONSUMER_INFO_LIST = new Builder<List<StreamConsumerInfo>>() {
 
     Map<String, Builder> mappingFunctions = createDecoderMap();
 
     private Map<String, Builder> createDecoderMap() {
       Map<String, Builder> tempMappingFunctions = new HashMap<>();
-      tempMappingFunctions.put(StreamConsumersInfo.NAME, STRING);
-      tempMappingFunctions.put(StreamConsumersInfo.IDLE, LONG);
-      tempMappingFunctions.put(StreamGroupInfo.PENDING, LONG);
-      tempMappingFunctions.put(StreamGroupInfo.LAST_DELIVERED, STRING);
+      tempMappingFunctions.put(StreamConsumerInfo.NAME, STRING);
+      tempMappingFunctions.put(StreamConsumerInfo.IDLE, LONG);
+      tempMappingFunctions.put(StreamConsumerInfo.PENDING, LONG);
       return tempMappingFunctions;
 
     }
 
     @Override
     @SuppressWarnings("unchecked")
-    public List<StreamConsumersInfo> build(Object data) {
+    public List<StreamConsumerInfo> build(Object data) {
       if (null == data) {
         return null;
       }
 
-      List<StreamConsumersInfo> list = new ArrayList<>();
+      List<StreamConsumerInfo> list = new ArrayList<>();
       List<Object> streamsEntries = (List<Object>) data;
       Iterator<Object> groupsArray = streamsEntries.iterator();
 
@@ -1312,7 +1311,7 @@ public List<StreamConsumersInfo> build(Object data) {
 
         Iterator<Object> consumerInfoIterator = groupInfo.iterator();
 
-        StreamConsumersInfo streamGroupInfo = new StreamConsumersInfo(
+        StreamConsumerInfo streamGroupInfo = new StreamConsumerInfo(
             createMapFromDecodingFunctions(consumerInfoIterator, mappingFunctions));
         list.add(streamGroupInfo);
 
@@ -1413,7 +1412,7 @@ public String toString() {
     }
   };
 
-  public static final Builder<StreamFullInfo> STREAM_INFO_FULL = new Builder<StreamFullInfo>() {
+  public static final Builder<StreamFullInfo> STREAM_FULL_INFO = new Builder<StreamFullInfo>() {
 
     final Map<String, Builder> mappingFunctions = createDecoderMap();
 
diff --git a/src/main/java/redis/clients/jedis/CommandObjects.java b/src/main/java/redis/clients/jedis/CommandObjects.java
@@ -2524,7 +2524,7 @@ public final CommandObject<Map.Entry<StreamEntryID, List<StreamEntryID>>> xautoc
       XAutoClaimParams params) {
     return new CommandObject<>(commandArguments(XAUTOCLAIM).key(key).add(group)
         .add(consumerName).add(minIdleTime).add(start).addParams(params)
-        .add(JUSTID), BuilderFactory.STREAM_AUTO_CLAIM_ID_RESPONSE);
+        .add(JUSTID), BuilderFactory.STREAM_AUTO_CLAIM_JUSTID_RESPONSE);
   }
 
   public final CommandObject<List<byte[]>> xclaim(byte[] key, byte[] group,
@@ -2564,11 +2564,11 @@ public final CommandObject<Object> xinfoStream(byte[] key) {
   }
 
   public final CommandObject<StreamFullInfo> xinfoStreamFull(String key) {
-    return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL), BuilderFactory.STREAM_INFO_FULL);
+    return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL), BuilderFactory.STREAM_FULL_INFO);
   }
 
   public final CommandObject<StreamFullInfo> xinfoStreamFull(String key, int count) {
-    return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL).add(COUNT).add(count), BuilderFactory.STREAM_INFO_FULL);
+    return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL).add(COUNT).add(count), BuilderFactory.STREAM_FULL_INFO);
   }
 
   public final CommandObject<Object> xinfoStreamFull(byte[] key, int count) {
@@ -2587,8 +2587,8 @@ public final CommandObject<List<Object>> xinfoGroups(byte[] key) {
     return new CommandObject<>(commandArguments(XINFO).add(GROUPS).key(key), BuilderFactory.RAW_OBJECT_LIST);
   }
 
-  public final CommandObject<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {
-    return new CommandObject<>(commandArguments(XINFO).add(CONSUMERS).key(key).add(group), BuilderFactory.STREAM_CONSUMERS_INFO_LIST);
+  public final CommandObject<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {
+    return new CommandObject<>(commandArguments(XINFO).add(CONSUMERS).key(key).add(group), BuilderFactory.STREAM_CONSUMER_INFO_LIST);
   }
 
   public final CommandObject<List<Object>> xinfoConsumers(byte[] key, byte[] group) {
diff --git a/src/main/java/redis/clients/jedis/Jedis.java b/src/main/java/redis/clients/jedis/Jedis.java
@@ -9442,7 +9442,7 @@ public List<StreamGroupInfo> xinfoGroups(String key) {
   }
 
   @Override
-  public List<StreamConsumersInfo> xinfoConsumers(String key, String group) {
+  public List<StreamConsumerInfo> xinfoConsumers(String key, String group) {
     return connection.executeCommand(commandObjects.xinfoConsumers(key, group));
   }
 
diff --git a/src/main/java/redis/clients/jedis/MultiNodePipelineBase.java b/src/main/java/redis/clients/jedis/MultiNodePipelineBase.java
@@ -1613,7 +1613,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {
   }
 
   @Override
-  public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {
+  public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {
     return appendCommand(commandObjects.xinfoConsumers(key, group));
   }
 
diff --git a/src/main/java/redis/clients/jedis/Pipeline.java b/src/main/java/redis/clients/jedis/Pipeline.java
@@ -1566,7 +1566,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {
   }
 
   @Override
-  public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {
+  public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {
     return appendCommand(commandObjects.xinfoConsumers(key, group));
   }
 
diff --git a/src/main/java/redis/clients/jedis/TransactionBase.java b/src/main/java/redis/clients/jedis/TransactionBase.java
@@ -1662,7 +1662,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {
   }
 
   @Override
-  public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {
+  public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {
     return appendCommand(commandObjects.xinfoConsumers(key, group));
   }
 
diff --git a/src/main/java/redis/clients/jedis/UnifiedJedis.java b/src/main/java/redis/clients/jedis/UnifiedJedis.java
@@ -2997,7 +2997,7 @@ public List<StreamGroupInfo> xinfoGroups(String key) {
   }
 
   @Override
-  public List<StreamConsumersInfo> xinfoConsumers(String key, String group) {
+  public List<StreamConsumerInfo> xinfoConsumers(String key, String group) {
     return executeCommand(commandObjects.xinfoConsumers(key, group));
   }
 
diff --git a/src/main/java/redis/clients/jedis/commands/StreamCommands.java b/src/main/java/redis/clients/jedis/commands/StreamCommands.java
@@ -225,10 +225,10 @@ Map.Entry<StreamEntryID, List<StreamEntryID>> xautoclaimJustId(String key, Strin
    * Introspection command used in order to retrieve different information about consumers in the group
    * @param key Stream name
    * @param group Group name
-   * @return List of {@link StreamConsumersInfo} containing information about consumers that belong
+   * @return List of {@link StreamConsumerInfo} containing information about consumers that belong
    * to the the group
    */
-  List<StreamConsumersInfo> xinfoConsumers(String key, String group);
+  List<StreamConsumerInfo> xinfoConsumers(String key, String group);
 
   /**
    * XREAD [COUNT count] [BLOCK milliseconds] STREAMS key [key ...] ID [ID ...]
diff --git a/src/main/java/redis/clients/jedis/commands/StreamPipelineCommands.java b/src/main/java/redis/clients/jedis/commands/StreamPipelineCommands.java
@@ -218,10 +218,10 @@ Response<Map.Entry<StreamEntryID, List<StreamEntryID>>> xautoclaimJustId(String
    * Introspection command used in order to retrieve different information about consumers in the group
    * @param key Stream name
    * @param group Group name
-   * @return List of {@link StreamConsumersInfo} containing information about consumers that belong
+   * @return List of {@link StreamConsumerInfo} containing information about consumers that belong
    * to the the group
    */
-  Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group);
+  Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group);
 
   /**
    * XREAD [COUNT count] [BLOCK milliseconds] STREAMS key [key ...] ID [ID ...]
diff --git a/src/main/java/redis/clients/jedis/resps/StreamConsumerFullInfo.java b/src/main/java/redis/clients/jedis/resps/StreamConsumerFullInfo.java
@@ -6,9 +6,10 @@
 import redis.clients.jedis.StreamEntryID;
 
 /**
- * This class holds information about a stream consumer with command {@code xinfo stream mystream full}.
- * They can be access via getters. For future purpose there is also {@link #getConsumerInfo()} method that
- * returns a generic {@link Map} - in case where more info is returned from the server.
+ * This class holds information about a stream consumer with command
+ * {@code xinfo stream mystream full}. They can be access via getters. There is also
+ * {@link StreamConsumerFullInfo#getConsumerInfo()} method that returns a generic {@link Map} in
+ * case more info are returned from the server.
  */
 public class StreamConsumerFullInfo implements Serializable {
 
diff --git a/src/main/java/redis/clients/jedis/resps/StreamConsumerInfo.java b/src/main/java/redis/clients/jedis/resps/StreamConsumerInfo.java
@@ -3,12 +3,11 @@
 import java.util.Map;
 
 /**
- * This class holds information about a consumer. They can be access via getters. For future purpose
- * there is also {@link #getConsumerInfo()}} method that returns a generic {@code Map} - in case
- * where more info is returned from the server.
+ * This class holds information about a consumer. They can be access via getters. There is also
+ * {@link StreamConsumerInfo#getConsumerInfo()}} method that returns a generic {@code Map} in case
+ * more info are returned from the server.
  */
-// TODO: Rename to StreamConsumerInfo
-public class StreamConsumersInfo {
+public class StreamConsumerInfo {
 
   public static final String NAME = "name";
   public static final String IDLE = "idle";
@@ -22,13 +21,11 @@ public class StreamConsumersInfo {
   /**
    * @param map contains key-value pairs with consumer info
    */
-  public StreamConsumersInfo(Map<String, Object> map) {
-
+  public StreamConsumerInfo(Map<String, Object> map) {
     consumerInfo = map;
     name = (String) map.get(NAME);
     idle = (long) map.get(IDLE);
     pending = (long) map.get(PENDING);
-
   }
 
   public String getName() {
@@ -49,5 +46,4 @@ public long getPending() {
   public Map<String, Object> getConsumerInfo() {
     return consumerInfo;
   }
-
 }
diff --git a/src/main/java/redis/clients/jedis/resps/StreamFullInfo.java b/src/main/java/redis/clients/jedis/resps/StreamFullInfo.java
@@ -8,8 +8,8 @@
 
 /**
  * This class holds information about a stream info with command {@code xinfo stream mystream full}.
- * They can be access via getters. For future purpose there is also {@link #getStreamFullInfo()} method
- * that returns a generic {@link Map} - in case where more info is returned from the server.
+ * They can be access via getters. There is also {@link StreamFullInfo#getStreamFullInfo()} method
+ * that returns a generic {@link Map} in case where more info are returned from the server.
  */
 public class StreamFullInfo implements Serializable {
 
diff --git a/src/main/java/redis/clients/jedis/resps/StreamGroupFullInfo.java b/src/main/java/redis/clients/jedis/resps/StreamGroupFullInfo.java
@@ -8,8 +8,8 @@
 
 /**
  * This class holds information about a stream group with command {@code xinfo stream mystream full}.
- * They can be access via getters. For future purpose there is also {@link #getGroupFullInfo()} method
- * that returns a generic {@link Map} - in case where more info is returned from the server.
+ * They can be access via getters. There is also {@link StreamGroupFullInfo#getGroupFullInfo()}
+ * method that returns a generic {@link Map} in case more info are returned from the server.
  */
 public class StreamGroupFullInfo implements Serializable {
 
diff --git a/src/main/java/redis/clients/jedis/resps/StreamGroupInfo.java b/src/main/java/redis/clients/jedis/resps/StreamGroupInfo.java
@@ -5,9 +5,9 @@
 import redis.clients.jedis.StreamEntryID;
 
 /**
- * This class holds information about a stream group. They can be access via getters. For future
- * purpose there is also {@link #getGroupInfo()} method that returns a generic {@code Map} - in case
- * where more info is returned from the server.
+ * This class holds information about a stream group. They can be access via getters. There is also
+ * {@link StreamGroupInfo#getGroupInfo()} method that returns a generic {@code Map} in case more
+ * info are returned from the server.
  */
 public class StreamGroupInfo implements Serializable {
 
diff --git a/src/main/java/redis/clients/jedis/resps/StreamInfo.java b/src/main/java/redis/clients/jedis/resps/StreamInfo.java
@@ -5,11 +5,10 @@
 import redis.clients.jedis.StreamEntryID;
 
 /**
- * This class holds information about stream. They can be access via getters. For future purpose
- * there is also {@link #getStreamInfo} method that returns a generic {@code Map} - in case where
- * more info is returned from the server.
+ * This class holds information about stream. They can be access via getters. There is also
+ * {@link StreamInfo#getStreamInfo} method that returns a generic {@code Map} in case more info are
+ * returned from the server.
  */
-
 public class StreamInfo implements Serializable {
 
   public static final String LENGTH = "length";
diff --git a/src/main/java/redis/clients/jedis/util/DoublePrecision.java b/src/main/java/redis/clients/jedis/util/DoublePrecision.java
@@ -35,7 +35,7 @@ public static Double parseFloatingPointNumber(String str) throws NumberFormatExc
     }
   }
 
-  public static Double parseEncodedFloatingPointNumber(Object val) {
+  public static Double parseEncodedFloatingPointNumber(Object val) throws NumberFormatException {
     if (val == null) return null;
     else if (val instanceof Double) return (Double) val;
     else return parseFloatingPointNumber((String) val);
diff --git a/src/test/java/redis/clients/jedis/commands/jedis/StreamsCommandsTest.java b/src/test/java/redis/clients/jedis/commands/jedis/StreamsCommandsTest.java

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# Jedis 3 to Jedis 4 Breaking Changes`
	`1`	`+# Jedis 4 Breaking Changes`
`2`	`2`
`3`	`3`	- The `BinaryJedis` and `BinaryJedisCluster` classes have been removed.
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -2524,7 +2524,7 @@ public final CommandObject<Map.Entry<StreamEntryID, List<StreamEntryID>>> xautoc`
`2524`	`2524`	`XAutoClaimParams params) {`
`2525`	`2525`	`return new CommandObject<>(commandArguments(XAUTOCLAIM).key(key).add(group)`
`2526`	`2526`	`.add(consumerName).add(minIdleTime).add(start).addParams(params)`
`2527`		`- .add(JUSTID), BuilderFactory.STREAM_AUTO_CLAIM_ID_RESPONSE);`
	`2527`	`+ .add(JUSTID), BuilderFactory.STREAM_AUTO_CLAIM_JUSTID_RESPONSE);`
`2528`	`2528`	`}`
`2529`	`2529`
`2530`	`2530`	`public final CommandObject<List<byte[]>> xclaim(byte[] key, byte[] group,`
`@@ -2564,11 +2564,11 @@ public final CommandObject<Object> xinfoStream(byte[] key) {`
`2564`	`2564`	`}`
`2565`	`2565`
`2566`	`2566`	`public final CommandObject<StreamFullInfo> xinfoStreamFull(String key) {`
`2567`		`- return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL), BuilderFactory.STREAM_INFO_FULL);`
	`2567`	`+ return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL), BuilderFactory.STREAM_FULL_INFO);`
`2568`	`2568`	`}`
`2569`	`2569`
`2570`	`2570`	`public final CommandObject<StreamFullInfo> xinfoStreamFull(String key, int count) {`
`2571`		`- return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL).add(COUNT).add(count), BuilderFactory.STREAM_INFO_FULL);`
	`2571`	`+ return new CommandObject<>(commandArguments(XINFO).add(STREAM).key(key).add(FULL).add(COUNT).add(count), BuilderFactory.STREAM_FULL_INFO);`
`2572`	`2572`	`}`
`2573`	`2573`
`2574`	`2574`	`public final CommandObject<Object> xinfoStreamFull(byte[] key, int count) {`
`@@ -2587,8 +2587,8 @@ public final CommandObject<List<Object>> xinfoGroups(byte[] key) {`
`2587`	`2587`	`return new CommandObject<>(commandArguments(XINFO).add(GROUPS).key(key), BuilderFactory.RAW_OBJECT_LIST);`
`2588`	`2588`	`}`
`2589`	`2589`
`2590`		`- public final CommandObject<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {`
`2591`		`- return new CommandObject<>(commandArguments(XINFO).add(CONSUMERS).key(key).add(group), BuilderFactory.STREAM_CONSUMERS_INFO_LIST);`
	`2590`	`+ public final CommandObject<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {`
	`2591`	`+ return new CommandObject<>(commandArguments(XINFO).add(CONSUMERS).key(key).add(group), BuilderFactory.STREAM_CONSUMER_INFO_LIST);`
`2592`	`2592`	`}`
`2593`	`2593`
`2594`	`2594`	`public final CommandObject<List<Object>> xinfoConsumers(byte[] key, byte[] group) {`
Original file line number	Diff line number	Diff line change
`@@ -9442,7 +9442,7 @@ public List<StreamGroupInfo> xinfoGroups(String key) {`
`9442`	`9442`	`}`
`9443`	`9443`
`9444`	`9444`	`@Override`
`9445`		`- public List<StreamConsumersInfo> xinfoConsumers(String key, String group) {`
	`9445`	`+ public List<StreamConsumerInfo> xinfoConsumers(String key, String group) {`
`9446`	`9446`	`return connection.executeCommand(commandObjects.xinfoConsumers(key, group));`
`9447`	`9447`	`}`
`9448`	`9448`
Original file line number	Diff line number	Diff line change
`@@ -1613,7 +1613,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {`
`1613`	`1613`	`}`
`1614`	`1614`
`1615`	`1615`	`@Override`
`1616`		`- public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {`
	`1616`	`+ public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {`
`1617`	`1617`	`return appendCommand(commandObjects.xinfoConsumers(key, group));`
`1618`	`1618`	`}`
`1619`	`1619`
Original file line number	Diff line number	Diff line change
`@@ -1566,7 +1566,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {`
`1566`	`1566`	`}`
`1567`	`1567`
`1568`	`1568`	`@Override`
`1569`		`- public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {`
	`1569`	`+ public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {`
`1570`	`1570`	`return appendCommand(commandObjects.xinfoConsumers(key, group));`
`1571`	`1571`	`}`
`1572`	`1572`
Original file line number	Diff line number	Diff line change
`@@ -1662,7 +1662,7 @@ public Response<List<StreamGroupInfo>> xinfoGroups(String key) {`
`1662`	`1662`	`}`
`1663`	`1663`
`1664`	`1664`	`@Override`
`1665`		`- public Response<List<StreamConsumersInfo>> xinfoConsumers(String key, String group) {`
	`1665`	`+ public Response<List<StreamConsumerInfo>> xinfoConsumers(String key, String group) {`
`1666`	`1666`	`return appendCommand(commandObjects.xinfoConsumers(key, group));`
`1667`	`1667`	`}`
`1668`	`1668`
Original file line number	Diff line number	Diff line change
`@@ -2997,7 +2997,7 @@ public List<StreamGroupInfo> xinfoGroups(String key) {`
`2997`	`2997`	`}`
`2998`	`2998`
`2999`	`2999`	`@Override`
`3000`		`- public List<StreamConsumersInfo> xinfoConsumers(String key, String group) {`
	`3000`	`+ public List<StreamConsumerInfo> xinfoConsumers(String key, String group) {`
`3001`	`3001`	`return executeCommand(commandObjects.xinfoConsumers(key, group));`
`3002`	`3002`	`}`
`3003`	`3003`