From a96f3a0f0e7e7abe0d8396891008ee1290eb8cf0 Mon Sep 17 00:00:00 2001 From: ggivo Date: Tue, 19 Aug 2025 13:50:40 +0300 Subject: [PATCH 1/3] Attemot to fix flaky test Error: Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.297 s <<< FAILURE! -- in redis.clients.jedis.failover.FailoverIntegrationTest Error: redis.clients.jedis.failover.FailoverIntegrationTest.testManualFailoverInflightCommandsWithErrorsPropagateError -- Time elapsed: 0.035 s <<< ERROR! redis.clients.jedis.exceptions.JedisValidationException: cluster:localhost:29380 failed to connect. Please check configuration and try again. at redis.clients.jedis.providers.MultiClusterPooledConnectionProvider.validateTargetConnection(MultiClusterPooledConnectionProvider.java:481) at redis.clients.jedis.providers.MultiClusterPooledConnectionProvider.setActiveCluster(MultiClusterPooledConnectionProvider.java:526) at redis.clients.jedis.providers.MultiClusterPooledConnectionProvider.setActiveCluster(MultiClusterPooledConnectionProvider.java:494) at redis.clients.jedis.failover.FailoverIntegrationTest.testManualFailoverInflightCommandsWithErrorsPropagateError(FailoverIntegrationTest.java:217) at java.lang.reflect.Method.invoke(Method.java:498) at java.util.ArrayList.forEach(ArrayList.java:1259) at java.util.ArrayList.forEach(ArrayList.java:1259) Caused by: redis.clients.jedis.exceptions.JedisConnectionException: Cluster is not healthy at redis.clients.jedis.providers.MultiClusterPooledConnectionProvider$Cluster.getConnection(MultiClusterPooledConnectionProvider.java:653) at redis.clients.jedis.providers.MultiClusterPooledConnectionProvider.validateTargetConnection(MultiClusterPooledConnectionProvider.java:471) ... 6 more --- .../jedis/failover/FailoverIntegrationTest.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java b/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java index b43676c88d..b26c53b2bd 100644 --- a/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java +++ b/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java @@ -171,12 +171,13 @@ public void testManualFailoverNewCommandsAreSentToActiveCluster() throws Interru assertThat(getNodeId(failoverClient.info("server")), equalTo(JEDIS2_ID)); } - private List getClusterConfigs(JedisClientConfig clientConfig, - EndpointConfig... endpoints) { + private List getClusterConfigs( + JedisClientConfig clientConfig, EndpointConfig... endpoints) { - return Arrays.stream(endpoints) - .map(e -> MultiClusterClientConfig.ClusterConfig.builder(e.getHostAndPort(), clientConfig).build()) - .collect(Collectors.toList()); + return Arrays.stream(endpoints).map( + e -> MultiClusterClientConfig.ClusterConfig.builder(e.getHostAndPort(), clientConfig) + // Disable health checks to avoid interference during tests + .healthCheckEnabled(false).build()).collect(Collectors.toList()); } @Test From fb492a11b9f0caacac250532b701e0c5fb0d39f4 Mon Sep 17 00:00:00 2001 From: ggivo Date: Tue, 19 Aug 2025 13:57:36 +0300 Subject: [PATCH 2/3] retrigger checks From 20c63c0b3fe9e266b0dafe0f7a75fe9106e27607 Mon Sep 17 00:00:00 2001 From: ggivo Date: Tue, 19 Aug 2025 15:10:21 +0300 Subject: [PATCH 3/3] format --- .../jedis/failover/FailoverIntegrationTest.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java b/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java index b26c53b2bd..2c0076b646 100644 --- a/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java +++ b/src/test/java/redis/clients/jedis/failover/FailoverIntegrationTest.java @@ -171,13 +171,14 @@ public void testManualFailoverNewCommandsAreSentToActiveCluster() throws Interru assertThat(getNodeId(failoverClient.info("server")), equalTo(JEDIS2_ID)); } - private List getClusterConfigs( - JedisClientConfig clientConfig, EndpointConfig... endpoints) { + private List getClusterConfigs(JedisClientConfig clientConfig, + EndpointConfig... endpoints) { - return Arrays.stream(endpoints).map( - e -> MultiClusterClientConfig.ClusterConfig.builder(e.getHostAndPort(), clientConfig) + return Arrays.stream(endpoints) + .map(e -> MultiClusterClientConfig.ClusterConfig.builder(e.getHostAndPort(), clientConfig) // Disable health checks to avoid interference during tests - .healthCheckEnabled(false).build()).collect(Collectors.toList()); + .healthCheckEnabled(false).build()) + .collect(Collectors.toList()); } @Test