Skip to content

Commit 62e254a

Browse files
authored
Merge pull request #5 from SamFrancisco30/fix/decode-response-bug
Remove unnecessary decode calls in Redis operations
2 parents 84dbc45 + 00fc932 commit 62e254a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/tools/hash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ async def hget(name: str, key: str) -> str:
4343
try:
4444
r = RedisConnectionManager.get_connection()
4545
value = r.hget(name, key)
46-
return value.decode() if value else f"Field '{key}' not found in hash '{name}'."
46+
return value if value else f"Field '{key}' not found in hash '{name}'."
4747
except RedisError as e:
4848
return f"Error getting field '{key}' from hash '{name}': {str(e)}"
4949

src/tools/list.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ async def lpop(name: str) -> str:
3232
try:
3333
r = RedisConnectionManager.get_connection()
3434
value = r.lpop(name)
35-
return value.decode() if value else f"List '{name}' is empty or does not exist."
35+
return value if value else f"List '{name}' is empty or does not exist."
3636
except RedisError as e:
3737
return f"Error popping value from list '{name}': {str(e)}"
3838

@@ -42,7 +42,7 @@ async def rpop(name: str) -> str:
4242
try:
4343
r = RedisConnectionManager.get_connection()
4444
value = r.rpop(name)
45-
return value.decode() if value else f"List '{name}' is empty or does not exist."
45+
return value if value else f"List '{name}' is empty or does not exist."
4646
except RedisError as e:
4747
return f"Error popping value from list '{name}': {str(e)}"
4848

@@ -52,7 +52,7 @@ async def lrange(name: str, start: int, stop: int) -> list:
5252
try:
5353
r = RedisConnectionManager.get_connection()
5454
values = r.lrange(name, start, stop)
55-
return [v.decode() for v in values] if values else f"List '{name}' is empty or does not exist."
55+
return [v for v in values] if values else f"List '{name}' is empty or does not exist."
5656
except RedisError as e:
5757
return f"Error retrieving values from list '{name}': {str(e)}"
5858

src/tools/misc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ async def type(key: str) -> Dict[str, Any]:
3434
"""
3535
try:
3636
r = RedisConnectionManager.get_connection()
37-
key_type = r.type(key).decode('utf-8')
37+
key_type = r.type(key)
3838
info = {
3939
'key': key,
4040
'type': key_type,

0 commit comments

Comments
 (0)