Linting fixes

Author: tishun

tests/test_config.py

@@ -3,7 +3,7 @@
 """
 
 import pytest
-from unittest.mock import patch, Mock
+from unittest.mock import patch
 import os
 
 from src.common.config import parse_redis_uri, set_redis_config_from_cli, REDIS_CFG

tests/test_connection.py

@@ -3,10 +3,8 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch, MagicMock
-import redis
-from redis.cluster import RedisCluster
-from redis.exceptions import ConnectionError, TimeoutError, RedisError
+from unittest.mock import Mock, patch
+from redis.exceptions import ConnectionError
 
 from src.common.connection import RedisConnectionManager
 
@@ -153,6 +151,7 @@ def test_get_connection_with_decode_responses_false(self, mock_config, mock_redi
         mock_redis_class.return_value = mock_redis_instance
 
         connection = RedisConnectionManager.get_connection(decode_responses=False)
+        assert connection == mock_redis_instance
 
         call_args = mock_redis_class.call_args[1]
         assert call_args["decode_responses"] is False
@@ -180,6 +179,7 @@ def test_get_connection_with_ssl_configuration(self, mock_config, mock_redis_cla
         mock_redis_class.return_value = mock_redis_instance
 
         connection = RedisConnectionManager.get_connection()
+        assert connection == mock_redis_instance
 
         call_args = mock_redis_class.call_args[1]
         assert call_args["ssl"] is True
@@ -213,6 +213,8 @@ def test_get_connection_includes_version_in_lib_name(self, mock_config, mock_red
 
         with patch('src.common.connection.__version__', '1.0.0'):
             connection = RedisConnectionManager.get_connection()
+
+            assert connection == mock_redis_instance
 
             call_args = mock_redis_class.call_args[1]
             assert "redis-py(mcp-server_v1.0.0)" in call_args["lib_name"]
@@ -304,6 +306,8 @@ def test_connection_parameters_filtering(self, mock_config, mock_redis_class):
         mock_redis_class.return_value = mock_redis_instance
 
         connection = RedisConnectionManager.get_connection()
+
+        assert connection == mock_redis_instance
 
         call_args = mock_redis_class.call_args[1]
         assert call_args["username"] is None

tests/test_main.py

@@ -3,9 +3,8 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch, MagicMock
+from unittest.mock import Mock, patch
 from click.testing import CliRunner
-import sys
 
 from src.main import RedisMCPServer, cli
 
@@ -15,7 +14,6 @@ class TestRedisMCPServer:
 
     def test_init_prints_startup_message(self, capsys):
         """Test that RedisMCPServer initialization prints startup message."""
-        server = RedisMCPServer()
         captured = capsys.readouterr()
         assert "Starting the Redis MCP Server" in captured.err
 

tests/test_server.py

@@ -2,8 +2,7 @@
 Unit tests for src/common/server.py
 """
 
-import pytest
-from unittest.mock import Mock, patch
+from unittest.mock import patch
 
 from src.common.server import mcp
 

tests/tools/test_hash.py

@@ -3,9 +3,8 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch
 import numpy as np
-from redis.exceptions import RedisError, ConnectionError
+from redis.exceptions import RedisError
 
 from src.tools.hash import hset, hget, hgetall, hdel, hexists, set_vector_in_hash, get_vector_from_hash
 

tests/tools/test_json.py

@@ -3,9 +3,7 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch
-import json
-from redis.exceptions import RedisError, ConnectionError
+from redis.exceptions import RedisError
 
 from src.tools.json import json_set, json_get, json_del
 

tests/tools/test_list.py

@@ -3,8 +3,7 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch
-from redis.exceptions import RedisError, ConnectionError
+from redis.exceptions import RedisError
 
 from src.tools.list import lpush, rpush, lpop, rpop, lrange, llen
 

tests/tools/test_redis_query_engine.py

@@ -5,8 +5,7 @@
 import pytest
 from unittest.mock import Mock, patch
 import json
-import numpy as np
-from redis.exceptions import RedisError, ConnectionError
+from redis.exceptions import RedisError
 from redis.commands.search.field import VectorField
 from redis.commands.search.index_definition import IndexDefinition
 from redis.commands.search.query import Query
@@ -298,7 +297,8 @@ async def test_vector_search_with_large_k(self, mock_redis_connection_manager, s
             mock_np_array.return_value.astype.return_value.tobytes.return_value = b'query_vector_bytes'
 
             result = await vector_search_hash(sample_vector, k=1000)
-            
+            assert result == []  # Empty list when no results
+
             # Should handle large k values
             mock_ft.search.assert_called_once()
 

tests/tools/test_server_management.py

@@ -3,7 +3,6 @@
 """
 
 import pytest
-from unittest.mock import Mock, patch
 from redis.exceptions import RedisError, ConnectionError
 
 from src.tools.server_management import dbsize, info, client_list

tests/tools/test_set.py

@@ -4,7 +4,7 @@
 
 import pytest
 from unittest.mock import Mock, patch
-from redis.exceptions import RedisError, ConnectionError
+from redis.exceptions import RedisError
 
 from src.tools.set import sadd, srem, smembers