perf(ts)!: move multi() away from RedisClient

RedisClientMultiCommandType is slow to typecheck because of its recursive
nature and the fact that it has many ( around 700 ) methods.
Most of the users dont use multi(), so there is no point to incur the ts
costs to them. One possible solution is to move the multi() method away from
the main RedisClient, thus typechecking will not apply to RedisClientMultiCommandType.

This is a breaking change.

Usage before:

import { createClient } from 'redis';
const client = createClient();
cont result = await client.multi()
  .set('foo', 3)
  .get('bar')
  .execTyped();

Usage after:

import { createClient, multi } from 'redis';
const client = createClient();
cont result = await multi(client)
  .set('foo', 3)
  .get('bar')
  .execTyped();

Author: nkaradzhov

packages/client/index.ts

@@ -12,7 +12,9 @@ export { VerbatimString } from './lib/RESP/verbatim-string';
 export { defineScript } from './lib/lua-script';
 export * from './lib/errors';
 
+import { RedisFunctions, RedisModules, RedisScripts, RespVersions, TypeMapping } from './lib/RESP/types';
 import RedisClient, { RedisClientOptions, RedisClientType } from './lib/client';
+import RedisClientMultiCommand, { RedisClientMultiCommandType } from './lib/client/multi-command';
 export { RedisClientOptions, RedisClientType };
 export const createClient = RedisClient.create;
 export { CommandParser } from './lib/client/parser';
@@ -37,3 +39,13 @@ export { REDIS_FLUSH_MODES } from './lib/commands/FLUSHALL';
 
 export { BasicClientSideCache, BasicPooledClientSideCache } from './lib/client/cache';
 
+
+
+export const MULTI = < M extends RedisModules, F extends RedisFunctions, S extends RedisScripts, RESP extends RespVersions, TYPE_MAPPING extends TypeMapping >(client: RedisClientType) => {
+  type Multi = new (...args: ConstructorParameters<typeof RedisClientMultiCommand>) => RedisClientMultiCommandType<[], M, F, S, RESP, TYPE_MAPPING>;
+  return new ((this as any).Multi as Multi)(
+    client._executeMulti.bind(client),
+    client._executePipeline.bind(client),
+    client._commandOptions?.typeMapping
+  );
+}

packages/client/lib/client/index.ts

@@ -9,7 +9,6 @@ import { URL } from 'node:url';
 import { TcpSocketConnectOpts } from 'node:net';
 import { PUBSUB_TYPE, PubSubType, PubSubListener, PubSubTypeListeners, ChannelListeners } from './pub-sub';
 import { Command, CommandSignature, TypeMapping, CommanderConfig, RedisFunction, RedisFunctions, RedisModules, RedisScript, RedisScripts, ReplyUnion, RespVersions, RedisArgument, ReplyWithTypeMapping, SimpleStringReply, TransformReply, CommandArguments } from '../RESP/types';
-import RedisClientMultiCommand, { RedisClientMultiCommandType } from './multi-command';
 import { RedisMultiQueuedCommand } from '../multi-command';
 import HELLO, { HelloOptions } from '../commands/HELLO';
 import { ScanOptions, ScanCommonOptions } from '../commands/SCAN';
@@ -21,6 +20,7 @@ import { BasicCommandParser, CommandParser } from './parser';
 import SingleEntryCache from '../single-entry-cache';
 import { version } from '../../package.json'
 import EnterpriseMaintenanceManager, { MaintenanceUpdate, MovingEndpointType } from './enterprise-maintenance-manager';
+import RedisClientMultiCommand from './multi-command';
 
 export interface RedisClientOptions<
   M extends RedisModules = RedisModules,
@@ -435,7 +435,7 @@ export default class RedisClient<
   #selectedDB = 0;
   #monitorCallback?: MonitorCallback<TYPE_MAPPING>;
   private _self = this;
-  private _commandOptions?: CommandOptions<TYPE_MAPPING>;
+  _commandOptions?: CommandOptions<TYPE_MAPPING>;
   // flag used to annotate that the client
   // was in a watch transaction when
   // a topology change occured
@@ -1315,17 +1315,6 @@ export default class RedisClient<
     return execResult as Array<unknown>;
   }
 
-  MULTI() {
-    type Multi = new (...args: ConstructorParameters<typeof RedisClientMultiCommand>) => RedisClientMultiCommandType<[], M, F, S, RESP, TYPE_MAPPING>;
-    return new ((this as any).Multi as Multi)(
-      this._executeMulti.bind(this),
-      this._executePipeline.bind(this),
-      this._commandOptions?.typeMapping
-    );
-  }
-
-  multi = this.MULTI;
-
   async* scanIterator(
     this: RedisClientType<M, F, S, RESP, TYPE_MAPPING>,
     options?: ScanOptions & ScanIteratorOptions