Exchange queue with a better one

Author: Ruben Bridgewater

changelog.md

@@ -7,6 +7,7 @@ Features
 
 -  Added disable_resubscribing option to prevent a client from resubscribing after reconnecting (@BridgeAR)
 -  Added rename_commands options to handle renamed commands from the redis config (@digmxl & @BridgeAR)
+-  Increase performance by exchanging built in queue with [Petka Antonov's](@petkaantonov) [double-ended queue](https://github.com/petkaantonov/deque) and prevent polymorphism (@BridgeAR)
 
 Bugfixes
 

index.js

@@ -4,7 +4,7 @@ var net = require('net');
 var URL = require('url');
 var util = require('util');
 var utils = require('./lib/utils');
-var Queue = require('./lib/queue');
+var Queue = require('double-ended-queue');
 var Command = require('./lib/command');
 var events = require('events');
 var parsers = [];
@@ -511,7 +511,7 @@ RedisClient.prototype.connection_gone = function (why) {
         this.retry_delay = this.connect_timeout - this.retry_totaltime;
     }
 
-    debug("Retry connection in " + this.retry_delay + " ms");
+    debug('Retry connection in ' + this.retry_delay + ' ms');
 
     this.retry_timer = setTimeout(retry_connection, this.retry_delay, this);
 };

lib/queue.js

@@ -25,11 +25,12 @@ function replyToStrings(reply) {
     }
 
     if (Array.isArray(reply)) {
+        var res = new Array(reply.length);
         for (i = 0; i < reply.length; i++) {
             // Recusivly call the function as slowlog returns deep nested replies
-            reply[i] = replyToStrings(reply[i]);
+            res[i] = replyToStrings(reply[i]);
         }
-        return reply;
+        return res;
     }
 
     return reply;

lib/utils.js

@@ -17,6 +17,9 @@
     "pretest": "optional-dev-dependency hiredis",
     "posttest": "jshint ."
   },
+  "dependencies": {
+    "double-ended-queue": "^2.1.0-0"
+  },
   "devDependencies": {
     "coveralls": "^2.11.2",
     "jshint": "^2.8.0",