parse subcommands, update static policies

actually fetched from server using the dynamic resolver

Author: nkaradzhov

packages/client/lib/cluster/index.ts

@@ -465,8 +465,10 @@ export default class RedisCluster<
     commandName: string,
     fn: (client: RedisClientType<M, F, S, RESP, TYPE_MAPPING>, opts?: ClusterCommandOptions) => Promise<T>
   ): Promise<T> {
+
     const maxCommandRedirections = this._options.maxCommandRedirections ?? 16;
     const policyResult = this._policyResolver.resolvePolicy(commandName)
+
     if(policyResult.ok) {
       //TODO
     } else {

packages/client/lib/cluster/request-response-policies/dynamic-policy-resolver-factory.ts

@@ -1,9 +1,8 @@
 import type { CommandReply } from '../../commands/generic-transformers';
 import type { CommandPolicies } from './policies-constants';
 import { REQUEST_POLICIES_WITH_DEFAULTS, RESPONSE_POLICIES_WITH_DEFAULTS } from './policies-constants';
-import type { PolicyResolver } from './types';
+import type { PolicyResolver, ModulePolicyRecords } from './types';
 import { StaticPolicyResolver } from './static-policy-resolver';
-import type { ModulePolicyRecords } from './static-policies-data';
 
 /**
  * Function type that returns command information from Redis
@@ -28,7 +27,7 @@ export class DynamicPolicyResolverFactory {
   static async create(
     commandFetcher: CommandFetcher,
     fallbackResolver?: PolicyResolver
-  ): Promise<StaticPolicyResolver> {
+  ): Promise<PolicyResolver> {
     const commands = await commandFetcher();
     const policies: ModulePolicyRecords = {};
 
@@ -98,10 +97,28 @@ export class DynamicPolicyResolverFactory {
     const defaultResponse = isKeyless
       ? RESPONSE_POLICIES_WITH_DEFAULTS.DEFAULT_KEYLESS
       : RESPONSE_POLICIES_WITH_DEFAULTS.DEFAULT_KEYED;
+    
+    let subcommands: Record<string, CommandPolicies> | undefined;
+    if(command.subcommands.length > 0) {
+      subcommands = {};
+      for (const subcommand of command.subcommands) {
+
+        // Subcommands are in format "parentCommand|subcommand"
+        const parts = subcommand.name.split("\|")
+        if(parts.length !== 2) {
+          throw new Error(`Invalid subcommand name: ${subcommand.name}`);
+        }
+        const subcommandName = parts[1];
+
+        subcommands[subcommandName] = DynamicPolicyResolverFactory.#buildCommandPolicies(subcommand);
+      }
+    }
 
     return {
       request: command.policies.request ?? defaultRequest,
-      response: command.policies.response ?? defaultResponse
+      response: command.policies.response ?? defaultResponse,
+      isKeyless,
+      subcommands
     };
   }
 }

packages/client/lib/cluster/request-response-policies/index.ts

@@ -1,10 +1,9 @@
-export type { Either, PolicyResult, PolicyResolver } from './types';
+export type { Either, PolicyResult, PolicyResolver, ModulePolicyRecords, CommandPolicyRecords } from './types';
 
 export { StaticPolicyResolver } from './static-policy-resolver';
 export { DynamicPolicyResolverFactory, type CommandFetcher } from './dynamic-policy-resolver-factory';
 
 export * from './policies-constants';
-export type { ModulePolicyRecords, CommandPolicyRecords } from './static-policies-data';
 export { POLICIES } from './static-policies-data';
 
 // export { type CommandRouter } from './command-router';

packages/client/lib/cluster/request-response-policies/policies-constants.ts

@@ -27,4 +27,6 @@ export type ResponsePolicyWithDefaults = typeof RESPONSE_POLICIES_WITH_DEFAULTS[
 export interface CommandPolicies {
   readonly request: RequestPolicyWithDefaults;
   readonly response: ResponsePolicyWithDefaults;
+  readonly subcommands?: Record<string, CommandPolicies>;
+  readonly isKeyless: boolean;
 }