properly transform vinfo result

Author: nkaradzhov

packages/client/lib/commands/VINFO.spec.ts

@@ -15,9 +15,41 @@ describe('VINFO', () => {
     await client.vAdd('key', [1.0, 2.0, 3.0], 'element');
 
     const result = await client.vInfo('key');
-    assert.ok(Array.isArray(result));
+    assert.ok(typeof result === 'object' && result !== null);
+
+    assert.equal(result['vector-dim'], 3);
+    assert.equal(result['size'], 1);
+    assert.ok('quant-type' in result);
+    assert.ok('hnsw-m' in result);
+    assert.ok('projection-input-dim' in result);
+    assert.ok('max-level' in result);
+    assert.ok('attributes-count' in result);
+    assert.ok('vset-uid' in result);
+    assert.ok('hnsw-max-node-uid' in result);
   }, {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vInfo with RESP3', async client => {
+    await client.vAdd('resp3-key', [1.0, 2.0, 3.0], 'resp3-element');
+
+    const result = await client.vInfo('resp3-key');
+    assert.ok(typeof result === 'object' && result !== null);
+
+    assert.equal(result['vector-dim'], 3);
+    assert.equal(result['size'], 1);
+    assert.ok('quant-type' in result);
+    assert.ok('hnsw-m' in result);
+    assert.ok('projection-input-dim' in result);
+    assert.ok('max-level' in result);
+    assert.ok('attributes-count' in result);
+    assert.ok('vset-uid' in result);
+    assert.ok('hnsw-max-node-uid' in result);
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VINFO.ts

@@ -1,5 +1,14 @@
 import { CommandParser } from '../client/parser';
-import { RedisArgument, ArrayReply, BlobStringReply, Command } from '../RESP/types';
+import { RedisArgument, Command, UnwrapReply, Resp2Reply, TuplesToMapReply, SimpleStringReply, NumberReply } from '../RESP/types';
+
+export type VInfoReplyMap = TuplesToMapReply<[
+  [SimpleStringReply<'quant-type'>, SimpleStringReply],
+  [SimpleStringReply<'vector-dim'>, NumberReply],
+  [SimpleStringReply<'size'>, NumberReply],
+  [SimpleStringReply<'max-level'>, NumberReply],
+  [SimpleStringReply<'vset-uid'>, NumberReply],
+  [SimpleStringReply<'hnsw-max-node-uid'>, NumberReply],
+]>;
 
 export default {
   IS_READ_ONLY: true,
@@ -14,5 +23,16 @@ export default {
     parser.push('VINFO');
     parser.pushKey(key);
   },
-  transformReply: undefined as unknown as () => ArrayReply<BlobStringReply>
+  transformReply: {
+    2: (reply: UnwrapReply<Resp2Reply<VInfoReplyMap>>): VInfoReplyMap => {
+      const ret = Object.create(null);
+
+      for (let i = 0; i < reply.length; i += 2) {
+        ret[reply[i].toString()] = reply[i + 1];
+      }
+
+      return ret as unknown as VInfoReplyMap;
+    },
+    3: undefined as unknown as () => VInfoReplyMap
+  }
 } as const satisfies Command;