Skip to content

Commit 4672479

Browse files
committed
If there's an error in SELECT and there's no callback, emit the error.
1 parent 2ff2a74 commit 4672479

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,8 @@ RedisClient.prototype.select = function (db, callback) {
978978
}
979979
if (typeof(callback) === 'function') {
980980
callback(err, res);
981+
} else if (err) {
982+
self.emit('error', err);
981983
}
982984
});
983985
};

test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,16 @@ tests.reconnect_select_db_after_pubsub = function() {
865865
});
866866
};
867867

868+
tests.select_error_emits_if_no_callback = function () {
869+
var name = "select_error_emits_if_no_callback";
870+
871+
client.on('error', with_timeout(name, function (err) {
872+
require_error(name)(err);
873+
next(name);
874+
}, 500));
875+
client.select(9999);
876+
};
877+
868878
tests.idle = function () {
869879
var name = "idle";
870880

0 commit comments

Comments
 (0)